From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC174C433E0 for ; Fri, 15 Jan 2021 11:13:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75F69236FB for ; Fri, 15 Jan 2021 11:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726184AbhAOLN1 (ORCPT ); Fri, 15 Jan 2021 06:13:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726105AbhAOLN0 (ORCPT ); Fri, 15 Jan 2021 06:13:26 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11CF1C061757 for ; Fri, 15 Jan 2021 03:12:46 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id u14so3064601wmq.4 for ; Fri, 15 Jan 2021 03:12:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8hOPqiKxYh57wkKCGDlQE85ouMI8Pjq2OXu/MBK/GBo=; b=ETWqj32EUC/lVfGcEnrERegA0IfyyyfTQBugipiNDz9oezr2FUyXSgNjERTQhyzitT 5zXV13jV2QfbErvJHqnJXkiPYsBMkih9apQHrrKK5OK+P2cn+nFP+Ujs56tF/3J76dwn keVommed8cXFUXxwKiyD162/yJ7T2BFhSzJjfZe3D2cGa/KQRowm71sEduN6Iv7WOasG YTMzC/kSxrOXgZqq9HUGrcg/gKygcFJ5m/Qoig8NtSgjLnr+xtM+RSMJwkjBGdQK5Bzn cCOQaIHk6N7aTrEH9W75pdoX+e69sE1IfFRjCJiB2kaTalfRhTLmS02MsZN+F2WBV+C5 Hndw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8hOPqiKxYh57wkKCGDlQE85ouMI8Pjq2OXu/MBK/GBo=; b=SHl9V09Op+08QYqwGsZx8EQYtCTV+J1SemuqRmTHmqmklrO3vU7PeonOoWQu9mBYWa ecuea0AfpfkhZ20AH9+LNOdu52vPswQM0ufsZdb9PbquQRqD5o0KASDCaYAQX65dvPxP MaafforoyCCNAD31kg8zRvwZ/RfcXSTJgntAErWNnccuzaeA/Wzimta9V2M0FwnkWiov qqa60jr2iyT3wXP6pzDZ5wSk8onE/ke7ELbS0O9taAGD2fL6l/vWjgKDy4SufZ/oThP/ RBzFn8epdl+laSOWAsJ9N6ltm8EYqasJn3l5nIkOB200Vy2xCIHQNF1umqrUbrrUNc7U q+sQ== X-Gm-Message-State: AOAM532Fb5nhyw1II0NIYLgRCmKb133LnGyasCRUWTZKNGEB1AX96kLg BIhdd4z4qUr8Yg4urJCivjk2eg== X-Google-Smtp-Source: ABdhPJxZxPpbEPACV3JGhyB3zfkvu0YT51nxUVRM08/3jMLDRr4l2mATYKPVXAsaURWiMAg+h9NBGQ== X-Received: by 2002:a1c:9ad5:: with SMTP id c204mr5322138wme.65.1610709164628; Fri, 15 Jan 2021 03:12:44 -0800 (PST) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id f68sm1305763wmf.6.2021.01.15.03.12.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jan 2021 03:12:43 -0800 (PST) Subject: Re: [PATCH 0/4] ASoC: qcom: Minor code cleanups for lpass-cpu To: Stephen Boyd , Mark Brown Cc: linux-kernel@vger.kernel.org, Liam Girdwood , Banajit Goswami , linux-arm-msm@vger.kernel.org, Patrick Lai , alsa-devel@alsa-project.org, V Sujith Kumar Reddy , Srinivasa Rao , Cheng-Yi Chiang References: <20210115034327.617223-1-swboyd@chromium.org> From: Srinivas Kandagatla Message-ID: Date: Fri, 15 Jan 2021 11:12:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20210115034327.617223-1-swboyd@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Thanks Stephen for the cleanup patches. All of them look good to me! On 15/01/2021 03:43, Stephen Boyd wrote: > Here's some minor code cleanups for the lpass-cpu driver. I noticed that > it casts away const from the driver data from DT. That's not great but > fixing it is a little more involved. I'll get to it later. There's also > some questionable clk_get() usage that should probably be > clk_get_optional(). For now this should help a little. > > Cc: V Sujith Kumar Reddy > Cc: Srinivasa Rao > Cc: Srinivas Kandagatla > Cc: Cheng-Yi Chiang > > Stephen Boyd (4): > ASoC: qcom: Remove useless debug print > ASoC: qcom: Add some names to regmap configs > ASoC: qcom: Stop casting away __iomem for error pointers > ASoC: qcom: Remove duplicate error messages on ioremap > > sound/soc/qcom/lpass-cpu.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > Reviewed-by: Srinivas Kandagatla >