From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D65623161AD for ; Thu, 16 Oct 2025 09:12:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760605956; cv=none; b=WdWQ5N9GeYGZp2l4WM+4UU9Cf/Oy4sW/g8t0SXSPTwdP8sLFIxB/zTex3p22GSZHFcZwcdtRn6GSujEYhV1k3F1F/C5Pl989fpH0Rcne9T8c2o8ZrYtRZjdu9TCyCtE+9GLwdGqAMipgj2VZdIMwq5EibhatFRLtCBcQV43SzZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760605956; c=relaxed/simple; bh=0rR+E3ejx6+LqmRsxZ8R3z54fEGmrrAvmI5TPxxh3wM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B4UZmyfzb4eVGRTIfNL36fmDAX4eFmU0baNoMe7bsiAlNAaFmf84uoWXutQN6hEvH+3SXsEI5umSvJH6AxAzvOkzMarpL7CZ+XG9PK4WFfBhxPDI5DQ0n7wH18++bOMewFMpybUKDSGXHmONDut5ejZqAUEeryzOlPx8orcRS94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=k2dCWKWW; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k2dCWKWW" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-46e6a6a5e42so2258315e9.0 for ; Thu, 16 Oct 2025 02:12:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760605953; x=1761210753; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lNA3qwCeih3DfGiyde2vBhejjH9yK2c7gfDj+YDJMBI=; b=k2dCWKWWPCYzFS99qkE9pZCE++JczIRP1SQ26lsqrmmhz8E9zKuTV/rWDrLWEM7oCv LRzwqIi+3WRovRH3iUM+eVE817ZizibbT6Us2ne88e7siRJmcmwISVYb3RrwvF1M/5GC 85S9tUaDjrZAZsRvRB+QYQFkBIEBlZziRwyx8iGxMbKm7JngrDcUPrsnz8oiXr1RIzvL cI8W9wxjGie8oe4CjrEAGWysLLW7IdiMGT4K23LmxIIOPPOzl5Z3o/U8HuKpWu/Qb60r E+vmIpIlaTP1ERT8+oOBofie9OIGvL/AmEFyIA+Xy25KtwP05C6yd6Up3PSwmPODRJsM 79tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760605953; x=1761210753; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lNA3qwCeih3DfGiyde2vBhejjH9yK2c7gfDj+YDJMBI=; b=euYvhA84qQ00OQ6S7cNIcZKzR/X0Xdz/pZ/9po+U3W6Iqg3PhbA7sw6flPSAvS2uEi zkMPb0q3hTtFS88HtcZ6N89NPKx/eldlOkHsP357VZh8Cp63KFKDIgMFqSx6ETVRRWdx zgIAExeGvHBRFDb4JtegjR32rRIl56RiAPVB0DeDgsfu+dm1nWJP1h4RWSn22CaFUinS 5S1cDG+K7N2YnZDMIB6XXFm8RSX68gjc1rQPg34HfKoq4yBIHM8yq7E/YlUZ7E7wS0JI BtD0LQdHsAEQch1cWPcm8pXUFM3MFWNR/Gf443mkIWEyxrjqmb/D0p2TWPUVhbPblvVE O2cw== X-Forwarded-Encrypted: i=1; AJvYcCXxjTP0wrt1mcyfNaKKz0l9PtowQzK/JXaT1IEAi9i6eY1AIdJpyESf+Jeijy4LLMcteb9muAhvUqiY2/lK@vger.kernel.org X-Gm-Message-State: AOJu0Yy74xmyJpANsCm74PYLQmDwJqdC8kM9buu/4bcLZuloXTMlrya0 Pqi8AJ58X1NMydmNBp5vO9MsePQpfbt2F3WLnd38d37+7UinCqbWqjk1yq55DPLb4rI= X-Gm-Gg: ASbGncvgpaDNorPGs1/NXXQ0SKKW8hVFU4kJdSYdEWmRo5UAshb+xa63qq1ehr1S6vk 2kCxghjOEjET3jRxQXjTjKXXoKssn3sfkGgUxqDs/Z3jDnK/PVIX8HWMu8rTlh0Y12PBTmyot4U CnWN3x+lKfV0dpDWHCaFTmvzU94Bk76ZY8dhHvu+43gYBKHFQYFeTYdPbsdciCQBijtG4Flysy9 g9ZNuundMDtqeEv8kXzAliT2xXKhVSTVa3YGBwhOqQk5J52H9GiRRlyA0FoNaWbOJTGyHp5lQKE RBXdX4QW2qQE5TrI7+LOEwAVzQ75dWUU+1rHAj0I8py4pYESeSXmeIYI/IRZwU3A5jYHb/WnGM5 8QNf5vbjo6MBrrwZTppE5x2jh/lgg1vNeAqKqhe2fjYzx/o8ZIFx+LHgMGvWhDO9TRU0qFg6TY/ HN9AyVVonn4/ukQ34MYdPZTp9OpKdTAvc55jitAONHA/aVwijUMMwGQg8oVCm45Rg2DNw= X-Google-Smtp-Source: AGHT+IFR7u/O9EmSODkquXJx/FI96imQcVbMrv3aJUPY5PKPDn5wtRiqmlsoFABQRoPqwp6mKNToUg== X-Received: by 2002:a05:600d:8110:b0:46d:a04:50c6 with SMTP id 5b1f17b1804b1-46fa9b01fb1mr225060395e9.30.1760605953166; Thu, 16 Oct 2025 02:12:33 -0700 (PDT) Received: from [192.168.0.19] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-471144238easm14845395e9.4.2025.10.16.02.12.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Oct 2025 02:12:32 -0700 (PDT) Message-ID: Date: Thu, 16 Oct 2025 10:12:31 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] media: qcom: camss: csid: Add support for CSID 1080 To: Hangxiang Ma , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251014-add-support-for-camss-on-kaanapali-v2-0-f5745ba2dff9@oss.qualcomm.com> <20251014-add-support-for-camss-on-kaanapali-v2-5-f5745ba2dff9@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20251014-add-support-for-camss-on-kaanapali-v2-5-f5745ba2dff9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/10/2025 03:56, Hangxiang Ma wrote: > + for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS_1080; i++) > + if (csid->phy.en_vc & BIT(i)) { > + val = readl(csid->base + CSID_CSI2_RDIN_IRQ_STATUS(i)); > + writel(val, csid->base + CSID_CSI2_RDIN_IRQ_CLEAR(i)); > + > + if (buf_done_val & BIT(BUF_DONE_IRQ_STATUS_RDI_OFFSET + i)) { > + /* > + * buf done and RUP IRQ have been moved to CSID from VFE. > + * Once CSID received buf done, need notify VFE of this > + * event and trigger VFE to handle buf done process. > + */ > + camss_buf_done(csid->camss, csid->id, i); > + } > + } > + A multi-liner like this should be for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS_1080; i++) { /* etc */ } in fact csid_reset_1080() does the right thing, please replicate.