From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DC7927281E; Mon, 16 Mar 2026 11:09:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773659378; cv=none; b=CHiksyggf36IvI7eqU1D7O29tjBIdmZXeE9CbqPCyTYzI3Cyad3PujGsG6hdfoC8DUN1lI5Ct+EMBBQrcYoceewKBxDD/Z17Q1bkV3Pcqm+Ov//UzkJ44guxPoAA5BoTo94Y+dfSWAHmbUz2pDjXFsfT1fYww0JcKe8LNLYWXus= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773659378; c=relaxed/simple; bh=sWpXEpdI+zyIaBICVaJEALbE8aetFWbL6MtATEYqjxo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nV+nG31D+lzNmtu+4LWN7DHYkEPvx2whN46Mnz9JKLieKl87C5IiAd5cwlBU/ZMRa2cwGNsvHAy+J5z0Nw0+jHUhDYhYkRixit/QeK+rHXXJ5LiGrNX/VbadZYx4XY0t4pzBPq/O+68I8wX5LGG+2fFQZ+PGKJ/nORevuvNajto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MpQIPL3E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MpQIPL3E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C245C19421; Mon, 16 Mar 2026 11:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773659378; bh=sWpXEpdI+zyIaBICVaJEALbE8aetFWbL6MtATEYqjxo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MpQIPL3EzG0lIQxdw3BusLH//UBnMOqfD2y+YUWCbG9nhLNr4XbVGoJfjTzPbsogq KujKmzD72Qe0wYMHOl0gmEMdcLiUZXBMaHzGrOISm/X2qs66C59y7ZzHWCrGOqA2Gf f4IjVQX7wCjeWSINniZCRU6kaEhw9rIjYZZNePVwWryylOBqg+pBaItkjsLNDmD8Zd wfFQXaoIyrpNE1Yq8tAIQIkzblGYhBzQEY5l61vMLeaJJLVZoLFsR6B/xxOvQmnlF3 4RfWBkaHC3clHdQ17tVEl+i47VAf4D4zi4jNTGGf9GF3KS3MZjYTtpvVPDaVPYXDNc orsVPNUK1qzkw== Message-ID: Date: Mon, 16 Mar 2026 12:09:30 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/11] dt-bindings: crypto: qcom,ice: Allow power-domain and iface clk To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> <20260310-qcom_ice_power_and_clk_vote-v2-1-b9c2a5471d9e@oss.qualcomm.com> <2ac2efad-3533-490e-bb42-f21c4e950277@kernel.org> <972bd9c8-4671-4151-a3a9-d7eccdf83913@kernel.org> <87fe32f1-b2f2-4b9c-9e54-03be35c921f2@kernel.org> <48daa237-aff9-45ef-919e-665e5ed27f66@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <48daa237-aff9-45ef-919e-665e5ed27f66@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/03/2026 11:56, Harshal Dev wrote: > Hello Krzysztof, > > On 3/13/2026 9:28 PM, Krzysztof Kozlowski wrote: >> On 13/03/2026 12:45, Harshal Dev wrote: >>>> Except new devices, like Eliza and Milos. And then this should go to >>>> current fixes. >>> >>> I'm not sure if I understand correctly, do you mean to say that except for Eliza >>> and Milos, new devices need to change their DT binding to 'required' with >>> corresponding DTS changes. And then, the patch updating the DT binding also needs >>> to be back-ported? >> >> No. All new devices must require this. You only preserve released ABI, >> so fix unreleased ABI (Eliza and Milos) now, before it gets released. >> > > I'm already being annoying, but I will disturb you one more time for clarification. :) > > By saying 'fix unreleased ABI now' do you mean to say that I should add another > trailing commit at the end of this patch series which marks these resources as > 'required' in the DT-binding without carrying the 'Fixes' tag? Specifically so that > Eliza and Milos carry this constrain. Please post a v3 of this patch for crypto subsystem, doing what you did here plus requiring these clocks for Eliza and Milos, with explanation why this is a fix thus why this should go to current cycle. > > From what I understood from Bjorn's comment, the DTS and ICE driver sources will reach > from different trees and either could be merged first. To maintain bisectability we They are applied to different trees. Period. This defines everything, you cannot fix it post factum, you cannot fix bisectability afterwards. > should first merge this patch series followed by a subsequent patch which marks these > resources as 'required' in the DT-binding along with accompanying ICE driver source Then you have a released ABI and you cannot change it, so what does this achieve? Just look what is merged where and you will see the differences. I don't see Milos crypto engine in current cycle, do you? And bisectability has nothing to do here. You need to fix ABI before it gets released. > changes which fail probe when 'iface' clk isn't available. Of course, the subsequent > patch will not be back-ported as a fix. Best regards, Krzysztof