From: Krzysztof Kozlowski <krzk@kernel.org>
To: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
neil.armstrong@linaro.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v4 2/2] arm64: dts: qcom: sm8450: Flatten usb controller node
Date: Wed, 13 Aug 2025 09:27:43 +0200 [thread overview]
Message-ID: <f9219b68-35a6-456d-911e-c4e8590d69ea@kernel.org> (raw)
In-Reply-To: <20250715052739.3831549-3-krishna.kurapati@oss.qualcomm.com>
On 15/07/2025 07:27, Krishna Kurapati wrote:
> Flatten usb controller node and update to using latest bindings
> and flattened driver approach.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 5 --
> .../dts/qcom/sm8450-sony-xperia-nagara.dtsi | 5 +-
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 57 +++++++++----------
> 3 files changed, 27 insertions(+), 40 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> index 2ff40a120aad..0c6aa7ddf432 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> @@ -1199,11 +1199,6 @@ &usb_1 {
> status = "okay";
> };
>
> -&usb_1_dwc3 {
> - dr_mode = "otg";
> - usb-role-switch;
> -};
> -
> &usb_1_dwc3_hs {
> remote-endpoint = <&pmic_glink_hs_in>;
> };
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
> index cc1335a07a35..6bd315e10992 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
> @@ -781,11 +781,8 @@ &uart7 {
> };
>
> &usb_1 {
> - status = "okay";
> -};
> -
> -&usb_1_dwc3 {
> dr_mode = "peripheral";
> + status = "okay";
> };
>
> &usb_1_hsphy {
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 54c6d0fdb2af..89dbac3bdd2b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -5417,12 +5417,9 @@ opp-202000000 {
> };
>
> usb_1: usb@a6f8800 {
> - compatible = "qcom,sm8450-dwc3", "qcom,dwc3";
> - reg = <0 0x0a6f8800 0 0x400>;
> + compatible = "qcom,sm8450-dwc3", "qcom,snps-dwc3";
> + reg = <0 0x0a600000 0 0xfc100>;
So this was never checked. Can you start using tools before you send
code upstream?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-13 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 5:27 [PATCH v4 0/2] Flattening USB controller on SM8450 Krishna Kurapati
2025-07-15 5:27 ` [PATCH v4 1/2] arm64: dts: qcom: sm8450-qrd: add pmic glink node Krishna Kurapati
2025-07-15 8:56 ` Konrad Dybcio
2025-07-15 5:27 ` [PATCH v4 2/2] arm64: dts: qcom: sm8450: Flatten usb controller node Krishna Kurapati
2025-08-13 7:27 ` Krzysztof Kozlowski [this message]
2025-08-13 8:34 ` Krishna Kurapati
2025-08-11 23:26 ` [PATCH v4 0/2] Flattening USB controller on SM8450 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9219b68-35a6-456d-911e-c4e8590d69ea@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).