From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F56FC7EE26 for ; Fri, 12 May 2023 03:01:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239814AbjELDB2 (ORCPT ); Thu, 11 May 2023 23:01:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239803AbjELDB0 (ORCPT ); Thu, 11 May 2023 23:01:26 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B197171E for ; Thu, 11 May 2023 20:01:23 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3f41dceb93bso45512745e9.1 for ; Thu, 11 May 2023 20:01:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683860481; x=1686452481; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wNH+qT+d278L8EuW7+gJj57wNou4ngN3N+y41xL0bJg=; b=bsfwLbTBcF81MZeJ5Eya6UvNOwMn6NFXp1BWVwwh6WeMzLswrcetweYtitBfRV1LJp kqX1FbImeeNtFUS04GbjkFfj/YrFVwqRF22Cyq/SdOkfCAGbnve4GGykWMnzo47LnOdm QvCC2CjXm+ApHY7cqpoa+x4BDadq1gxPbpKZ9g9/6EEUnO4eZ+EbAr68dvWhfyEIWhnF pkCRdkTN03AuRWSyXUi540JrbEbX+n5fQ4tYV+ZClNXxeloLqkJ5vRHPjCWzExCU3Lda uhi0Ezs/upGKHHkPNC1JGdxg58qYjfkQGIweMuDMJF2hL387Ypfxq8HN5yvW1aAq9hnv QI0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683860481; x=1686452481; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wNH+qT+d278L8EuW7+gJj57wNou4ngN3N+y41xL0bJg=; b=ccKOkQ2fhlbX6hi90FUlNwAFJZld1UKqwhUx7J3amfJt8pxHSRlD8pTrTZZf4vPOqu /Sr70R/7UBNVigdIEueemhTxuBCINYsvREckPGGFY5CYPxWlgdSmbyS7EOKBqXAHs/mV TYb6ZUZtG6dchjv4Dx0DHJDYjUQQfa7VESyOSAgqp7Fms+oXAwk1+zER+aUnInVDpOZH MVJb2QzLi0W3ngII5Y7J9nBDy47XCxhWze86uL2Xe9uHF/kzKt54QAVlW5BzB/w60QFi o15HAlsf8G6igk3LqJdByX/3Be6slubPY4fXhkeFWQec74xMOpmqFAwdXPOgMSjZwbuS qHww== X-Gm-Message-State: AC+VfDzgmwfc8fA1zZrwliwMkqf1PTQ9LTg+RtirCtWV4vmxYR/rMI6F Fm8CI6vJeiQdur3DxkIWOaXfSg== X-Google-Smtp-Source: ACHHUZ44za2uY/t0ZeDVI7Cub+JKSvmiDla/DY0bj3D5erE9BCthF8KD3B45b2eRZNuru7kPL/TL5Q== X-Received: by 2002:a5d:6149:0:b0:306:2fd1:a929 with SMTP id y9-20020a5d6149000000b003062fd1a929mr15785049wrt.7.1683860481429; Thu, 11 May 2023 20:01:21 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id w12-20020a05600c474c00b003f07ef4e3e0sm14458610wmo.0.2023.05.11.20.01.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 May 2023 20:01:20 -0700 (PDT) Message-ID: Date: Fri, 12 May 2023 04:01:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 00/18] Venus QoL / maintainability fixes Content-Language: en-US To: Konrad Dybcio , Stanimir Varbanov , Vikash Garodia , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Dikshita Agarwal , Mansur Alisha Shaik , Jonathan Marek , Hans Verkuil , Dikshita Agarwal Cc: Mauro Carvalho Chehab , Stanimir Varbanov , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten , stable@vger.kernel.org References: <20230228-topic-venus-v2-0-d95d14949c79@linaro.org> From: Bryan O'Donoghue In-Reply-To: <20230228-topic-venus-v2-0-d95d14949c79@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 04/05/2023 09:00, Konrad Dybcio wrote: > Tested on 8250, but pretty please test it on your boards too! What's the definition of test here ? I ran this ffplay -codec:video h264_v4l2m2m FantasticFour-ROTSS.mp4 and this ffplay -codec:video vp8_v4l2m2m /mnt/big-buck-bunny_trailer.webm on db410c with no errors. Then again I applied and disapplied the 8x8 264 fix to that branch and saw no discernable difference so I'm not very confident we have good coverage. @Stan @Vikash could you give some suggested tests for coverage here ? @Konrad - get a db410c ! My superficial first-pass on this series looks good but, before giving a Tested-by here, I think we should define a set of coverage tests, run them - the upper end on sm8250 and lower end msm8916 "makes sense to me" 20? different gstreamer tests at different formats and different sizes on our selected platforms db410c, rb5, rb3 I have - also an 820 I haven't booted and an enforce sdm660. Which tests will we use to validate this series and subsequent series to ensure we don't have more regressions ? --- bod