From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE41CC433DF for ; Fri, 12 Jun 2020 04:16:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83B6420792 for ; Fri, 12 Jun 2020 04:16:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="iuET9S4W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725862AbgFLEQW (ORCPT ); Fri, 12 Jun 2020 00:16:22 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:33336 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725763AbgFLEQV (ORCPT ); Fri, 12 Jun 2020 00:16:21 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1591935381; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=9jW2UZWQi53Kk3w5fHkJfOEaqlYtV6xo4Hhqo7akco4=; b=iuET9S4W+6Ij1+PXUyqpG3r3D1eacG1PrKa4seHCT59hsBRsbJFGJY0ztYlUmTwf46+tY4wm CLCRKJD0WlE7bbkHhmluTHCB4TwiYYTV3UfZkeTjwHId3penb6qwXXCAgQKPU3PLulduvUVb Grx7cEK6OLPBcS+ErFzvWlAy2gY= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 5ee301716bebe35debcee715 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 12 Jun 2020 04:15:45 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 62730C433CB; Fri, 12 Jun 2020 04:15:45 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id CC032C433C8; Fri, 12 Jun 2020 04:15:44 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 11 Jun 2020 21:15:44 -0700 From: abhinavk@codeaurora.org To: Rob Clark Cc: linux-arm-msm , dri-devel , pdhaval@codeaurora.org, Sean Paul , aravindh@codeaurora.org Subject: Re: [PATCH] drm/msm: call drm_mode_config_reset before drm_dev_register In-Reply-To: References: <20200610004659.10401-1-abhinavk@codeaurora.org> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Rob Thanks for the review. Yes, this was a cleanup we noticed. Abhinav On 2020-06-11 20:35, Rob Clark wrote: > On Tue, Jun 9, 2020 at 5:47 PM Abhinav Kumar > wrote: >> >> As per the documentation of drm_dev_register, all drivers should >> call drm_dev_register after all the initialization is completed. >> This also means that drm_mode_config_reset should be done before >> drm_dev_register. >> >> Change the sequence to align with this documentation. >> >> Signed-off-by: Abhinav Kumar > > I assume this is just a cleanup you noticed, and not fixing a bug you > are hitting (in which case I'll pick it up next merge window, rather > than -fixes) > > Reviewed-by: Rob Clark > >> --- >> drivers/gpu/drm/msm/msm_drv.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/msm_drv.c >> b/drivers/gpu/drm/msm/msm_drv.c >> index 29295dee2a2e..9e77cc7f1fa4 100644 >> --- a/drivers/gpu/drm/msm/msm_drv.c >> +++ b/drivers/gpu/drm/msm/msm_drv.c >> @@ -538,12 +538,12 @@ static int msm_drm_init(struct device *dev, >> struct drm_driver *drv) >> } >> } >> >> + drm_mode_config_reset(ddev); >> + >> ret = drm_dev_register(ddev, 0); >> if (ret) >> goto err_msm_uninit; >> >> - drm_mode_config_reset(ddev); >> - >> #ifdef CONFIG_DRM_FBDEV_EMULATION >> if (kms && fbdev) >> priv->fbdev = msm_fbdev_init(ddev); >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >> Forum, >> a Linux Foundation Collaborative Project >> > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel