From mboxrd@z Thu Jan 1 00:00:00 1970 From: merez@codeaurora.org Subject: Re: [PATCH v4 1/1] block: Add test-iosched scheduler Date: Tue, 12 Jun 2012 12:58:44 -0700 (PDT) Message-ID: References: <1339491984-8462-1-git-send-email-merez@codeaurora.org> <1339491984-8462-2-git-send-email-merez@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Jeff Moyer Cc: Maya Erez , linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, DOCUMENTATION , open list List-Id: linux-arm-msm@vger.kernel.org On Tue, June 12, 2012 7:09 am, Jeff Moyer wrote: > Maya Erez writes: > >> The test scheduler allows testing a block device by dispatching >> specific requests according to the test case and declare PASS/FAIL >> according to the requests completion error code > > What sort of tests have you written that make use of this > infrastructure? > >> @@ -1072,8 +1072,6 @@ struct request *blk_get_request(struct >> request_queue *q, int rw, gfp_t gfp_mask) >> { >> struct request *rq; >> >> - BUG_ON(rw != READ && rw != WRITE); >> - > > Please explain this. get_request and get_request_wait, called by blk_get_request, expects to get the REQ_SYNC flag in addition to the read/write flag. Moreover, it uses the REQ_SYNC flag in its algorithm decision making. However blk_get_request expects to get a Boolean to indicate only read/write flag and cannot handle the REQ_SYNC flag. > > Cheers, > Jeff > -- Sent by consultant of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum