Re: [PATCH v14 9/9] usb: Adding SuperSpeed support to dummy_hcd

["Brokhman Tatyana" <tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>]

Hi Alan,

> If is_super_speed is false, shouldn't you avoid registering the
> SuperSpeed hub?  Or would that add too many complications?

It woun't add too many complications but I would prefere not to do that.
My goal was to simulate as much as posible "real" USB connection so the
is_super_speed flag simulates the USB port you connect to, HS/SS. When
working with a real host if you connect a HS device to a SS port it
connects to a HS root hub but the SS root hub is functional and
registered. So I don't see any reason not to register it for dummy_hcd as
well.

>> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
>> index 5927541..d5f0af7 100644
>> --- a/drivers/usb/gadget/Kconfig
>> +++ b/drivers/usb/gadget/Kconfig
>> @@ -626,6 +626,7 @@ config USB_DUMMY_HCD
>>  	depends on USB_GADGET_DUMMY_HCD
>>  	default USB_GADGET
>>  	select USB_GADGET_SELECTED
>> +	select USB_GADGET_SUPERSPEED
>
> This belongs under USB_GADGET_DUMMY_HCD, next to the "select
> USB_GADGET_DUALSPEED" line.

ok, thanks. Will update.

Thanks,
Tanya Brokhman
-- 
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html