From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GNl5uClE" Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44865C8 for ; Sat, 2 Dec 2023 16:08:30 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-50be08b8fd9so1759242e87.3 for ; Sat, 02 Dec 2023 16:08:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701562108; x=1702166908; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zdl2HKrC6VDqcQMieLin647Q0Xn6ap4MwvU9WaW0Y5Q=; b=GNl5uClE/anAmjp7JeAmYnV6SXAADbIPjPF7zlrprW5H+9xjbfKA/2KEElqwDjgqfv pdVHjgQ7twesp966VXRJJIqC5z2PBLxb/4ipPw8xIJAEavcgy1X/8pMLCUdWRUQw/rR2 puCOZHM48lWXGjNY79VDkswAkUjiOl9MX5W3X4MZ3ZaCZlU5PS/vcQnSk/ZgC1LXP6Ew r7i4drC4aRCHjiQgH/RcB9KWN9g/6q3V3plrGEc9Ug9Ca6SkaI4FO5H74e0Fa0KQmcFg kwV129Aqj5NWSrNFBzKJUkAkb9AcLFapkjqXtbrneFupuoan0Wf68trRv2cgxxU/CquT 2MLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701562108; x=1702166908; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zdl2HKrC6VDqcQMieLin647Q0Xn6ap4MwvU9WaW0Y5Q=; b=BBGg/JULXNhbgrnvfLEXHgpgxlrv1JXUlTdXTpZ/23OmFB2+K7B3zmyv+NVLSHvJbQ 8FQvAGwEFF+1oNZDfHge4iaAZ+4MBfKfgr505R8FEflhfNkSE9qOj7Cl0J33+7AAZQiT BJla9kU1Is8jfKKdbXyoDh2lGvDsiNqHi5ibwffgZltwjQh+8bnypaj5fef7DxHAvFY7 0ITPEwUDdxqOYZRjI96IMVU+3AA+auipAQ4EuxVbTIxXJUFfwPhdgFMYWu+HX0Khfpbz Rd3YdxEyfojZVKF+aTgjJiSontOufCd3ZnQyesQIovmJJ2NwoMb2bYLaRiaWLJ+vJqkb VvIg== X-Gm-Message-State: AOJu0YxWnVkaub87xtsm3c+7gAsH1hIOy6KYD4uBK9+UTRGqWaWimgt4 zrXIob7GJYYxOyk2Jjz+BN2cvQ== X-Google-Smtp-Source: AGHT+IGKKKovG+G/EKvfWVyIsAtKAdovDgxSn7t9v9ctBMOdpY6B633LhdgxF9RCRhAKLajhX41/FA== X-Received: by 2002:a05:6512:b20:b0:50b:d764:969c with SMTP id w32-20020a0565120b2000b0050bd764969cmr2043149lfu.128.1701562108507; Sat, 02 Dec 2023 16:08:28 -0800 (PST) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id e14-20020ac2546e000000b0050bbcd68e8bsm830211lfn.47.2023.12.02.16.08.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Dec 2023 16:08:27 -0800 (PST) Message-ID: Date: Sun, 3 Dec 2023 02:08:26 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] drm/msm/rd: Check PT_PTRACED for cmdstream dumping Content-Language: en-GB To: Rob Clark , dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list References: <20230914172453.9707-1-robdclark@gmail.com> From: Dmitry Baryshkov In-Reply-To: <20230914172453.9707-1-robdclark@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14/09/2023 20:24, Rob Clark wrote: > From: Rob Clark > > So, when you want to get a cmdstream trace of some deqp or piglit test, > but you happen to be running it on the same laptop with full desktop > env, the current dump-everything firehose of `cat $debugfs/dri/n/rd` is > quite a bit too much. Ptrace seemed kind of a natural way to control > it, ie. either run what you want to trace under gdb or hack in a > ptrace(PTRACE_TRACEME) call. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gem_submit.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov I think this is a good idea, to be able to separate process being debugged and all other tasks. > > diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c > index a908373cf34b..a105ca1f2102 100644 > --- a/drivers/gpu/drm/msm/msm_gem_submit.c > +++ b/drivers/gpu/drm/msm/msm_gem_submit.c > @@ -979,7 +979,8 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, > /* The scheduler owns a ref now: */ > msm_gem_submit_get(submit); > > - msm_rd_dump_submit(priv->rd, submit, NULL); > + if (current->ptrace & PT_PTRACED) > + msm_rd_dump_submit(priv->rd, submit, NULL); > > pm_runtime_get_sync(&gpu->pdev->dev); > -- With best wishes Dmitry