Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andrew Halaney <ahalaney@redhat.com>
Cc: linux-kernel@vger.kernel.org, agross@kernel.org,
	andersson@kernel.org, konrad.dybcio@linaro.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/4] arm64: dts: qcom: sa8155p-adp: Make -cells decimal
Date: Tue, 25 Apr 2023 10:22:06 +0200	[thread overview]
Message-ID: <fa548aa4-6d17-0981-227a-bed6aedcb34f@linaro.org> (raw)
In-Reply-To: <20230424143857.373kjvi42c7acsbp@halaney-x13s>

On 24/04/2023 16:38, Andrew Halaney wrote:
> On Mon, Apr 24, 2023 at 09:21:45AM +0200, Krzysztof Kozlowski wrote:
>> On 21/04/2023 22:55, Andrew Halaney wrote:
>>> The property logically makes sense in decimal, and is the standard used
>>> elsewhere.
>>>
>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
>>> ---
>>>
>>> Changes since v2:
>>>     * Collect tags
>>> Changes since v1:
>>>     * New patch (Konrad)
>>
>> Doing such changes per one board will be a lot of churn...
>>
> 
> Agreed, are you suggesting I drop this patch (and if we do this sort of
> cleanup to do it in bulk)? Sorry, not entirely sure I am picking up what
> that comment is implying.

Yes, I suggest to fix all Qualcomm arm64 boards with one patch. There
are just few more occurrences of this. It's also pure cleanup, no
functional change.

> 
> Personally, I'd prefer to keeping that patch as this series is trying to
> clean up the particular ethernet node.. but if the purpose of the series
> was just to clean -cells up then I'd go with the bulk approach.
> 
> So as is, I'm going to leave it like so unless you have specific advice
> against doing so.

Best regards,
Krzysztof


  reply	other threads:[~2023-04-25  8:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21 20:55 [PATCH v3 1/4] arm64: dts: qcom: sa8155p-adp: Make compatible the first property Andrew Halaney
2023-04-21 20:55 ` [PATCH v3 2/4] arm64: dts: qcom: sa8155p-adp: Make -cells decimal Andrew Halaney
2023-04-24  7:21   ` Krzysztof Kozlowski
2023-04-24 14:38     ` Andrew Halaney
2023-04-25  8:22       ` Krzysztof Kozlowski [this message]
2023-04-21 20:55 ` [PATCH v3 3/4] arm64: dts: qcom: sa8155p-adp: Remove unneeded rgmii_phy information Andrew Halaney
2023-04-21 20:55 ` [PATCH v3 4/4] arm64: dts: qcom: sa8155p-adp: Move mtl nodes into ethernet node Andrew Halaney
2023-05-25  4:53 ` (subset) [PATCH v3 1/4] arm64: dts: qcom: sa8155p-adp: Make compatible the first property Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa548aa4-6d17-0981-227a-bed6aedcb34f@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=ahalaney@redhat.com \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox