Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Andy Gross <agross@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<quic_pkondeti@quicinc.com>, <quic_ppratap@quicinc.com>,
	<quic_wcheng@quicinc.com>, <quic_jackp@quicinc.com>,
	<quic_harshq@quicinc.com>, <ahalaney@redhat.com>,
	<quic_shazhuss@quicinc.com>,
	Bjorn Andersson <quic_bjorande@quicinc.com>
Subject: Re: [PATCH v6 1/8] dt-bindings: usb: Add bindings for multiport properties on DWC3 controller
Date: Thu, 6 Apr 2023 19:37:56 +0530	[thread overview]
Message-ID: <fa8838de-7d7e-71dd-9f9f-2604bd0faf1a@quicinc.com> (raw)
In-Reply-To: <20230405201709.GA397286-robh@kernel.org>



On 4/6/2023 1:47 AM, Rob Herring wrote:
> On Wed, Apr 05, 2023 at 07:45:07PM +0530, Krishna Kurapati PSSNV wrote:
>>
>>
>> On 4/5/2023 7:31 PM, Krzysztof Kozlowski wrote:
>>> On 05/04/2023 14:57, Krishna Kurapati wrote:
>>>> Add bindings to indicate properties required to support multiport
>>>> on Snps Dwc3 controller.
>>>>
>>>> Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com>
>>>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>>>> ---
>>>> Link to v5: https://lore.kernel.org/all/20230310163420.7582-2-quic_kriskura@quicinc.com/
>>>
>>> You did not test it at v4 and you got report for this. Your changelog in
>>> commit msg does not mention fixing it.
>>>
>>> It looks like you did not test it for the second time (or sixth time).
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> Hi Krzysztof,
>>
>>    I did do a dt_binding_check and I got the following result:
>>
>> kriskura@hu-kriskura-hyd:/local/mnt/workspace/krishna/skales2/skales/kernel$
>> make DT_CHECKER_FLAGS=-m dt_binding_check
>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>>    HOSTCC  scripts/basic/fixdep
>>    HOSTCC  scripts/dtc/dtc.o
>>    HOSTCC  scripts/dtc/flattree.o
>>    HOSTCC  scripts/dtc/fstree.o
>>    HOSTCC  scripts/dtc/data.o
>>    HOSTCC  scripts/dtc/livetree.o
>>    HOSTCC  scripts/dtc/treesource.o
>>    HOSTCC  scripts/dtc/srcpos.o
>>    HOSTCC  scripts/dtc/checks.o
>>    HOSTCC  scripts/dtc/util.o
>>    LEX     scripts/dtc/dtc-lexer.lex.c
>>    YACC    scripts/dtc/dtc-parser.tab.[ch]
>>    HOSTCC  scripts/dtc/dtc-lexer.lex.o
>>    HOSTCC  scripts/dtc/dtc-parser.tab.o
>>    HOSTLD  scripts/dtc/dtc
>>    LINT    Documentation/devicetree/bindings
>> invalid config: unknown option "max-spaces-inside-empty" for rule "brackets"
>> xargs: /usr/bin/yamllint: exited with status 255; aborting
> 
> This indicates your yamllint version is too old.
> 
> Rob

Let me give a try with latest version.
Thanks for pointing it out. 🙂

Regards,
Krishna,

  reply	other threads:[~2023-04-06 14:10 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05 12:57 [PATCH v6 0/8] Add multiport support for DWC3 controllers Krishna Kurapati
2023-04-05 12:57 ` [PATCH v6 1/8] dt-bindings: usb: Add bindings for multiport properties on DWC3 controller Krishna Kurapati
2023-04-05 14:01   ` Krzysztof Kozlowski
2023-04-05 14:15     ` Krishna Kurapati PSSNV
2023-04-05 14:18       ` Krzysztof Kozlowski
2023-04-05 20:17       ` Rob Herring
2023-04-06 14:07         ` Krishna Kurapati PSSNV [this message]
2023-04-05 16:48   ` Rob Herring
2023-04-05 12:57 ` [PATCH v6 2/8] usb: dwc3: core: Access XHCI address space temporarily to read port info Krishna Kurapati
2023-04-05 23:14   ` kernel test robot
2023-04-08  1:38   ` Thinh Nguyen
2023-04-05 12:57 ` [PATCH v6 3/8] usb: dwc3: core: Skip setting event buffers for host only controllers Krishna Kurapati
2023-04-05 12:57 ` [PATCH v6 4/8] usb: dwc3: core: Refactor PHY logic to support Multiport Controller Krishna Kurapati
2023-04-05 12:57 ` [PATCH v6 5/8] usb: dwc3: qcom: Add multiport controller support for qcom wrapper Krishna Kurapati
2023-04-05 12:57 ` [PATCH v6 6/8] arm64: dts: qcom: sc8280xp: Add multiport controller node for SC8280 Krishna Kurapati
2023-04-14 15:45   ` Andrew Halaney
2023-04-15 19:04     ` Krishna Kurapati PSSNV
2023-04-22 16:08       ` Krishna Kurapati PSSNV
2023-04-25 20:33         ` Andrew Halaney
2023-05-05  7:55           ` Johan Hovold
2023-04-05 12:57 ` [PATCH v6 7/8] arm64: dts: qcom: sa8295p: Enable tertiary controller and its 4 USB ports Krishna Kurapati
2023-04-05 12:57 ` [PATCH v6 8/8] arm64: dts: qcom: sa8540-ride: Enable first port of tertiary usb controller Krishna Kurapati
2023-04-14 15:51   ` Andrew Halaney
2023-04-15 19:09     ` Krishna Kurapati PSSNV
2023-04-08  1:42 ` [PATCH v6 0/8] Add multiport support for DWC3 controllers Thinh Nguyen
2023-04-08 11:36   ` Krzysztof Kozlowski
2023-04-08 23:09     ` Thinh Nguyen
2023-04-10 15:24       ` Krzysztof Kozlowski
2023-04-13 18:54 ` Adrien Thierry
2023-04-14  4:41   ` Krishna Kurapati PSSNV

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa8838de-7d7e-71dd-9f9f-2604bd0faf1a@quicinc.com \
    --to=quic_kriskura@quicinc.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=agross@kernel.org \
    --cc=ahalaney@redhat.com \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=quic_bjorande@quicinc.com \
    --cc=quic_harshq@quicinc.com \
    --cc=quic_jackp@quicinc.com \
    --cc=quic_pkondeti@quicinc.com \
    --cc=quic_ppratap@quicinc.com \
    --cc=quic_shazhuss@quicinc.com \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox