Re: [PATCH v7 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay

[Nihal Kumar Gupta <quic_nihalkum@quicinc.com>]

On 16-12-2025 13:05, Vladimir Zapolskiy wrote:
>> @@ -0,0 +1,67 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> 
> Year is missing.
> 
This is as per new yearless copyright format.

>> + */
>> + 
>> +
>> +            csiphy1_ep: endpoint {
>> +                clock-lanes = <7>;
> 
> Please remove 'clock-lanes' property here.
> 
ACK

>> +                data-lanes = <0 1 2 3>;
>> +                remote-endpoint = <&imx577_ep1>;
>> +            };
>> +        };
>> +    };
>> +            imx577_ep1: endpoint {
>> +                link-frequencies = /bits/ 64 <600000000>;
>> +                data-lanes = <0 1 2 3>;
> 
> data-lanes property value should be '1 2 3 4>', 0 is for the clock lane.
> 
> On CAMSS side this cannot be changed, unfortunately it's a lingering issue.
> 
So, I should set data-lanes = <1 2 3 4> in imx577_ep1, and keep csiphy1_ep as <0 1 2 3>, correct?
Is there a reason CAMSS side can’t change this? We should handle it properly in future targets.

>> +                remote-endpoint = <&csiphy1_ep>;
>> +            };
>> +        };
>> +    };
>> +};
> 
> If only one of 3 defined from 4/5 regulators is used, do you really wish
> to describle all 3 in advance? You may consider to remove 2 currently unused
> GPIO controlled regulator descriptions, and squash this change with 4/5.
As discussed, we agreed to add support for other sensors: https://lore.kernel.org/all/4b73f64a-1e28-4f25-80d2-3d59575b9da2@oss.qualcomm.com

Regulator changes are in monaco-evk.dts, and sensor overlay changes are present in monaco-evk-camera-imx577.dtso
It’s better to keep these as separate patches rather than merging them into one.

-- 
Regards,
Nihal Kumar Gupta