From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17A8A1F4C84 for ; Tue, 3 Jun 2025 07:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748936128; cv=none; b=nuNbOdwCAh3Bj+GF/+JaRb4cR6nYWyHAukRXX0NrgUTXQ6kBDIotElWIwiFjevZs9jwCbLC6Rbb8LuqYCdLIRgVqJ+FEvkNhdsQZHfLdnsRx97n3FlLT+e/+TA7w4pAsBRBJzGzVfdr/M6sJDQ1J83mxqn2MLF5xYUe6BBC3vzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748936128; c=relaxed/simple; bh=E+QAiazNn9v/r2GaWNXCVc9NzRxjWjvN6HgGF1scPOs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k1eAy66Ivb1xntI7AxZUjZDgeTFtnN8Kmx1jQvqhQUAsnF6ykQ1u29C6czAOjoUMgyaA0lqsprn5S2wpJQiAuxkO9Pe0PAa/tsd7geXjhlHd5cpcsCG6SmJ+D9utNmss+8Ta3fDg+nSpwr6XsNYfr5TFIMP2Xog6MgCIeGAAOL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Gr19oFt3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Gr19oFt3" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5537C64Y026860 for ; Tue, 3 Jun 2025 07:35:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FecECnu2NheaNqiJX/ORSRrplhA+quPcAjrXUQL/gTk=; b=Gr19oFt30bnti54h gNQk79Ergs0wgCwz30ZHvmZwf5TdCovgO4pWxpr/0hgrjMmdHE2g7OVAmM4kaZ4Z gUUAk7dK0lXyNiIqo6Q/SGnn3hRiigP1KkZKG6PpkCQztChATSCX8N7G6h3sIf3X L15hftjzEejwcDZ3krYgBfyZqO/U+YTUYlpAEXn4WetcNHBJdN2i/6BqTjdIaD5L vFVtA47qs5lQNPdu8TKznCeofD9EGu4t7llEqUifCRuA384JqXbrqmHiAn6DdsDr RG4Km/z/dkSgvKgyQo4MjyCKJg/1VNJ3tBFfecPaX01IT+/z0Xbr+IFUfZJV4jzb X37mfg== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 471g8rsqkj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 03 Jun 2025 07:35:26 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b115fb801bcso5753872a12.3 for ; Tue, 03 Jun 2025 00:35:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748936125; x=1749540925; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FecECnu2NheaNqiJX/ORSRrplhA+quPcAjrXUQL/gTk=; b=XIdA5WlHkx7D7+JPOaSCwxtKw6nxYcnzceYFpmTs+2HSuxuD+fKXmuImc4RAuvUtAL QvJxkQjStR6rmutk89XYWBWHGhsaDN/xmuooBhfTM4+Mp3dtZEQ5g6Ss9OTbioRjr/7s dm7bqn1ZPSeRfWxRgMxwBXhbCtIAlI3cgLgm+KJIRQXr6sSRSA3iV5S2sP4ZgApmgNSD fAG6iDIcat5uoTr/CTRusvKPYFT5YFQBpm6L70JHj5jLjCjYy36uy5RM7jOyNJmiV2cl pVvWZ1Ukb+nXcBQAIeRaCKIZdLnToSGMR+jcbJThmPtN1QG5N0A4g0t9/rdJKD2Zr+IE xPsA== X-Forwarded-Encrypted: i=1; AJvYcCVVkVj7ecsiEL17YkN8LVRRV6qa5w/JARPJEBtUiYSccjci3OJoAyl3HR5UcheBEqrkDU3qZfXayklr0uxi@vger.kernel.org X-Gm-Message-State: AOJu0YyDGay03LDuPyPuuPd1g+Cttav/kAiVltGcuzvKTrF1KqHZRgl1 pOzG0Rqj+wxf4fhvJfVApML3m1YGoph9zWA/gDEYFJsdLXiIUDCWsVt4wC98yn9zxtHKjjc+9GQ 0nfIchS7RTUt9KYYvbK2dx4ubaVSUTE95STVylpeuLrkC6+S22a9JL/zWIYdkTVm7oXGx X-Gm-Gg: ASbGncuPUBOjnW2lgFnx7xPOAMD2ydmve3MuB4QnoVFO9/BY3JP5IvsJ2Q4rVmURL5D 316wKFGlDgxWeiksxlDuNsT+xadFN/9Xxth4WA84J5UCHqFwHiUxm+7zngtZnPY0u0KhXBDY0iI A56qMbOjzpJ7HaA1gzUl7somy+KhJ+QUn6Wf1FzqJBmjBBeWZ/QNvtsYGwd56u52WNMxXpvqOX+ AND8MSZlHml/+5z+f8FRQosK326FGumqbhg5OAkmyFZDUvbKXHrcLNBmwgHedIqDTFVajNsMQ2N 2VKCK5mSKG4ePsCO9NicdwxnsmkAFaBTaY91IpzzKQ== X-Received: by 2002:a05:6a20:2589:b0:1f5:8b9b:ab54 with SMTP id adf61e73a8af0-21ad95818b7mr27385852637.23.1748936125226; Tue, 03 Jun 2025 00:35:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHbrLjN/LK2D8S83yJequqnD62klgE0P1XAXLcbq1Q+J2LZWaSZQvhy+vzl67jRzKVjcPVj7w== X-Received: by 2002:a05:6a20:2589:b0:1f5:8b9b:ab54 with SMTP id adf61e73a8af0-21ad95818b7mr27385809637.23.1748936124761; Tue, 03 Jun 2025 00:35:24 -0700 (PDT) Received: from [10.92.214.105] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b2ecebb6b5csm6627188a12.72.2025.06.03.00.35.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 00:35:24 -0700 (PDT) Message-ID: Date: Tue, 3 Jun 2025 13:05:17 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 3/3] arm64: qcom: sc7280: Move phy, perst to root port node Content-Language: en-US To: Manivannan Sadhasivam Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com, quic_mrana@quicinc.com References: <20250419-perst-v3-0-1afec3c4ea62@oss.qualcomm.com> <20250419-perst-v3-3-1afec3c4ea62@oss.qualcomm.com> <0e1d8b8e-9dd3-a377-d7e0-93ec77cf397f@oss.qualcomm.com> From: Krishna Chaitanya Chundru In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: FyXpOc7a1CyjOBBy0E0wRGTbjyIB1aAv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjAzMDA2NSBTYWx0ZWRfXy/qDnR/93KQI f3+IPau066G07QMPKmEiPBiVPgq2DMixaYa2DWA5/cRg5asYnTifU61ZU2T5Q6f3wpHTnKRs5SU STWd8m5nrW9CwVGBctEsngTzsekJH5pVxO7oEV1J/1Kj/wsEkbJoTFUQ0Ly2jIQtuEymnu4UoQI A428sxvicQYskAEOsjM1y10mxEALXWvtNJ1caAkgOiBGMKsjWhfWHNHCMoZ/zevhLyBzDB0c04l 9ClCYMfFcopK4CmWuQkq+HLm3ewFdSY9QVAa2X2LaP9bNgRGdqu3WN7jNk4zVdmCz+uTaVjEqPz ALeRWgDF4i+5QiZ1HRah84uCf3A3RhZJ0gJWxPztopbd9CbtrfxTAFf5TzMEvr9m4FXQqHoN8Js D3ThAwvQ4heKNSTD/Hc6t7e4/XkVuHklzIusN/jdhCOB47XB6dVNZi5r1jERDbxOiJLTVt2y X-Authority-Analysis: v=2.4 cv=RdWQC0tv c=1 sm=1 tr=0 ts=683ea5be cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=gzpaoVQaGCppcG2blusA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: FyXpOc7a1CyjOBBy0E0wRGTbjyIB1aAv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-03_01,2025-06-02_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 mlxscore=0 priorityscore=1501 phishscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 suspectscore=0 impostorscore=0 spamscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506030065 On 6/3/2025 12:22 PM, Manivannan Sadhasivam wrote: > On Tue, Jun 03, 2025 at 12:03:01PM +0530, Krishna Chaitanya Chundru wrote: >> >> >> On 6/1/2025 12:35 PM, Manivannan Sadhasivam wrote: >>> On Sat, Apr 19, 2025 at 10:49:26AM +0530, Krishna Chaitanya Chundru wrote: >>>> There are many places we agreed to move the wake and perst gpio's >>>> and phy etc to the pcie root port node instead of bridge node[1]. >>> >>> Same comment as binding patch applies here. >>> >>>> >>>> So move the phy, phy-names, wake-gpio's in the root port. >>> >>> You are not moving any 'wake-gpios' property. >>> >> ack I will remove it. >>>> There is already reset-gpio defined for PERST# in pci-bus-common.yaml, >>>> start using that property instead of perst-gpio. >>>> >>>> [1] https://lore.kernel.org/linux-pci/20241211192014.GA3302752@bhelgaas/ >>>> >>>> Signed-off-by: Krishna Chaitanya Chundru >>>> --- >>>> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 5 ++++- >>>> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 5 ++++- >>>> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 5 ++++- >>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 6 ++---- >>>> 4 files changed, 14 insertions(+), 7 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >>>> index 7a36c90ad4ec8b52f30b22b1621404857d6ef336..3dd58986ad5da0f898537a51715bb5d0fecbe100 100644 >>>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >>>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >>>> @@ -709,8 +709,11 @@ &mdss_edp_phy { >>>> status = "okay"; >>>> }; >>>> +&pcie1_port0 { >>>> + reset-gpios = <&tlmm 2 GPIO_ACTIVE_LOW>; >>>> +}; >>>> + >>>> &pcie1 { >>>> - perst-gpios = <&tlmm 2 GPIO_ACTIVE_LOW>; >>>> pinctrl-0 = <&pcie1_reset_n>, <&pcie1_wake_n>; >>>> pinctrl-names = "default"; >>> >>> What about the pinctrl properties? They should also be moved. >>> >> pinctrl can still reside in the host bridge node, which has >> all the gpio's for all the root ports. If we move them to the >> root ports we need to explicitly apply pinctrl settings as these >> not tied with the driver yet. >> > > If the DT node is associated with a device, then the driver core should bind the > pinctrl pins and configure them. Is that not happening here? The root node will not be associated with the driver until enumeration, the controller drivers needs these to be configured before enumeration. - Krishna Chaitanya. > > - Mani >