[PATCH 0/3] media: qcom: iris: add support for X1E80100

[PATCH 0/3] media: qcom: iris: add support for X1E80100

[Wangao Wang]

Add support for video hardware acceleration on X1E80100 platform.

Signed-off-by: Wangao Wang <quic_wangaow@quicinc.com>
---
Wangao Wang (3):
      arm64: dts: qcom: x1e80100: add video node
      arm64: dts: qcom: x1-crd: enable video
      arm64: dts: qcom: hamoa-iot-evk: enable video

 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts |  4 ++
 arch/arm64/boot/dts/qcom/x1-crd.dtsi       |  4 ++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi     | 82 ++++++++++++++++++++++++++++++
 3 files changed, 90 insertions(+)
---
base-commit: 5d50cf9f7cf20a17ac469c20a2e07c29c1f6aab7
change-id: 20250903-add_iris_for_x1e80100-96ca58d30a88
prerequisite-change-id: 20250604-hamoa_initial-0cd7036d7271:v8
prerequisite-patch-id: 707f3a7f2b7ea216a87cdd2ee93d157447a5f4b8
prerequisite-patch-id: 722456df5f851b37a01de416c13f75a519296480
prerequisite-patch-id: f380520f40a786d736810d8cd6b4ed157506821c
prerequisite-change-id: 20250704-x1e-iris-4a5d033f4a2d:v1
prerequisite-patch-id: 037bb113706198fca6a87000e46907bc23f9d7e2

Best regards,
-- 
Wangao Wang <quic_wangaow@quicinc.com>

[PATCH 1/3] arm64: dts: qcom: x1e80100: add video node

[Wangao Wang]

Add the IRIS video-codec node on X1E80100 platform to support video
functionality.

Signed-off-by: Wangao Wang <quic_wangaow@quicinc.com>
---
 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 82 ++++++++++++++++++++++++++++++++++
 1 file changed, 82 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index 737c5dbd1c808300041cc8897ca1f7450e16e019..aac40875e583fd49db85e1c5d0ca416cc02d0e5d 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -5186,6 +5186,88 @@ usb_1_ss1_dwc3_ss: endpoint {
 			};
 		};
 
+		iris: video-codec@aa00000 {
+			compatible = "qcom,x1e80100-iris", "qcom,sm8550-iris";
+
+			reg = <0x0 0x0aa00000 0x0 0xf0000>;
+			interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+
+			power-domains = <&videocc VIDEO_CC_MVS0C_GDSC>,
+					<&videocc VIDEO_CC_MVS0_GDSC>,
+					<&rpmhpd RPMHPD_MXC>,
+					<&rpmhpd RPMHPD_MMCX>;
+			power-domain-names = "venus",
+					     "vcodec0",
+					     "mxc",
+					     "mmcx";
+			operating-points-v2 = <&iris_opp_table>;
+
+			clocks = <&gcc GCC_VIDEO_AXI0_CLK>,
+				 <&videocc VIDEO_CC_MVS0C_CLK>,
+				 <&videocc VIDEO_CC_MVS0_CLK>;
+			clock-names = "iface",
+				      "core",
+				      "vcodec0_core";
+
+			interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+					 &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>,
+					<&mmss_noc MASTER_VIDEO QCOM_ICC_TAG_ALWAYS
+					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+			interconnect-names = "cpu-cfg",
+					     "video-mem";
+
+			memory-region = <&video_mem>;
+
+			resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>;
+			reset-names = "bus";
+
+			iommus = <&apps_smmu 0x1940 0x0>,
+				     <&apps_smmu 0x1947 0x0>;
+			dma-coherent;
+
+			status = "disabled";
+
+			iris_opp_table: opp-table {
+				compatible = "operating-points-v2";
+
+				opp-192000000 {
+					opp-hz = /bits/ 64 <192000000>;
+					required-opps = <&rpmhpd_opp_low_svs_d1>,
+							<&rpmhpd_opp_low_svs_d1>;
+				};
+
+				opp-240000000 {
+					opp-hz = /bits/ 64 <240000000>;
+					required-opps = <&rpmhpd_opp_low_svs>,
+							<&rpmhpd_opp_low_svs>;
+				};
+
+				opp-338000000 {
+					opp-hz = /bits/ 64 <338000000>;
+					required-opps = <&rpmhpd_opp_svs>,
+							<&rpmhpd_opp_svs>;
+				};
+
+				opp-366000000 {
+					opp-hz = /bits/ 64 <366000000>;
+					required-opps = <&rpmhpd_opp_svs_l1>,
+							<&rpmhpd_opp_svs_l1>;
+				};
+
+				opp-444000000 {
+					opp-hz = /bits/ 64 <444000000>;
+					required-opps = <&rpmhpd_opp_nom>,
+							<&rpmhpd_opp_nom>;
+				};
+
+				opp-481000000 {
+					opp-hz = /bits/ 64 <481000000>;
+					required-opps = <&rpmhpd_opp_turbo>,
+							<&rpmhpd_opp_turbo>;
+				};
+			};
+		};
+
 		videocc: clock-controller@aaf0000 {
 			compatible = "qcom,x1e80100-videocc";
 			reg = <0 0x0aaf0000 0 0x10000>;

-- 
2.34.1

Re: [PATCH 1/3] arm64: dts: qcom: x1e80100: add video node

[Krzysztof Kozlowski]

On 03/09/2025 10:27, Wangao Wang wrote:
> Add the IRIS video-codec node on X1E80100 platform to support video
> functionality.
> 
> Signed-off-by: Wangao Wang <quic_wangaow@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/x1e80100.dtsi | 82 ++++++++++++++++++++++++++++++++++
>  1 file changed, 82 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index 737c5dbd1c808300041cc8897ca1f7450e16e019..aac40875e583fd49db85e1c5d0ca416cc02d0e5d 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -5186,6 +5186,88 @@ usb_1_ss1_dwc3_ss: endpoint {
>  			};
>  		};
>  
> +		iris: video-codec@aa00000 {
> +			compatible = "qcom,x1e80100-iris", "qcom,sm8550-iris";

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.

> 


Best regards,
Krzysztof

Re: [PATCH 1/3] arm64: dts: qcom: x1e80100: add video node

[Konrad Dybcio]

On 9/3/25 10:27 AM, Wangao Wang wrote:
> Add the IRIS video-codec node on X1E80100 platform to support video
> functionality.
> 
> Signed-off-by: Wangao Wang <quic_wangaow@quicinc.com>
> ---

[...]

> +			memory-region = <&video_mem>;
> +
> +			resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>;
> +			reset-names = "bus";
> +
> +			iommus = <&apps_smmu 0x1940 0x0>,
> +				     <&apps_smmu 0x1947 0x0>;

the '<'s should be aligned

Konrad

[PATCH 2/3] arm64: dts: qcom: x1-crd: enable video

[Wangao Wang]

Enable Iris video codec on the x1-crd board.

Signed-off-by: Wangao Wang <quic_wangaow@quicinc.com>
---
 arch/arm64/boot/dts/qcom/x1-crd.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
index 3c9455fede5c09d90e00c98db35d49e8738e6acc..6113272c8e80d97d5f2f51ecc003c4876a188652 100644
--- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
@@ -1114,6 +1114,10 @@ touchscreen@10 {
 	};
 };
 
+&iris {
+	status = "okay";
+};
+
 &lpass_tlmm {
 	spkr_01_sd_n_active: spkr-01-sd-n-active-state {
 		pins = "gpio12";

-- 
2.34.1

[PATCH 3/3] arm64: dts: qcom: hamoa-iot-evk: enable video

[Wangao Wang]

Enable Iris video codec on the hamoa-iot-evk board.

Signed-off-by: Wangao Wang <quic_wangaow@quicinc.com>
---
 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
index b1a8380d6639778b0201b49f217459da496883ea..8eafc6ae60bf77e34e8ca0586d86e69e3a190e9d 100644
--- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
+++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
@@ -767,6 +767,10 @@ retimer_ss1_con_sbu_out: endpoint {
 	};
 };
 
+&iris {
+	status = "okay";
+};
+
 &lpass_tlmm {
 	spkr_01_sd_n_active: spkr-01-sd-n-active-state {
 		pins = "gpio12";

-- 
2.34.1

Re: [PATCH 3/3] arm64: dts: qcom: hamoa-iot-evk: enable video

[Krzysztof Kozlowski]

On 03/09/2025 10:27, Wangao Wang wrote:
> Enable Iris video codec on the hamoa-iot-evk board.
> 
> Signed-off-by: Wangao Wang <quic_wangaow@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 4 ++++
>  1 file changed, 4 insertions(+)

There is no such file!

Really, again you send something completely out of the blue, untestable,
unmergeable, without ANY explanation in cover letter.

We already gave feedback on this two weeks ago!

Best regards,
Krzysztof