From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FCA23BB9FA for ; Sat, 9 May 2026 17:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778346268; cv=none; b=ObVQ8tgA0cUh4oWNpg78goPrRyv1zYj77/7nj0PvXUSulEOS3RUw3Y63yGIN8Vs6oUsA8aO12iA53egUVKRZNiYtG2MQkeQM/C1/UKvLuu38xlvukDRwWpnadNfPe2p9dZQa3Ru9jsc7nnLvC/vrrzt52r2u+b7j1/wf15IfJZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778346268; c=relaxed/simple; bh=RBhf7gOBQeFMdmGddxtbuEgjDEyoEauq2gnBu8JuHrA=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=NQ724UGiUvtv0B5hMPfZxe8U/21gMKR45elYV5x6ok5GW2GRjVyAHGxIOvBTdzFwpyw0NPGUFYoyHmXCQThHurbRKWpYn6gWe7ZjB+9URkmjpA/LsiEE8LA5t6ZGcuyRlnUZAbnFoFoF7n0eLnQ5P4F5v3PFjM54Hn3sBlaBanE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=E4iVjjn9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hztpt6op; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="E4iVjjn9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hztpt6op" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64928iLu3600444 for ; Sat, 9 May 2026 17:04:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LWnmkIj1X0h4iZ/07axseI9cZy0pQq+izXTg9Q4Q7Ao=; b=E4iVjjn9NHR2HMrm 5iKaHumJmOd8aMEhBY+IzL4i+OnpljS2aYD+sYV4WEYSP5Qrl6dMkSBcEBVmw5TB 5dnPXyl8ZRLQY7tHGygxPyvehitUUn8UfH+Al0Y6r/8FxIGp8WnstlCJiR87mVQE dtsSYyDYOxry/UpPDgPHr87322qXK3Ww7FeGdBvV/7g44nyYe73PWHuB1qwEIAG8 CPNDxDra8QErexkNd60tfpragONN27FWkklrSFCG82IzrmEKljgqj25uEqPx/cCt lsNLI7Lp8PhNniIKf5wHgTN5j5uDON2Brl8NVt5j+TFJHblUbfuXcS5ujUWB9cew TXLdjA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1uvshhs0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 09 May 2026 17:04:26 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2bc860066a6so2841675ad.0 for ; Sat, 09 May 2026 10:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778346266; x=1778951066; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=LWnmkIj1X0h4iZ/07axseI9cZy0pQq+izXTg9Q4Q7Ao=; b=hztpt6opcy7nGR/t8C/3ssyAQgn/uh59+5KqZBwBKjddV1HI7RckLSKVsaNSRGorkz WIa6sQ7dpNbi2BjhNjJeuEHv4IAWPFPYiEi2GnZypDZRdthuKelU6nLj/0sBgNpUBXZQ PvajaEL+q1a3a05fXf62bmNI4dFxBUunolM82glKKqaVNWOR5AlzAuoPCWJVBbr7f224 x8gAymG1kB5vFz8J/+l6D8YygpeDQQ8cP73MS4S1z3pMlXLD2iyF1ea8NhP0d+KgAMIU TelT7/d9o/QNypEZD4vfzpMkq5nKigbe6KanRd9YGxT4Bt2+1ZjvuQfTf57szPWNxjuM DjpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778346266; x=1778951066; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LWnmkIj1X0h4iZ/07axseI9cZy0pQq+izXTg9Q4Q7Ao=; b=ZMjM6H8XYWBMvCzv8M4vpYsvgg4rTLzr/4dI10YQT8B5pM9BDNy5wJTbe6F9MTKjc7 QRdzhFyFpUKPHpTHneSS9s/EPAshheOyhrkyDbdT266UW8aopoLERv46bmLN86UxYRmL IhNGkQ02YivW8UM5LdC0x2g4yA2uj1Q1nquTZ3nCrLACOM9IzcvSFzMZhOlLYyIRQtM5 8RCJRD83C2T8ydGEPQvtKb57TIJ3AzQ1ukxNOoE89DEo0336/lv5O46NZE1yL9MPg3Hn qFGx0C8dlp78le0oKH3594jOtbSsqmQb9B7W27QuLnNheS/A5BxSf6SON1uZ86dLXSn4 nXrw== X-Forwarded-Encrypted: i=1; AFNElJ/xlmD/vMIKTtm08f5SA2PgSHfJULM12QswejplTKmbwAgd8jAbVqAv2AjLMIVwtSIYC65hDrkxHtrfn97D@vger.kernel.org X-Gm-Message-State: AOJu0YyAgmDDavNejN+UrUgfyejPuk6mp7t11xda60pfo7BuRRzcybLd 0xSrdXLNFom295dr/wPX5Z50L2l593i1cMlWR2r6TnKdK0W23kHToyrXIhd14UCFVM3RNwvwNYE QYxGxZX1yZp1gqiK3IErv2Z1mpV69jGu07YyPX+04pHj3m99ucBDeCtMLcokwpNxFvHLX X-Gm-Gg: Acq92OH0TJ6f1PuUjGga8MQHoFHV744TDgag0LIMGVqDMF+u0u9Racmej1uc0J/aKjB Vz6FIiSDkNmUyGGUBgjZPhxLPNyblEwMeblP0uUvEZsMltwWp+H4cFEpiKKjIysqcn4vaGA0Rui 7ObnCyAFPZZ4rSILen7ciivOnsgSs0oTum7oL8MNG+KQke2XFot81hfdOlr5WZE98MQzlYtxh4j Dbm8pYZPKR9S7oVFo5cHteCSynTtN6DuAoolfHHeqB5d+zzFX26mzyd9szRbpJr5a4p+5tHpHbe v5zwJQuu36ZrDL42PyTD4cBHPy68TUzUeYFAHbA5+kptsD56i5fwsUcSM6WXanUK7/dpQBn00k5 tFmjGokCI9WrjNOHxVAP9suW+yz+lma1UppKxGiZwnvjry6S7rb8= X-Received: by 2002:a17:903:4b03:b0:2b2:4d78:eec2 with SMTP id d9443c01a7336-2ba799d06d7mr164878915ad.18.1778346265635; Sat, 09 May 2026 10:04:25 -0700 (PDT) X-Received: by 2002:a17:903:4b03:b0:2b2:4d78:eec2 with SMTP id d9443c01a7336-2ba799d06d7mr164878445ad.18.1778346265007; Sat, 09 May 2026 10:04:25 -0700 (PDT) Received: from [192.168.0.9] ([49.205.255.40]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d27254sm55364225ad.4.2026.05.09.10.04.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2026 10:04:24 -0700 (PDT) Message-ID: Date: Sat, 9 May 2026 22:34:15 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Vishnu Reddy Subject: Re: [PATCH v5 04/14] dt-bindings: media: qcom,venus: Remove clock, power-domain, and iommus from common schema To: Dmitry Baryshkov Cc: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Joerg Roedel , Will Deacon , Robin Murphy , Hans Verkuil , Stefan Schmidt , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stanimir Varbanov , Jorge Ramirez-Ortiz , Del Regno , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, Krzysztof Kozlowski , devicetree@vger.kernel.org References: <20260509-glymur-v5-0-7fbb340c5dbd@oss.qualcomm.com> <20260509-glymur-v5-4-7fbb340c5dbd@oss.qualcomm.com> <35zfskmyogpazxy7wsw2jg36fvpnnc7hng23j4heq2jy5ookai@q7d2vl7nn7ck> Content-Language: en-US In-Reply-To: <35zfskmyogpazxy7wsw2jg36fvpnnc7hng23j4heq2jy5ookai@q7d2vl7nn7ck> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA5MDE4NSBTYWx0ZWRfX0nYREXkwYpTu 8DwpIC8WN7w7abV9CMtR6UPKOSg+8Gi3mjlvNmNb8VP9Peq6ZGA3HhZd6lJWLYoRowMw9A/fo1d 9JCADzmANbzjt66Z1aqZpIGr+V4BxbEaKF1jx9GDzU7vrRop+80n3j8dCU4/60w/LNs3HFe9EB5 z+nRLkUOeIhYjB+dwdyVNdQ1n3vDMxDcqJjRJmflTswfyuKd6zVtN2Ore7f8VESrn+GH3+Sh++e 3tvu8f9egFu/wafshtKrcbhsjYhlTlYVZtMn2emL58b89fvmvdEH1xMm0v+ldUPn1Igb5imtL0L gvIGqFAW0o0y/7GWeSvwNNL3K8uaN6Jl2a/ayzHM2eNw8cyE/YlraSUCjOFODOhLNBfeidHAhLc peINo0OtTpLaVTMQQ77ARXSvIf8slP4UMCyW8Ea3nNQ2vyv4GMMyVMVWEgHiXOc3/GDcTUIjodb Bs3yE4/lrEo+wTbWXRg== X-Authority-Analysis: v=2.4 cv=dujrzVg4 c=1 sm=1 tr=0 ts=69ff691a cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=SpcZ+gRb+6o1zy8jT5J+bQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=6XTuGWwdhPdsyaIifgkA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: qBxrwBdIkTv-1Jr7z1jiF19znZasmmBL X-Proofpoint-GUID: qBxrwBdIkTv-1Jr7z1jiF19znZasmmBL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-09_05,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605090185 On 5/9/2026 12:52 AM, Dmitry Baryshkov wrote: > On Sat, May 09, 2026 at 12:29:53AM +0530, Vishnu Reddy wrote: >> The common schema defines minItems and maxItems for clocks, power-domains, >> and iommus. This suggests that the number of these resources can vary, >> while in reality they are fixed constraints per platform. > It really doesn't. It provides common definitions, while individual > platform schemas tighten those. If a new platform requires more resources than the current maxItems listed in the common-schema (e.g.,Glymur due to its dual vcodec core design), we need to keep bumping maxItems in the common schema every time a new platform exceeds the previous limit. That makes the common schema a moving target driven by platform specific. I am fine with increasing maxItems in the common schema instead of removing. I can set it to a reasonable value (for example, up to 20) so that it accommodates future platforms without frequent changes. Anyway, each platform schema must define fixed constraints, since clocks and power-domains are mandatory per platform. Could you please let me know which one you would prefer going forward? >> Remove these constraints from the common schema. Each platform specific >> schema already defines its own exact fixed constraints for these >> properties. Additionally, remove these from the required list and update >> all schemas that reference this common schema. >> >> Signed-off-by: Vishnu Reddy >> --- >> .../bindings/media/qcom,msm8916-venus.yaml | 3 +++ >> .../bindings/media/qcom,msm8996-venus.yaml | 3 +++ >> .../bindings/media/qcom,qcm2290-venus.yaml | 3 +++ >> .../bindings/media/qcom,sc7180-venus.yaml | 3 +++ >> .../bindings/media/qcom,sc7280-venus.yaml | 3 +++ >> .../bindings/media/qcom,sdm660-venus.yaml | 3 +++ >> .../bindings/media/qcom,sdm845-venus-v2.yaml | 3 +++ >> .../bindings/media/qcom,sdm845-venus.yaml | 3 +++ >> .../bindings/media/qcom,sm8250-venus.yaml | 3 +++ >> .../bindings/media/qcom,sm8750-iris.yaml | 3 +++ >> .../bindings/media/qcom,venus-common.yaml | 23 ---------------------- >> 11 files changed, 30 insertions(+), 23 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml >> index da140c2e3d3f..b1046a112e17 100644 >> --- a/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml >> +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml >> @@ -62,8 +62,11 @@ properties: >> additionalProperties: false >> >> required: >> + - clocks >> + - clock-names >> - compatible >> - iommus >> + - power-domains >> >> unevaluatedProperties: false >> > [...] > >> diff --git a/Documentation/devicetree/bindings/media/qcom,venus-common.yaml b/Documentation/devicetree/bindings/media/qcom,venus-common.yaml >> index 3153d91f9d18..060be67574c7 100644 >> --- a/Documentation/devicetree/bindings/media/qcom,venus-common.yaml >> +++ b/Documentation/devicetree/bindings/media/qcom,venus-common.yaml >> @@ -18,35 +18,15 @@ properties: >> reg: >> maxItems: 1 >> >> - clocks: >> - minItems: 3 >> - maxItems: 7 >> - >> - clock-names: >> - minItems: 3 >> - maxItems: 7 >> - >> firmware-name: >> maxItems: 1 >> >> interrupts: >> maxItems: 1 >> >> - iommus: >> - minItems: 1 >> - maxItems: 20 >> - >> memory-region: >> maxItems: 1 >> >> - power-domains: >> - minItems: 1 >> - maxItems: 4 >> - >> - power-domain-names: >> - minItems: 1 >> - maxItems: 4 >> - >> video-firmware: >> type: object >> additionalProperties: false >> @@ -64,10 +44,7 @@ properties: >> >> required: >> - reg >> - - clocks >> - - clock-names >> - interrupts >> - memory-region >> - - power-domains > Do we expect the platforms with Venus / Iris not having either clocks or > power domains. All Venus / Iris platforms have clocks and power-domains. These removed from here and added in each platform schema. >> >> additionalProperties: true >> >> -- >> 2.34.1 >>