From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B43A327B35B for ; Wed, 1 Oct 2025 08:29:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759307367; cv=none; b=UaeuDicJT6iswCxzG9BSQwZgB5MtIzMtdr+IuVyKmZ5qhcHf/50Dwwd3lnuWqi8cI/Wg93Bn4WXrOAxJwJidcjhCMZvHvhoCWIcQUzethN9il5+7z22XAayi9Xg6KAzQzZBSYJHpeInUmfk987QHzi0Hr2d6IrvS+j7QLgP6TXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759307367; c=relaxed/simple; bh=GJyYeYBHgy3xU5bBVM/7TBQUpVqwyswe9ISkR//AIrQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vDm4SZOnAdXUk5tnvYbjrbY1dWpN+2pRYL63QeKnMFj4GtM2hYjYXpokXG2INyQ2djiLGWXDGRFoyqO13hbpC7AqP4ZLki5wpPMSRDGKkLN5P/hxVH/kXys+xNyArX3DSLehBeSP81mfDBXmo9dKmGTFC/DOdeTLwGY2fq45E2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iKeOwXXw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iKeOwXXw" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5918DwJd020484 for ; Wed, 1 Oct 2025 08:29:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tlGyIBE+5l5QzImcJDdIrFcGN7HtYMPqbdjDmPS9GTo=; b=iKeOwXXwxHqn0lv2 S89T90rOjaSXW1R50jxrbHh8M42QKQcO6KDkTqXh042ZYQuJOfcGQy490v8NUkL/ vgu0NmGD0DhZptmRhx3HthjkVRzSCu288/T6npvjXOSOOo9I9z3cNx+tszJDXt+R 2vl2/FqXZUop/VnyX3pX9NKnMWPk7bOoy6QbOygHMh1MPzeanAXuR67JqZbVh6vf CQG2iPwKZ22ecLXE+03NU8n/u+SvPvEJbCCkr+33wLpwfxjT52BtYMFKXecMxmVS t3FxKnj/J0Jo3xh5ijVCfpnhMewCZZUmzK322iXdcnsSwRtvPyRR1CJr4eotZdqa KP446Q== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49e6x5v0wc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 01 Oct 2025 08:29:24 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8572f379832so185130985a.3 for ; Wed, 01 Oct 2025 01:29:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759307363; x=1759912163; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tlGyIBE+5l5QzImcJDdIrFcGN7HtYMPqbdjDmPS9GTo=; b=AHoHcJzI1V01LLv7IbiNhCBjWEDihj/RQOhJcibLWMtVdepSG3UakEcotYwqVyI7oI NyV9o0SXdf0KeNULP9ivlUkVDe2KOtDoGl4RCfdQ+0t+kVK2+TkdBU5U+MPyaBCgdD8g kZhu/uUygs2CffpL9E4dpnXBrnX/ShmJefQSpu/3L8LYiRaFie/XYGd1b+8GxrXGmpNS QQoz0IsNz3f8WZOGUoPxC2vthabPS8exJx66zDLLewVu1NFUMzs19BpW1nQmQQDXjCCd MZZOtDSMxfMIn2UNqrohAR+Fkc+UotbWHKZmGuIhBFLbkdlzfL9iv9nMxv4EHb+rFJxK /EYg== X-Forwarded-Encrypted: i=1; AJvYcCXqOBhAZeb94FBFwIxLTk4Ne8nsBBoM9oj+S2/qc8iKm9UdGIgLb13LZWCPo+zCYVXUNTGpXibvt/AAPUSP@vger.kernel.org X-Gm-Message-State: AOJu0Yz9Rm5apZSvXZRG/xfcWIWuZDGOoUTwCGvkWnxpBuFppGWfKIGl W5AUXt4Otl7mg00PRClPKcKjWhRyFNbCcBT6pfGNFRB61SxD0kZRxZm8rVGJKrr7KO7Tz/ekITT LSyIuD3k1Ts9v+GGUL7GmFER2hjdGouv9bztj8expGVIfHERCacTrFbWguQCFbpTlyxGV X-Gm-Gg: ASbGncuO1+baxjbgK0SfC/PNZk1uVy9vRCmx25La/RS8TsCxlPrmsu7b6mvmKj4X1/T xWb1OBe7PrCZwNHHV90TXAVX6+N21towJ9jkH488CtNbxmye1HWcZkfo12nRRii8oUxNd0QWqDN 7UtioJL8VwM/5T+EyTkr47yjR3dEbCGPHGZmbr8acFrEZWx5UnROxJc463vVYzJd71oT21CNb1Z IhGtCfMHEyaIHQOrOb/mqkBqO+kqzVMwMSygRaK+XFUCAWmRbgTc4JBhhGsNtbOLQ0bVLNUTILt dmgKrWbOByv3hoTwkmZrKybNPzbG3YZxB0rsqRiwuQapjhuRDcad5tZivTLn8Pe3rR13KutA56B t6EQFxeUOKGvj9cTQLTTc/7jB4kE= X-Received: by 2002:a05:620a:17aa:b0:856:40d2:b1a5 with SMTP id af79cd13be357-873765c02d2mr260637685a.13.1759307363512; Wed, 01 Oct 2025 01:29:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIHr/OLBZEdgkn80ZN1dE9xO81kbu8cI04yKLGhC2XiEY6aWxZ/xP+utxgdYGLZbef2R3pXw== X-Received: by 2002:a05:620a:17aa:b0:856:40d2:b1a5 with SMTP id af79cd13be357-873765c02d2mr260634885a.13.1759307362978; Wed, 01 Oct 2025 01:29:22 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b353e5d7351sm1332312266b.7.2025.10.01.01.29.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Oct 2025 01:29:22 -0700 (PDT) Message-ID: Date: Wed, 1 Oct 2025 10:29:19 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED To: Luca Weiss , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Casey Connolly , Alexander Martinz Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss References: <20250930-otter-further-bringup-v1-0-7fe66f653900@fairphone.com> <20250930-otter-further-bringup-v1-5-7fe66f653900@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250930-otter-further-bringup-v1-5-7fe66f653900@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: dx3Te4lyxlr8_xig5meknaNjn-hdTK4x X-Proofpoint-ORIG-GUID: dx3Te4lyxlr8_xig5meknaNjn-hdTK4x X-Authority-Analysis: v=2.4 cv=ZtPg6t7G c=1 sm=1 tr=0 ts=68dce664 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=dlmhaOwlAAAA:8 a=6H0WHjuAAAAA:8 a=EUspDBNiAAAA:8 a=RgqGmV79IvFMSyKAuVEA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=y4cfut4LVr_MrANMpYTh:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI3MDAxOCBTYWx0ZWRfX8AjiGpe8osZv ub65Kg46H8gb/5o4BocZews+xsaY2X36m77jH0S4TSWTgJb0t55o/fnUWNBW06NMOsC2AZ8IT64 KKHBMXeXby7CFraq3MOuVNmIxMDmA+pd2sqcI0mK2vMrVqSQ0bp6EH+YRe3iJlV3oalWxIm7sGJ 6ibRWhhEBZ5BnXhY44awZs+zSCzJOI3hxgQduj6iP3yOEWWDTsrHZ/DHhilNSGIGcBVwAm8BoJm 3dDvLaByMxhfUJB73VinHITsIJrnge/J7STRDEIn0B7MvhbpYUjLVGqhq+b1RBECBrJnzyHnEQ0 dBn7SRIdTMGmHbpbBiN6pUHzgF3SvDc9ek2H+7lVVbzrV33+t4J4VwFnSPm5zsv8Su3I+YsWcsZ hzKC/i2fKTBbywRX45bGQJIqYzpQ6A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-01_02,2025-09-29_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509270018 On 9/30/25 4:32 PM, Luca Weiss wrote: > From: Luca Weiss > > Enable the RGB LED connected to the PM7350C (PM8350C). > > Signed-off-by: Luca Weiss > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 27 ++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts > index 36cc67469615974c193ea3a9db1b2362869d56bb..b4c69dc50ed0f0b3cb45341a01c89210bd261993 100644 > --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts > +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts > @@ -632,6 +632,33 @@ led-0 { > }; > }; > > +&pm8350c_pwm { > + status = "okay"; > + > + multi-led { > + color = ; > + function = LED_FUNCTION_STATUS; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@1 { > + reg = <1>; > + color = ; > + }; > + > + led@2 { > + reg = <2>; > + color = ; > + }; > + > + led@3 { > + reg = <3>; > + color = ; > + }; I assume you managed to confirm these mappings are correct.. sometimes they are not what you'd expect Reviewed-by: Konrad Dybcio Konrad