From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92402C636CC for ; Thu, 16 Feb 2023 17:16:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229606AbjBPRQQ (ORCPT ); Thu, 16 Feb 2023 12:16:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229896AbjBPRQP (ORCPT ); Thu, 16 Feb 2023 12:16:15 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 722D843443; Thu, 16 Feb 2023 09:16:06 -0800 (PST) Received: from [192.168.2.109] (unknown [109.252.117.89]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 00D3F6602116; Thu, 16 Feb 2023 17:16:03 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676567765; bh=8RfT/ATOYpAaq4kgh8A+t+VldumzcvpydtSOWpN9s9M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kT50sYEOQAK1eeuhcAYSgT3kb57q77fBt3kN8DmvPwjRchCyjR3BfehrnYGaQ8D6x e19DXEQVqZe2bueNDF2NC6FdO+L/luHFywCzxgw4c4idCFqbOu9Egeismn2s2ljpff hly6ZmBfXM8AFJT6acOFRJTMfR6gStqfdM3xVR56zg0DyUQ9YLXhg5MJzJfl4n3wG+ HrZOVQP+oqboCeMXiZeLLmVTWZEo6BJvQoZzb6MyjHEqGpm0vp9OGSdx7M2q8bPY/E +SJLneCCZsBb8evAwCSLVUXUzASwaaF8BZWeHRk2EgJ3zljJECbE4jcM28VOJxKLn9 ykLOjm4SpJEZw== Message-ID: Date: Thu, 16 Feb 2023 20:16:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] drm/msm: Fix potential invalid ptr free Content-Language: en-US To: Rob Clark , dri-devel@lists.freedesktop.org Cc: Rob Clark , linux-arm-msm@vger.kernel.org, Abhinav Kumar , Jordan Crouse , Sean Paul , Dmitry Baryshkov , freedreno@lists.freedesktop.org, open list References: <20230215235048.1166484-1-robdclark@gmail.com> From: Dmitry Osipenko In-Reply-To: <20230215235048.1166484-1-robdclark@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2/16/23 02:50, Rob Clark wrote: > From: Rob Clark > > The error path cleanup expects that chain and syncobj are either NULL or > valid pointers. But post_deps was not allocated with __GFP_ZERO. > > Fixes: ab723b7a992a ("drm/msm: Add syncobj support.") > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gem_submit.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c > index 6503220e5a4b..e4d13540300e 100644 > --- a/drivers/gpu/drm/msm/msm_gem_submit.c > +++ b/drivers/gpu/drm/msm/msm_gem_submit.c > @@ -640,8 +640,8 @@ static struct msm_submit_post_dep *msm_parse_post_deps(struct drm_device *dev, > int ret = 0; > uint32_t i, j; > > - post_deps = kmalloc_array(nr_syncobjs, sizeof(*post_deps), > - GFP_KERNEL | __GFP_NOWARN | __GFP_NORETRY); > + post_deps = kcalloc(nr_syncobjs, sizeof(*post_deps), > + GFP_KERNEL | __GFP_NOWARN | __GFP_NORETRY); > if (!post_deps) > return ERR_PTR(-ENOMEM); > > @@ -656,7 +656,6 @@ static struct msm_submit_post_dep *msm_parse_post_deps(struct drm_device *dev, > } > > post_deps[i].point = syncobj_desc.point; > - post_deps[i].chain = NULL; > > if (syncobj_desc.flags) { > ret = -EINVAL; Good catch! Reviewed-by: Dmitry Osipenko -- Best regards, Dmitry