From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF5BC7EE23 for ; Sun, 28 May 2023 22:01:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229523AbjE1WBK (ORCPT ); Sun, 28 May 2023 18:01:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbjE1WBK (ORCPT ); Sun, 28 May 2023 18:01:10 -0400 Received: from mail-4022.proton.ch (mail-4022.proton.ch [185.70.40.22]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89F9FB2 for ; Sun, 28 May 2023 15:01:05 -0700 (PDT) Date: Sun, 28 May 2023 22:00:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connolly.tech; s=protonmail; t=1685311263; x=1685570463; bh=kwQFJjiwN8twYz8De04hRwMEmGC/2PFsVzynq91D79U=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=F/cTeYLBdhPu3Va3xDShJgxFvuy0fBNfgarvf5EVEnkyxkudW4susNCI4Ujn7aJf7 9mEKOtymlS7YixdWIXlx+rCB4B2p0Vv5ZR0ki6KS+3qL6HVGopwwmM1TAYukqdIH5T Prk+H0dwpO592WPdDfIj0W7LSOg/Pc3x2ymODBUk= To: Marijn Suijten , Neil Armstrong , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson From: Caleb Connolly Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Abhinav Kumar , Kuogee Hsieh , Jessica Zhang Subject: Re: [PATCH RFC 01/10] drm/panel: Clean up SOFEF00 config dependencies Message-ID: In-Reply-To: <20230521-drm-panels-sony-v1-1-541c341d6bee@somainline.org> References: <20230521-drm-panels-sony-v1-0-541c341d6bee@somainline.org> <20230521-drm-panels-sony-v1-1-541c341d6bee@somainline.org> Feedback-ID: 10753939:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 21/05/2023 22:23, Marijn Suijten wrote: > As per the config name this Display IC features a DSI command-mode > interface (or the command to switch to video mode is not > known/documented) and does not use any of the video-mode helper > utilities, hence should not select VIDEOMODE_HELPERS. In addition it > uses devm_gpiod_get() and related functions from GPIOLIB. >=20 > Fixes: 5933baa36e26 ("drm/panel/samsung-sofef00: Add panel for OnePlus 6/= T devices") > Signed-off-by: Marijn Suijten Reviewed-by: Caleb Connolly > --- > drivers/gpu/drm/panel/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfi= g > index 2b9d6db7860ba..67ef898d133f2 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -608,10 +608,10 @@ config DRM_PANEL_SAMSUNG_S6E8AA0 >=20 > config DRM_PANEL_SAMSUNG_SOFEF00 > =09tristate "Samsung sofef00/s6e3fc2x01 OnePlus 6/6T DSI cmd mode panels= " > +=09depends on GPIOLIB > =09depends on OF > =09depends on DRM_MIPI_DSI > =09depends on BACKLIGHT_CLASS_DEVICE > -=09select VIDEOMODE_HELPERS > =09help > =09 Say Y or M here if you want to enable support for the Samsung AMOLE= D > =09 command mode panels found in the OnePlus 6/6T smartphones. >=20 > -- > 2.40.1 >=20 --=20 Kind Regards, Caleb