From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8B9323D7EC for ; Wed, 4 Feb 2026 05:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770184018; cv=none; b=bKHTRNC0FXm/S4JWjhdhSp1mrlcbxSEnzkV0pYruRGk+hyyHQIgWwKZYIZSy0CQTfsXLzWNdzcVrZ1tvdTvkCsHjGtTg4uToVHVVMRJEsMrb7d5KoTZJZ93capcXyk9sF5bvoNrovuOelrdr7ro8tBBqefy2kfSj9bouYk/ekac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770184018; c=relaxed/simple; bh=tNnd9yFOMETSUFiIUmYcFlJeVCp0RKC4c6TG6wvbL78=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=srwdqwWlS3Cgo60OopW82a0AIXooV6pjHWrmfQC5tUfhhCvH/qHAgF6iCHj6/dIz4/OyM2H82glb6PJjqU6LQOc+/ea51YAUNBuR5g2cjPA1uCa8EAHbLJVD6dsQvhIJds4VWC6fWKYE48BHu2GoB8pDXvuVaCaf0mj8KmSAB+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aQA5piNp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dA6biXv/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aQA5piNp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dA6biXv/" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61443bwX3337303 for ; Wed, 4 Feb 2026 05:46:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pw6pgiUBqTssrPGSNsLlGv5r8wuOBZBhuul/MWgVYX4=; b=aQA5piNp7L4Ufb0R 4kgNuLNLKpx8VURWd23feq8FcXglZ/P6Z6YQ4/gmkwEk4iC6Xg0irwqsWkpnZY/Y YmrrDqm3qwObahSPoa/CyLt3tRhSfCcCgdJQW+xys/rJ4TyXMDWkWWY1xPQXvTxI q2K+jfjKC5hamyvskrtXagzDKO9AVfLxcfPUSeX+jIV2X9H2Av+j3NJpPozJNI15 4ufNRVab68wEXsGJ1f2+/KE+OlIVmreonBSnrTVqQ1ki9fLpMSEJYPo38en9M5Q9 pc+B8DjUT0vlBM1Vd2H6W0vfaDc3gukCc16k80IGAzt9G9VWpXZKvjf0ULXhdiJ2 F5q9pw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c3gewb5f7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Feb 2026 05:46:56 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-81f42368322so5624258b3a.3 for ; Tue, 03 Feb 2026 21:46:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770184016; x=1770788816; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pw6pgiUBqTssrPGSNsLlGv5r8wuOBZBhuul/MWgVYX4=; b=dA6biXv/MJEO2WMAuwQRiQV33OxE0ngqra/CMNXC5o19bNmbcuKKJqVKB5RejdeMb4 5BkthuyqYD5OjJhXrLrZbow1nJNpaCdHuEQaY7FJYZqeFqP3HfKFhK6wLGAGIIATTQ6T rkXJ8UtGX4E7aStFJGtYX3tP/fvjNHscgbqjNKBJDdjgUYss3OeN98PZYidO9x6JCqBx Q5eK9pn8iuz8csTR5h601wZTxQqcnBg+Zh0RsJYtqZhERw0oipRKXqvNIbQpAIeVRes4 ZH/P7mznoFMJr5qA2BQWrqIhbfLrFMCPTMohEophk3gtvKAIPacS9gfWFOBe7WhEfV6Y b9kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770184016; x=1770788816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pw6pgiUBqTssrPGSNsLlGv5r8wuOBZBhuul/MWgVYX4=; b=Rpjt10GURL1Dpq7vsma0Dl1P01sbidG75vX0BPXwBQO5WQ8H75XXMLzE5JtIZdk436 HqaNXYPzhjVwNdkTcH2GI1CCTzdsilgnp0caAwb7MBHRdDWsDx2rSxlxlsK2QycHH2f+ 9FUO+uEPcogVBBjzC6XnSV2s0GGD0N4G6Jzi77G/LJSivfYUYeroO3Ks8z+onVRxqtXN /pQ+1tMYmb2xMwxq8FpJZp7p5gGXNkcLoWdCLxjBlKxlu4b9pCMjUSxLNuFHfUu08YQO 8RI7rlIbebKFpdbuahVA01VFSz47qpoKG50A6nOWqQDLJBAK65ke0nXYXtK+Mj/gWUsb 3VLg== X-Forwarded-Encrypted: i=1; AJvYcCXNpbBaZS+rX4i4mxcoig8qAcdv6Fmo8al07oWwJGJkL5TJtA0Kgbn3Y4pAunyij/0ehKhVwAPbjtqS+ZG9@vger.kernel.org X-Gm-Message-State: AOJu0YzG9i49tzbI8Cck1XHcq/DappDeRa6qHyaw1xM3FkttGzN7ztmz wM9Od2IDAdMPc5uPKAVrPIcJNBSUcLaR5g8XNzwF516OE22FAg8kKF96c8k/FY9vGWNnXsDsfLL zkg6em2/CaAgeRLZcO6WxL+JGSVK4VAfXdW0bMYCDwx8euDafCJ+9aE9BuwepUqZ4zh/u8hUa2d nL X-Gm-Gg: AZuq6aJ/88cU6bCXcA2k5iT7DcIj0gPsdPiK844O4o+DR7yN8O2MSdF5d7pGd41EAKz yuZB7LlQeItauc2M6qZwf0KMB/HZl9PyXTH5MoC6ZOV1m+V+oAquX437+Mbb3AKuBSSPhoipSxr ObexQLihtA5/OwRqkLQ9u4qZl0y3sWciqdwVzhYRlrYncqHksynuHSSBjTTLBnJ05d5fnZNCUrs ilw5wxyj64say7xPOfi/zZP09sHjLcc3PaZmL/Y0ARFdB4mZhAM8HQ/AxiF4FQY+02BUkTY5RsV RchjPvYV3OLEb97ZdaERGFs02qCCMKC7tvQrG/BSgKLov6xF4R3wWBphhl0TE/XBK5OY35DHU75 HZZTxWtB1zIJAA6aCSinuoGI1QsCv8hlvri2GBw52XA== X-Received: by 2002:a05:6a00:a04:b0:81d:d666:72e1 with SMTP id d2e1a72fcca58-8241c1973ddmr1840203b3a.10.1770184015624; Tue, 03 Feb 2026 21:46:55 -0800 (PST) X-Received: by 2002:a05:6a00:a04:b0:81d:d666:72e1 with SMTP id d2e1a72fcca58-8241c1973ddmr1840179b3a.10.1770184015030; Tue, 03 Feb 2026 21:46:55 -0800 (PST) Received: from [10.218.32.171] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8241d163b8asm1250196b3a.1.2026.02.03.21.46.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 21:46:54 -0800 (PST) Message-ID: Date: Wed, 4 Feb 2026 11:16:46 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 10/12] i2c: qcom-geni: Use resources helper APIs in runtime PM functions To: Konrad Dybcio , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bryan.odonoghue@linaro.org, dmitry.baryshkov@oss.qualcomm.com, bjorn.andersson@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com References: <20260112104722.591521-1-praveen.talari@oss.qualcomm.com> <20260112104722.591521-11-praveen.talari@oss.qualcomm.com> <638daf43-d80c-493b-a88d-18bef447c02e@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <638daf43-d80c-493b-a88d-18bef447c02e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: RllF6YpwkqCe8Hf9YlRm5rIg7SlCXRUD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDA0MCBTYWx0ZWRfXzysMPyJsjhC3 uhaqoapu75NhjeTRQxc4SsD6R+RKPuzXNPWOhqAxzi3sTaIe3Lx5th30uyHe1UHJdEnO05I9JNx bPybfyLEE88kmh9XOlnOl7bGFToVxGuchWvpRgsNPLIkF/LWCJbg4RddP1Ocyx6uPNf71ILmcfp 1j74snCkTWxVnXllAPCcdA6QmgyitL6233m7CaxGq76KD8xedhiSMCpn5wNTDNC25uVezIs+m/q ofkjrFqFzdMk3nzSyps9y/gDWsfLdWKu5PtTEvpI8yYQFWtgymAyv4R9oAO6ib4AbF9yapqTvA6 ePKvQEj9zJT0xlKXpir8I2vqU4GF7dTw+hZraHD8jNjbjoAc3+c5kMdKV8BgoYlbvw6YHVFfCzV h4V/vnJHhEblnUMh3XLrDNLVN9NmHjWGSkJXub6YWeJUge/R7hmH8ywjFBZGdQisSvvEkB4jjk6 TP8q9nuPr8EpHVYbgSg== X-Authority-Analysis: v=2.4 cv=XI89iAhE c=1 sm=1 tr=0 ts=6982dd50 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=A8oE7KmpfnhtQquP3SoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: RllF6YpwkqCe8Hf9YlRm5rIg7SlCXRUD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_07,2026-02-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602040040 Hi Konrad, On 2/3/2026 4:43 PM, Konrad Dybcio wrote: > On 1/30/26 5:48 PM, Praveen Talari wrote: >> Hi Konrad, >> >> On 1/30/2026 5:35 PM, Konrad Dybcio wrote: >>> On 1/12/26 11:47 AM, Praveen Talari wrote: >>>> To manage GENI serial engine resources during runtime power management, >>>> drivers currently need to call functions for ICC, clock, and >>>> SE resource operations in both suspend and resume paths, resulting in >>>> code duplication across drivers. >>>> >>>> The new geni_se_resources_activate() and geni_se_resources_deactivate() >>>> helper APIs addresses this issue by providing a streamlined method to >>>> enable or disable all resources based, thereby eliminating redundancy >>>> across drivers. >>>> >>>> Signed-off-by: Praveen Talari >>>> --- >>>> v1->v2: >>>> Bjorn: >>>> - Remove geni_se_resources_state() API. >>>> - Used geni_se_resources_activate() and geni_se_resources_deactivate() >>>>    to enable/disable resources. >>>> --- >>>>   drivers/i2c/busses/i2c-qcom-geni.c | 28 +++++----------------------- >>>>   1 file changed, 5 insertions(+), 23 deletions(-) >>>> >>>> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c >>>> index a4b13022e508..b0a18e3d57d9 100644 >>>> --- a/drivers/i2c/busses/i2c-qcom-geni.c >>>> +++ b/drivers/i2c/busses/i2c-qcom-geni.c >>>> @@ -1160,18 +1160,15 @@ static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev) >>>>       struct geni_i2c_dev *gi2c = dev_get_drvdata(dev); >>>>         disable_irq(gi2c->irq); >>>> -    ret = geni_se_resources_off(&gi2c->se); >>>> + >>>> +    ret = geni_se_resources_deactivate(&gi2c->se); >>> >>> This calls dev_pm_opp_set_rate(se->dev, 0), dropping the performance state >> >> This does not apply to I²C, since I²C lacks an OPP table, so the callback is only relevant for SPI and UART. All the refactored APIs were added as generic interfaces shared across I²C, SPI, and UART. > > Does the i2c mode not require any ratesetting on the SE clock, or Yes, it is not needed since we are updating clock related values in SE register like I2C_SCL_COUNTERS. Thanks, Praveen Talari > any >= LOWSVS RPMh vote on the power rail? > > Konrad