From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b8-smtp.messagingengine.com (fout-b8-smtp.messagingengine.com [202.12.124.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EACDA930; Thu, 24 Jul 2025 20:15:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.151 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753388121; cv=none; b=erd3w8XOAxvFkXCk3QHHgC3V2uuKtAB3Ej6WW8fT5u453DnSAgD/u5mNyuIDwjlrtkSnufR8ldycb6MzWQiWI+PPvvKcZYR3a2FqWHI5V7grtgE9vTUzsw2D9jJ1Ac1AuKzKxq2OL5Lff9Hz4rXHUPDW6Q6icoqFSO/KIZToyt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753388121; c=relaxed/simple; bh=HPtbWC+qPnoUiK+D21GdTwSJ7kpmg7wR3o9K17sRlDE=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=ZpS6LYcXkbIBxBUUgfl82FnPCJd9sBYLQLjrfJr3K/i2sl7XIz83Un6y4s46u3DeNm1oodh8hNgdGhPe6zVv09wQuzfBD7Cw05vdQcRjts7F9R97kLyfhu5RKjtBUDSaFcWGBtsyG9w17CUmMTVK614gNapJgZhXFIpVWumrqOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=ZlY1OZZp; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=QRARHRsL; arc=none smtp.client-ip=202.12.124.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="ZlY1OZZp"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="QRARHRsL" Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id 27A4B1D000A2; Thu, 24 Jul 2025 16:15:14 -0400 (EDT) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-05.internal (MEProxy); Thu, 24 Jul 2025 16:15:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1753388114; x=1753474514; bh=OR/k+Yb5/r+lek9vOADsYQwcNg5wzPpkQDsX2OIgMug=; b= ZlY1OZZp1b8Am586wXCOEfdW2AMcU7RcaT8sqpqT/8k4I92gu9q29SFgAXek1YCI 4t9lQd40irk7COhFF6j/wy4BQdvpnChmOGGpD3iY2AX0mHlGyYvLfkY5qrAHd7TQ pINY9m91E/QXKSfYSRm9Fvi5uLXhFdfJvUMGQY0A8TXgjSUpiVxxikgBK3OVb/Lb PpjHPbgueaBdNeZD4Kbz91lSDdr+oAC9Hvadip18Ky/sGdYkAGtqtEQF65o1yG2q /u2SX0mYksDyaTRF2eiVZbdsOAmyqVQSkI7hlgnlDgUeNEU4nhG6zYWyVp1xRTuw VCniGz2DS+T2Zpe+RWbz+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1753388114; x= 1753474514; bh=OR/k+Yb5/r+lek9vOADsYQwcNg5wzPpkQDsX2OIgMug=; b=Q RARHRsLa9Q+F+YeBtWudr1ydchv20onMQrg5MhoL0jaxVs0zxSQ1UH/v2HCyeFNY tD4i1JWpRrsoMixcCZQI4U8F/RWWZQxlrlv8ynX3i/nVvRjzGyc1hvoq303Dn4rO 2FWsJ8T4aSfVaUYXdmA4MO8ncLQPP69ZhyuT0KDtGxRyH2fOpdu49jff5kAjOdZd 8nVkbjjxpzutn9Qiopw7pb4JUDnTCMJdHJXRWltPqvpIpWv+GJRIcniateNi7SZV d1sP+GLmYf7ePjT3nHFtZmH0kto3FXWoh9cNpofsosKEf+G0SHzla8l4EBMRvycu EH3VMlp1Hz8MwgE8ZT2aQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdekudehkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefoggffhffvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdetrhhnugcu uegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtthgvrh hnpefhtdfhvddtfeehudekteeggffghfejgeegteefgffgvedugeduveelvdekhfdvieen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnug esrghrnhgusgdruggvpdhnsggprhgtphhtthhopeefvddpmhhouggvpehsmhhtphhouhht pdhrtghpthhtohepshhouhhvihhkrdgthhgrkhhrrghvrghrthihsegrrhhmrdgtohhmpd hrtghpthhtoheptggrthgrlhhinhdrmhgrrhhinhgrshesrghrmhdrtghomhdprhgtphht thhopehmrghrkhdrrhhuthhlrghnugesrghrmhdrtghomhdprhgtphhtthhopehsuhguvg gvphdrhhholhhlrgesrghrmhdrtghomhdprhgtphhtthhopehflhhorhhirghnrdhfrghi nhgvlhhlihessghrohgruggtohhmrdgtohhmpdhrtghpthhtoheptghrohhsqdhqtghomh dqughtshdqfigrthgthhgvrhhssegthhhrohhmihhumhdrohhrghdprhgtphhtthhopehs figsohihugestghhrhhomhhiuhhmrdhorhhgpdhrtghpthhtoheprghnuggvrhhsshhonh eskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheptghonhhorhdoughtsehkvghrnhgvlhdr ohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id DD1DA700065; Thu, 24 Jul 2025 16:15:12 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: T8f78d0e2b9c43c44 Date: Thu, 24 Jul 2025 22:14:52 +0200 From: "Arnd Bergmann" To: "Shivendra Pratap" , "Krzysztof Kozlowski" , "Florian Fainelli" , "Bartosz Golaszewski" , "Bjorn Andersson" , "Sebastian Reichel" , "Rob Herring" , "Sudeep Holla" , "Souvik Chakravarty" , "Krzysztof Kozlowski" , "Conor Dooley" , "Andy Yan" , "Mark Rutland" , "Lorenzo Pieralisi" , "Konrad Dybcio" , cros-qcom-dts-watchers@chromium.org, "Vinod Koul" , "Catalin Marinas" , "Will Deacon" Cc: "Dmitry Baryshkov" , "Mukesh Ojha" , "Stephen Boyd" , =?UTF-8?Q?Andr=C3=A9_Draszik?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, "Elliot Berman" , "Srinivas Kandagatla" , "Elliot Berman" , "Konrad Dybcio" Message-Id: In-Reply-To: <58eb8f0e-a029-cb7f-e63a-9eac6a6444df@oss.qualcomm.com> References: <20250721-arm-psci-system_reset2-vendor-reboots-v12-0-87bac3ec422e@oss.qualcomm.com> <56599da9-0200-72b5-012e-942a1fc954b2@oss.qualcomm.com> <36f62026-9517-42bd-8f9a-92f39fcdc136@app.fastmail.com> <58eb8f0e-a029-cb7f-e63a-9eac6a6444df@oss.qualcomm.com> Subject: Re: [PATCH v12 0/8] Implement vendor resets for PSCI SYSTEM_RESET2 Content-Type: text/plain Content-Transfer-Encoding: 7bit On Thu, Jul 24, 2025, at 20:21, Shivendra Pratap wrote: > On 7/24/2025 8:13 PM, Arnd Bergmann wrote: >> On Thu, Jul 24, 2025, at 16:04, Shivendra Pratap wrote: >> How about using the reboot driver name as the identifier in sysfs >> instead of the compatible string? That would make it independent of >> devicetree. > In current patch, psci driver registers to reboot-mode using a device-tree > node. So reboot-mode does not has a driver name for psci's reboot registration. > its like - reboot_mode_register(reboot, ) > > Now when we want to use the registering reboot driver's name for sysfs, > either we- > 1, Pass an explicit name from psci driver(say "psci") while registering > to reboot-mode. > or > 2. Create a virtual device in psci driver with name say "psci" and then > register for reboot-mode. > > which one is preferred? suggestions? I would pick 1, to decouple the namespace from the device and to keep it simpler. >> I had a related idea to provide some namespacing on the actual >> reboot syscall parameter, as we have two (or more) orthogonal >> concepts here, when there is more than one reboot driver and >> drivers support multiple modes. >> >> E.g. you could use >> >> syscall(__NR_reboot, LINUX_REBOOT_MAGIC1, LINUX_REBOOT_MAGIC2, >> LINUX_REBOOT_CMD_RESTART2, "watchdog"); >> >> vs >> >> syscall(__NR_reboot, LINUX_REBOOT_MAGIC1, LINUX_REBOOT_MAGIC2, >> LINUX_REBOOT_CMD_RESTART2, "psci"); >> >> to pick one of the drivers, or >> >> syscall(__NR_reboot, LINUX_REBOOT_MAGIC1, LINUX_REBOOT_MAGIC2, >> LINUX_REBOOT_CMD_RESTART2, "bootloader"); >> >> syscall(__NR_reboot, LINUX_REBOOT_MAGIC1, LINUX_REBOOT_MAGIC2, >> LINUX_REBOOT_CMD_RESTART2, "recovery"); >> >> to ask for a reboot from any driver that supports a mode, or >> combine the two and ask a specific mode in a specific driver like >> >> syscall(__NR_reboot, LINUX_REBOOT_MAGIC1, LINUX_REBOOT_MAGIC2, >> LINUX_REBOOT_CMD_RESTART2, "psci:bootloader"); > This will introduce an additional feature in the reboot-mode driver. > If a colon is present in the command like ":bootloader", > Call the "" specific writes only. > We want to add this feature? I think this will require a little more rework in the reboot infrastructure, and I did not mean for you to do it now, we can always decide to do this as a follow-up, but I brought it up because the way we pick the namespace will limit our options later. Arnd