From: Devi Priya <quic_devipriy@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
<andersson@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <jassisinghbrar@gmail.com>,
<catalin.marinas@arm.com>, <will@kernel.org>,
<shawnguo@kernel.org>, <arnd@arndb.de>,
<marcel.ziswiler@toradex.com>, <dmitry.baryshkov@linaro.org>,
<nfraprado@collabora.com>, <broonie@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: <quic_srichara@quicinc.com>, <quic_gokulsri@quicinc.com>,
<quic_sjaganat@quicinc.com>, <quic_kathirav@quicinc.com>,
<quic_arajkuma@quicinc.com>, <quic_anusha@quicinc.com>,
<quic_poovendh@quicinc.com>
Subject: Re: [PATCH 5/6] dt-bindings: mailbox: Add compatible for IPQ9574
Date: Fri, 27 Jan 2023 21:15:02 +0530 [thread overview]
Message-ID: <fd8f34fa-77d1-98c4-64f3-cc5ffeb7bd0e@quicinc.com> (raw)
In-Reply-To: <83718846-1c51-d102-d11a-a14860be8454@linaro.org>
On 1/13/2023 8:43 PM, Konrad Dybcio wrote:
>
>
> On 13.01.2023 15:36, devi priya wrote:
>> Add the mailbox compatible string for IPQ9574 SoC
>>
>> Co-developed-by: Praveenkumar I <quic_ipkumar@quicinc.com>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
>> Signed-off-by: devi priya <quic_devipriy@quicinc.com>
>> ---
> Binding changes should come before driver changes, so that
> you're not introducing an "illegal" compatible and only
> "legalize" it later - please reorder the patch.
>
> Konrad
Understood, will reorder the patches in V2
>> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>> index 943f9472ae10..9e076758a58a 100644
>> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>> @@ -20,6 +20,7 @@ properties:
>> - enum:
>> - qcom,ipq6018-apcs-apps-global
>> - qcom,ipq8074-apcs-apps-global
>> + - qcom,ipq9574-apcs-apps-global
>> - qcom,msm8976-apcs-kpss-global
>> - qcom,msm8996-apcs-hmss-global
>> - qcom,msm8998-apcs-hmss-global
>> @@ -113,6 +114,7 @@ allOf:
>> enum:
>> - qcom,ipq6018-apcs-apps-global
>> - qcom,ipq8074-apcs-apps-global
>> + - qcom,ipq9574-apcs-apps-global
>> then:
>> properties:
>> clocks:
>> @@ -129,6 +131,7 @@ allOf:
>> enum:
>> - qcom,ipq6018-apcs-apps-global
>> - qcom,ipq8074-apcs-apps-global
>> + - qcom,ipq9574-apcs-apps-global
>> then:
>> properties:
>> '#clock-cells':
Best Regards,
Devi Priya
next prev parent reply other threads:[~2023-01-27 15:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 14:36 [PATCH 0/6] Add APSS clock controller support for IPQ9574 devi priya
2023-01-13 14:36 ` [PATCH 1/6] dt-bindings: clock: Add YAML schemas for QCOM A73 PLL devi priya
2023-01-13 14:57 ` Krzysztof Kozlowski
2023-01-27 15:37 ` Devi Priya
2023-01-13 15:05 ` Konrad Dybcio
2023-01-27 15:40 ` Devi Priya
2023-01-13 14:36 ` [PATCH 2/6] clk: qcom: ipq9574: Enable APSS clock driver devi priya
2023-01-13 15:12 ` Konrad Dybcio
2023-01-27 15:43 ` Devi Priya
2023-01-31 9:29 ` Dmitry Baryshkov
2023-01-31 9:39 ` Devi Priya
2023-01-13 14:36 ` [PATCH 3/6] arm64: defconfig: Enable ipq6018 apss clock and PLL controller devi priya
2023-01-31 9:31 ` Dmitry Baryshkov
2023-02-01 14:26 ` Devi Priya
2023-01-13 14:36 ` [PATCH 4/6] arm64: dts: qcom: ipq9574: Add support for APSS clock controller devi priya
2023-01-13 14:36 ` [PATCH 5/6] dt-bindings: mailbox: Add compatible for IPQ9574 devi priya
2023-01-13 15:00 ` Krzysztof Kozlowski
2023-01-13 15:13 ` Konrad Dybcio
2023-01-27 15:45 ` Devi Priya [this message]
2023-01-13 14:36 ` [PATCH 6/6] clk: qcom: Fix APSS PLL and RCG Configuration devi priya
2023-01-13 15:20 ` Konrad Dybcio
2023-01-13 16:17 ` Robert Marko
2023-01-31 9:23 ` Devi Priya
2023-01-31 9:17 ` Devi Priya
2023-01-31 9:40 ` Dmitry Baryshkov
2023-02-01 14:40 ` Devi Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd8f34fa-77d1-98c4-64f3-cc5ffeb7bd0e@quicinc.com \
--to=quic_devipriy@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mturquette@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=quic_anusha@quicinc.com \
--cc=quic_arajkuma@quicinc.com \
--cc=quic_gokulsri@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_poovendh@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox