From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 037D326D4CD for ; Thu, 28 Aug 2025 22:36:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756420574; cv=none; b=ZNcElWDvBuE5MKqAec5dug615XGiQI/opfO5lb8mydGeBZ8z/xmI2hqn9THs9oFookUtb3T3Eg5Rg6lLMXgSxuX2vl4iqfmE2GgAk/c2Y1mJJ8cLO1kTcZ0sVIBcOIPWVeG2tTXKydenoYMjDSe+jPRdTiyWFVsNs02VtSLnj64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756420574; c=relaxed/simple; bh=WKDOcnId/fYiJ4MUHlzvu++y6Wq1vaCFpfHFQlstfI4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ngDDy+fFZaKiaqVFm3kDcFKIAz9BscoOyhqgzjfjR9Shesgt7N/9lFAI/uHSQrDzOAk3kNq7pLVOl1ZZHmIj9FZ5t8YbEPaFdc1zefhyPbBvx8ZDqQwffwgDhW4WICbIExHlUuWptiX7aBSfT1oNu2xje9aMj/8uf+VdOW6Jk6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=H5RbBKcA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="H5RbBKcA" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57SLWcnG031311 for ; Thu, 28 Aug 2025 22:36:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= y7VHqRENNJebegQN/o6tbEoCvsmRk6JgWzlghb8aS8g=; b=H5RbBKcA8dwgu68G Qd7Ho/1SX7BctuQEsXJOWYwxeWvB7zK0Sp0mdUlJCpzGCGouyd27GTXy4cuJzeyO e5NaQhU3tjj28KvUG2Tw1YvuChcS0zePh67E16QnE9ypcJNfFBX9aiJlR2fcJ9cf gnT0PhMCk/Ii8RoLeYjwghxS+SAHt6E3UCPGhQ8mApskpJGUU6VIeEg6bPzK9AOf y5a6DMt4/KZdLG2AGT6IkXL975rjHNQJUC2F8J6Pjy3r/9CzmSoJemJNpok2tXHC hkDWadfFQ04eUI74vjXNYYAWvINl7tY1vENAPsawqKW6zFquF2hQAEskWhLFyKNb yPhb0A== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48tn67j4gx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 28 Aug 2025 22:36:12 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4b302991816so21512431cf.0 for ; Thu, 28 Aug 2025 15:36:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756420571; x=1757025371; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y7VHqRENNJebegQN/o6tbEoCvsmRk6JgWzlghb8aS8g=; b=doWj7zugNfJ0XwyrHVxaAbwNMflGGUxRaacSfbVNyEcmGw3RFmA7wyfMnpY4U4HAGS Xa/8sSqnNz8V/sdLOTHbJvpYBf6lG8hFHpWEjxsYJVLK4JxiY9pytlTpvaJqdOslPhIZ l+/C1RsIoF3DJ8hljOMM5RnarEQcv06aRVwg59bYMTsz2NF3C70tH1ElXtkw84O6d+ab FSEj5VIDjpDD9UKkNkKWpB0w7uI+dQosy1LIPs4IV+vz88kZX3YX26bWXO4Lq9aXeBYe YKGuu3hLs9/G8WHh8nQgArGncGbuHZYPRm9ACe7K+dJWR3n0o+1v29cEjXUP0ziklWnE vZfw== X-Forwarded-Encrypted: i=1; AJvYcCVbtE5GKF67Wwr4Ed7N9YxotOdRq1eQ6bkhtKFKu2L1PG4dnjazNhwe7oyVrHUnq0EVcm1B1g8It09SYdGM@vger.kernel.org X-Gm-Message-State: AOJu0Yw/fchwAra6IwSj0u1Yu5Sn2YCiZj68o+y55wPCD1bm2LVDFVmM Pb/vAouV0wuUbtbDWsZyKthJiV5b/6U1qiTz5IB0OzgGMtn9c124ffto/xNdvNv1nV41RwpBl3F 5X3JBM0zwMKGibypiiL2tNc/OY9WXrF8r2cTKicFlCdchmEurLPWrNDCFd/uwx53sJcze X-Gm-Gg: ASbGncurmkGA6rIeZ7YIlwFEpa5d92a0WlckvfziNGAF8KIJrleHOBLNGoU+iHLy/dB at503yRoBEIeYBcK7CWwfZKlZEe9Kcwshv8KgkUu/plrmX3QbE071g3PMZ2dpHVS7IVUAXRjoD8 hRgaZP+lyumwvLpP2cobOgAGnoxE1vhL7bMLni3dnHBycfGhSB8vco4s1FpYaRDrDvHWykId11F MuLYGCzL5P+RFphpK3WLgDIVpJxIhpzCvfV9xyAUM0beGdD5hiv5CMB0/GPSepu4IzV+gvfOcGT hWdR77uq+2KOc/LtdCj74INPcPQPufzpFdaAZsgN0Guv1wg/Lk9v9kOTzEgRDYWJ7GaDFXjYl9B wZvERAcMeFYLL6+UIBsfjDTjtphxRu/Sxjmna9Rs21Fo= X-Received: by 2002:a05:622a:4119:b0:4b3:81b:c5ad with SMTP id d75a77b69052e-4b3081bcfdbmr33563011cf.80.1756420570697; Thu, 28 Aug 2025 15:36:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgrEZRc/uiXvTH7Z0zYEjpMYvq3lZXxGw7EpCSWLs1tGYbdD4Ja4C6+txkoDZ9SwLFf/s6PQ== X-Received: by 2002:a05:622a:4119:b0:4b3:81b:c5ad with SMTP id d75a77b69052e-4b3081bcfdbmr33562751cf.80.1756420570196; Thu, 28 Aug 2025 15:36:10 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0c3:3a00::4c9? (2001-14ba-a0c3-3a00--4c9.rev.dnainternet.fi. [2001:14ba:a0c3:3a00::4c9]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55f67852eeasm135474e87.100.2025.08.28.15.36.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Aug 2025 15:36:09 -0700 (PDT) Message-ID: Date: Fri, 29 Aug 2025 01:36:08 +0300 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: interconnect: add clocks property to enable QoS on sa8775p To: Odelu Kukatla , Krzysztof Kozlowski , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: Raviteja Laggyshetty , Bartosz Golaszewski , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Tipton References: <20250808140300.14784-1-odelu.kukatla@oss.qualcomm.com> <20250808140300.14784-2-odelu.kukatla@oss.qualcomm.com> <90b51e31-3217-4483-bb5b-ec328665a723@kernel.org> <28b97952-1b67-411f-a7fb-ddd558739839@oss.qualcomm.com> <7d3e5cf7-4167-4005-ba4b-c1915c254705@oss.qualcomm.com> <00f50d92-e4ea-4805-b771-147fa5f5ebe4@kernel.org> <249f8109-31b1-4cb8-a5a4-b30c27b2e987@oss.qualcomm.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: <249f8109-31b1-4cb8-a5a4-b30c27b2e987@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA4NSBTYWx0ZWRfX0MZr8MGefs/G JXIHz9qRSpZnHiPl/vkRAJq0adZo07ykVGqwOTkzkXkNr9E9GT2xU5hyZH904Q/8XzbPoGkJytf 6Mlm4VUWTuY5d9TL0ynBs1KZLkwCahmJFLNNIMu3IEhTSXD0GT2Z57fmhm8lHamqgAJioPo6gnd Z0EbnrpL9OnGSuX0lF7qnoyp/MQB5VDMywSopRTXA+MAmsb2zAB1mwozcgzWIzQPPh+F5j/tgzH H7wmtQWqJYUpa/cmcup/0zo5aDOKBq+pm1WQ+OUN2wpFjtM3DwNZy9d8cLVv6Q69oxJ0xndg4hj KwJ/gnvXINFp5E7lscQCh8nb2OAkMQZi5c/rfSpvKeC3gkI/WjHUh062ja2ygJBMBRppJzQxbwq EGu38sh2 X-Proofpoint-GUID: j73lubSVp3KcFY3BnSRJ6SFbGdVdlMSl X-Proofpoint-ORIG-GUID: j73lubSVp3KcFY3BnSRJ6SFbGdVdlMSl X-Authority-Analysis: v=2.4 cv=P7c6hjAu c=1 sm=1 tr=0 ts=68b0d9dc cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=tJ9fhpcgm4yphQaQ0K8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_04,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 adultscore=0 phishscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508280085 On 28/08/2025 21:16, Odelu Kukatla wrote: > > > On 8/24/2025 2:38 PM, Krzysztof Kozlowski wrote: >> On 20/08/2025 10:51, Odelu Kukatla wrote: >>> >>> >>> On 8/13/2025 11:32 AM, Krzysztof Kozlowski wrote: >>>> On 13/08/2025 07:55, Odelu Kukatla wrote: >>>>> >>>>> >>>>> On 8/12/2025 3:47 PM, Krzysztof Kozlowski wrote: >>>>>> On 08/08/2025 16:02, Odelu Kukatla wrote: >>>>>>> Add reg and clocks properties to enable the clocks required >>>>>>> for accessing QoS configuration. >>>>>> >>>>>> >>>>>> Nothing here explains why EXISTING hardware is being changed. I also >>>>>> remember big discussions and big confusing patches regarding sa8775p >>>>>> (its rename, dropping/changing all providers), and this patch feels like >>>>>> pieces of it without proper justification. >>>>>> >>>>> Thanks for the review. >>>>> I have added description in cover letter, i will add here as well in next revision.> And this is hidden ABI break, no justification, no mentioning either. >>>>>> Again we are discussing basics of ABI breaking patches? >>>>>> >>>>> If you are talking ABI break if we load old DT which may lead to crash, we have .qos_requires_clocks flag which takes care of skipping QoS if required clocks are not enabled.we have addressed this issue through https://lore.kernel.org/all/20240704125515.22194-1-quic_okukatla@quicinc.com/ >>>> >>>> Format your emails correctly, it's difficult to read. >>>> >>>> Your binding did not require reg and clocks. Now it requires reg and >>>> clocks. This is called ABI break. >>>> >>>> Please follow Qualcomm extensive upstreaming guide, it explains this, >>>> doesn't it? Or follow writing bindings... >>>> >>> >>> Thanks for your review and guidance. >>> >>> I agree that adding reg and clocks properties to existing bindings is an >>> ABI break. The sa8775p is a relatively older platform, and when the >>> interconnect provider driver was initially upstreamed, QoS configuration >>> support was not available in the framework. As a result, QoS was not >>> enabled at that time. >> >> >> That's irrelevant reason. Writing bindings since long time ask pretty >> clearly to describe hardware completely, regardless whether Linux >> supports this or not. >> >> It does not matter if you enable QoS or not. >> > I agree with you. Ideally, the bindings should have described the > hardware fully from the beginning. However, this was not done at the > time of initial upstreaming, and the driver was contributed by someone > from the community. I’m working now to improve the binding by adding the > missing pieces to support QoS configuration. Well, no. The driver was crontributed by: commit 3655a63f9661b1fff313d8795200ff420282a87b Author: Shazad Hussain Date: Wed Jan 18 15:08:25 2023 +0100 interconnect: qcom: add a driver for sa8775p That's definitely not 'someone from the community'. -- With best wishes Dmitry