From: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
To: Rob Herring <robh@kernel.org>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mailbox: qcom-ipcc: Add bindings for physical client ids
Date: Thu, 9 Oct 2025 14:48:44 +0800 [thread overview]
Message-ID: <fdca746b-e1b0-4610-ada1-6d9fd156c7c7@oss.qualcomm.com> (raw)
In-Reply-To: <20251002003432.GA2714683-robh@kernel.org>
On 10/2/2025 8:34 AM, Rob Herring wrote:
> On Mon, Sep 22, 2025 at 08:34:20PM -0700, Jingyi Wang wrote:
>> Physical client IDs instead of virtual client IDs are used for qcom new
>> platforms in the Inter Process Communication Controller (IPCC) driver
>> as virtual physical mapping logic is removed in HW. Add the bindings.
>>
>> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
>> ---
>> include/dt-bindings/mailbox/qcom-ipcc.h | 48 +++++++++++++++++++++++++++++++++
>> 1 file changed, 48 insertions(+)
>
> This looks incomplete. Where's the binding additions for the new h/w
> that uses these ids. This series looks more complete:
>
> https://lore.kernel.org/all/20250924183726.509202-3-sibi.sankar@oss.qualcomm.com
>
> Can QCom please coordinate your work so we're not getting the same thing
> a day apart.
>
> Rob
Hi Rob,
Sorry we thought all the platform use the same phy id at first, as different platform
has different IDs, maybe it is better to maintain it in different header files
like qcom-ipcc-kaanapali.h? Please let me know if you have disagreement for this.
Thanks,
Jingyi
prev parent reply other threads:[~2025-10-09 6:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 3:34 [PATCH] dt-bindings: mailbox: qcom-ipcc: Add bindings for physical client ids Jingyi Wang
2025-10-02 0:34 ` Rob Herring
2025-10-09 6:48 ` Jingyi Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdca746b-e1b0-4610-ada1-6d9fd156c7c7@oss.qualcomm.com \
--to=jingyi.wang@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox