Re: [PATCH v2 3/7] drm/msm: dpu: Consolidate atomic_check functions()

[Jeykumar Sankaran <jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>]

On 2018-09-12 06:54, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> dpu_plane_atomic_check() is a very thin wrapper around
> dpu_plane_sspp_atomic_check(). All it does is a NULL-check of 
> state->fb,
> which is already done by drm_atomic_helper_check_plane_state(). 
> Further,
> the helper sets state->visible = false when this is true. So remove
> dpu_plane_atomic_check() and just use dpu_plane_sspp_atomic_check()
> directly.
> 
> Changes in v2:
> - Fix spelling mistake in Subject (Jeykumar)
> 
> Reviewed-by: Jeykumar Sankaran <jsanka@codeaurora.org>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---

Reviewed-by: Jeykumar Sankaran <jsanka@codeaurora.org>

>  drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 15 ++-------------
>  1 file changed, 2 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> index 96e042b66cd7..2b1f61114e1c 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> @@ -1076,8 +1076,8 @@ static bool dpu_plane_validate_src(struct 
> drm_rect
> *src,
>  		drm_rect_equals(fb_rect, src);
>  }
> 
> -static int dpu_plane_sspp_atomic_check(struct drm_plane *plane,
> -		struct drm_plane_state *state)
> +static int dpu_plane_atomic_check(struct drm_plane *plane,
> +				  struct drm_plane_state *state)
>  {
>  	int ret = 0, min_scale;
>  	struct dpu_plane *pdpu = to_dpu_plane(plane);
> @@ -1156,17 +1156,6 @@ static int dpu_plane_sspp_atomic_check(struct
> drm_plane *plane,
>  	return ret;
>  }
> 
> -static int dpu_plane_atomic_check(struct drm_plane *plane,
> -		struct drm_plane_state *state)
> -{
> -	if (!state->fb)
> -		return 0;
> -
> -	DPU_DEBUG_PLANE(to_dpu_plane(plane), "\n");
> -
> -	return dpu_plane_sspp_atomic_check(plane, state);
> -}
> -
>  void dpu_plane_flush(struct drm_plane *plane)
>  {
>  	struct dpu_plane *pdpu;

-- 
Jeykumar S
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno