From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dolev Raviv" Subject: Re: [PATCH V4 09/17] scsi: ufs: manually add well known logical units Date: Tue, 23 Sep 2014 11:48:54 -0000 Message-ID: References: <1411457499-8074-1-git-send-email-draviv@codeaurora.org> <1411457499-8074-10-git-send-email-draviv@codeaurora.org> <20140923083532.GB28647@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:35240 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753830AbaIWLsy (ORCPT ); Tue, 23 Sep 2014 07:48:54 -0400 In-Reply-To: <20140923083532.GB28647@infradead.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org Cc: Dolev Raviv , james.bottomley@hansenpartnership.com, hch@infradead.org, linux-scsi@vger.kernel.org, linux-scsi-owner@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, Subhash Jadavani > None of the REPORT LUNS language makes sense as we're not using it. > > Can you respon the patch with a better description, and a little comment > in the code on why you're adding these wluns. ok. > > Also can I assume none of the later patches relies on their existance? In UFS power management commands such as SSU, are sent to "device w- lun". Leaving it out should only affect the ability to suspend the device. Other patches are not directly affected by it. > If you do you need to check the error return from scsi_add_device, if > not said comment should mention why it's fine to not actually find > any of these. > Will discus it further with Subhash. > Also if you do use one of them from kernel space later it might make > more sense to use __scsi_add_device and store a pointer to the > scsi_device instead of looking it up later. > I'll review all you suggestions with Subhash. -- QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation