From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FCBEC433F5 for ; Thu, 21 Oct 2021 22:25:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24E9361251 for ; Thu, 21 Oct 2021 22:25:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229935AbhJUW14 (ORCPT ); Thu, 21 Oct 2021 18:27:56 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:46409 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231750AbhJUW14 (ORCPT ); Thu, 21 Oct 2021 18:27:56 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1634855140; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=oy4Ke29RPvTBtTqqlrgVweNHxSdPx8fieD6oBcjg70c=; b=oWrpOHg4L9QSK1EF7VmnPDSVHF8br3xulGpRwVIRz5NrWpKamax/5hz7oXdM8/ILDWlXChmC /pSHqZ1nFunO0ai+acTUcPB1SAu60W8fTPv+PN2M/Px4/Zh6QX8pfhMMkLTKfrL6C9PZ2eyj oUoclO1GNnbR6EtkagPRtHofO7o= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 6171e8ce5ca800b6c1767fe6 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 21 Oct 2021 22:25:18 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6F07AC43619; Thu, 21 Oct 2021 22:25:18 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 98420C4338F; Thu, 21 Oct 2021 22:25:17 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 21 Oct 2021 15:25:17 -0700 From: abhinavk@codeaurora.org To: Dmitry Baryshkov Cc: Bjorn Andersson , Rob Clark , Sean Paul , Jonathan Marek , Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [Freedreno] [PATCH 03/11] drm/msm/dpu: drop pipe_name from struct dpu_plane In-Reply-To: <20210930140002.308628-4-dmitry.baryshkov@linaro.org> References: <20210930140002.308628-1-dmitry.baryshkov@linaro.org> <20210930140002.308628-4-dmitry.baryshkov@linaro.org> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-09-30 06:59, Dmitry Baryshkov wrote: > Use plane->name instead of artificial pipe_name. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > index 88d726133b8b..ef3737642b0c 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > @@ -115,7 +115,6 @@ struct dpu_plane { > struct dpu_csc_cfg *csc_ptr; > > const struct dpu_sspp_sub_blks *pipe_sblk; > - char pipe_name[DPU_NAME_SIZE]; > > /* debugfs related stuff */ > struct dentry *debugfs_root; > @@ -1429,7 +1428,7 @@ static int _dpu_plane_init_debugfs(struct > drm_plane *plane) > > /* create overall sub-directory for the pipe */ > pdpu->debugfs_root = > - debugfs_create_dir(pdpu->pipe_name, > + debugfs_create_dir(plane->name, > plane->dev->primary->debugfs_root); > > /* don't error check these */ > @@ -1660,12 +1659,9 @@ struct drm_plane *dpu_plane_init(struct > drm_device *dev, > /* success! finalize initialization */ > drm_plane_helper_add(plane, &dpu_plane_helper_funcs); > > - /* save user friendly pipe name for later */ > - snprintf(pdpu->pipe_name, DPU_NAME_SIZE, "plane%u", plane->base.id); > - > mutex_init(&pdpu->lock); > > - DPU_DEBUG("%s created for pipe:%u id:%u virtual:%u\n", > pdpu->pipe_name, > + DPU_DEBUG("%s created for pipe:%u id:%u virtual:%u\n", plane->name, > pipe, plane->base.id, master_plane_id); > return plane;