From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D36ECAAD8 for ; Tue, 20 Sep 2022 13:51:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230322AbiITNvi (ORCPT ); Tue, 20 Sep 2022 09:51:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231226AbiITNvY (ORCPT ); Tue, 20 Sep 2022 09:51:24 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDAA843E56 for ; Tue, 20 Sep 2022 06:51:21 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id cc5so4407262wrb.6 for ; Tue, 20 Sep 2022 06:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date; bh=ie45F/lkLLynh4wGP5XxIIavgNdgbFKnC44CCTp/NRI=; b=lrPNrEQr+xNLISBtmLHGMl4sny3vDZKH6tJ73KRXFF/z+OqE65D6MT2Vt6TNTsRyED IOUlazvaj2Xo7Hs5cw+aMa+Aj/mgfrLqbrW5Uyq9IDtXLL1TCYINRtzSF04dE2ZHmWAO 4uzFWz4db3ePQZCkEpEdGsay1RkFqpEmB3TC4V8YvX87thlihx8+4t34+3pYrzoHPHIW 9lveiAHp/OvMSw29Ez4F+Lf7L76p4fYUGLPtWQQ652Rx+tGSfX3FDHQT6QwEfs5uwtuq glcxO3xnQbBTgSYywgvYdfmE+JZTunzw3OrX8z+TohdF0uxXlV1WSFvXS8mpy/WTqM7u sKKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=ie45F/lkLLynh4wGP5XxIIavgNdgbFKnC44CCTp/NRI=; b=zok37anN1c+RRmGDJEKL86W47nCFCJf38YBRS6XT48fuTH7+8l/NlI9uJ9K3hw/U4o 923TxUxOqM7nhkxwQ3boH7HP05lPx5jawX978VBLYsbUrY4QVm3rrUUSBeGQSu3DqD2O rWg2/PzRCcEMObbnYn7fGtsE9opai2HLnwtqC14HKK6TNy9uv9u7wF27i9q+CneVPmcz L7gthZxqosj5lUpEOZ8aIM2p1NHoGSR6L4YcrzWPhTy/Au0Utpkh/aaCMCJn2bOuaLZF FwncESQaEh6Lmuc8ytd5gGLx87Jh2keLNDaYxv/H/XAZI7XWobE4zJF7GgtjxxJOrsl/ rRDQ== X-Gm-Message-State: ACrzQf2ZlDn8XUNvf250JGacSpMw2fMLZMGQ1hDC7TKXgpGEo484lK/O +DVkzje7N5EiPpfcYiTfOomXXA== X-Google-Smtp-Source: AMsMyM5/im8/35tKr1t1+wFKKnt4WVrkH/e+GlT1tr5K6kmneVuOMtgNWUvOuzQ+4lfcAARt5mV+mw== X-Received: by 2002:a05:6000:78b:b0:22a:da96:8ae6 with SMTP id bu11-20020a056000078b00b0022ada968ae6mr13830191wrb.232.1663681881322; Tue, 20 Sep 2022 06:51:21 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:7e10:f0f:43b2:9b5e? ([2a01:e0a:982:cbb0:7e10:f0f:43b2:9b5e]) by smtp.gmail.com with ESMTPSA id v9-20020a5d4b09000000b0022acb7195aesm74782wrq.33.2022.09.20.06.51.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 06:51:20 -0700 (PDT) Message-ID: Date: Tue, 20 Sep 2022 15:51:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 05/17] phy: qcom-qmp-pcie: drop init and exit wrappers Content-Language: en-US To: Johan Hovold , Vinod Koul Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220920073826.20811-1-johan+linaro@kernel.org> <20220920073826.20811-6-johan+linaro@kernel.org> From: Neil Armstrong Organization: Linaro In-Reply-To: <20220920073826.20811-6-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 20/09/2022 09:38, Johan Hovold wrote: > Drop the unnecessary PHY init and exit callback wrappers. > > Signed-off-by: Johan Hovold > --- > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 29 ++++-------------------- > 1 file changed, 4 insertions(+), 25 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > index d25f9215b86f..525097e3b041 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > @@ -1877,8 +1877,9 @@ static int qmp_pcie_serdes_init(struct qmp_phy *qphy) > return 0; > } > > -static int qmp_pcie_com_init(struct qmp_phy *qphy) > +static int qmp_pcie_init(struct phy *phy) > { > + struct qmp_phy *qphy = phy_get_drvdata(phy); > struct qcom_qmp *qmp = qphy->qmp; > const struct qmp_phy_cfg *cfg = qphy->cfg; > void __iomem *pcs = qphy->pcs; > @@ -1925,8 +1926,9 @@ static int qmp_pcie_com_init(struct qmp_phy *qphy) > return ret; > } > > -static int qmp_pcie_com_exit(struct qmp_phy *qphy) > +static int qmp_pcie_exit(struct phy *phy) > { > + struct qmp_phy *qphy = phy_get_drvdata(phy); > struct qcom_qmp *qmp = qphy->qmp; > const struct qmp_phy_cfg *cfg = qphy->cfg; > > @@ -1939,20 +1941,6 @@ static int qmp_pcie_com_exit(struct qmp_phy *qphy) > return 0; > } > > -static int qmp_pcie_init(struct phy *phy) > -{ > - struct qmp_phy *qphy = phy_get_drvdata(phy); > - struct qcom_qmp *qmp = qphy->qmp; > - int ret; > - dev_vdbg(qmp->dev, "Initializing QMP phy\n"); > - > - ret = qmp_pcie_com_init(qphy); > - if (ret) > - return ret; > - > - return 0; > -} > - > static int qmp_pcie_power_on(struct phy *phy) > { > struct qmp_phy *qphy = phy_get_drvdata(phy); > @@ -2060,15 +2048,6 @@ static int qmp_pcie_power_off(struct phy *phy) > return 0; > } > > -static int qmp_pcie_exit(struct phy *phy) > -{ > - struct qmp_phy *qphy = phy_get_drvdata(phy); > - > - qmp_pcie_com_exit(qphy); > - > - return 0; > -} > - > static int qmp_pcie_enable(struct phy *phy) > { > int ret; Reviewed-by: Neil Armstrong