From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Ameer Hamza <amhamza.mgc@gmail.com>,
robdclark@gmail.com, sean@poorly.run, quic_abhinavk@quicinc.com,
airlied@linux.ie, daniel@ffwll.ch
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/msm/dpu: removed logically dead code
Date: Fri, 3 Dec 2021 21:15:51 +0300 [thread overview]
Message-ID: <ffdf9007-d2cc-2437-684c-66c00bb0ceda@linaro.org> (raw)
In-Reply-To: <20211203161846.37720-1-amhamza.mgc@gmail.com>
On 03/12/2021 19:18, Ameer Hamza wrote:
> Fixed coverity warning by removing the dead code
>
> Addresses-Coverity: 1494147 ("Logically dead code")
>
> Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com>
While the patch is correct, remove the 'fail' part completely by moving
DPU_ERROR and return statement in place of corresponding goto statements.
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c
> index 185379b18572..75f0c0cee661 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c
> @@ -751,8 +751,6 @@ struct dpu_encoder_phys *dpu_encoder_phys_vid_init(
>
> fail:
> DPU_ERROR("failed to create encoder\n");
> - if (phys_enc)
> - dpu_encoder_phys_vid_destroy(phys_enc);
>
> return ERR_PTR(ret);
> }
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2021-12-03 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 16:18 [PATCH] drm/msm/dpu: removed logically dead code Ameer Hamza
2021-12-03 18:15 ` Dmitry Baryshkov [this message]
2021-12-03 19:32 ` [PATCH v2] " Ameer Hamza
2021-12-03 19:56 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffdf9007-d2cc-2437-684c-66c00bb0ceda@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@linux.ie \
--cc=amhamza.mgc@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox