From: Dima Zavin <dima@android.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Daniel Walker <dwalker@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
Daniel Walker <c_dwalke@quicinc.com>
Subject: Re: [PATCH 2/5] arm: msm: smd: use either package v3 or v4 not both
Date: Mon, 19 Apr 2010 22:52:35 -0700 [thread overview]
Message-ID: <j2o404ea8001004192252sbc1150act9088a86abbaf4c85@mail.gmail.com> (raw)
In-Reply-To: <20100420051854.GE2075@ucw.cz>
On Mon, Apr 19, 2010 at 10:18 PM, Pavel Machek <pavel@ucw.cz> wrote:
> On Mon 2010-04-19 11:03:06, Daniel Walker wrote:
>> From: Daniel Walker <c_dwalke@quicinc.com>
>>
>> This modifies SMD to use either the package v3 or package v4,
>> but not both. The current code tries to allocate as v4 on all
>> system which can produce a scary looking error message on boot up,
>>
>> smem_find(16, 40): wrong size 16424
>> smd_alloc_channel() cid=02 size=08192 'SMD_RPCCALL'
>>
>> With this error the code then falls back on the package v3 allocation
>> method. This method is inefficient because it causes a slow down
>> on some systems even when the allocation method can be determined
>> at compile time. It also causes a kernel size increase that effects
>> all system and is not needed.
>
> Well... it adds about 100 bytes to kernel text and produces
> unmeasurable slowdown.
I would think it would actually be very easily measurable, as you can
measure the amount of time spent doing a channel allocation and
failing. In any case, it is a good change, we don't need to try and
fail. That code hasn't been necessary for a long time.
>
>> --- a/arch/arm/mach-msm/Kconfig
>> +++ b/arch/arm/mach-msm/Kconfig
>> @@ -7,6 +7,7 @@ choice
>> config ARCH_MSM7X00A
>> bool "MSM7x00A / MSM7x01A"
>> select ARCH_MSM_ARM11
>> + select MSM_SMD_PKG3
>> select CPU_V6
>>
>> config ARCH_QSD8X50
>> @@ -325,6 +326,9 @@ config MSM_SERIAL_DEBUGGER_CONSOLE
>> Enables a console so that printk messages are displayed on
>> the debugger serial port as the occur.
>>
>> +config MSM_SMD_PKG3
>> + bool
>> +
>
> ...but I guess that as long as kconfig system gets it right
> automatically... its probably ok.
>
> ....well, will that prevent us from producing 'generic' kernel in
> future?
You really can't generate a generic kernel for msm7k and qsd8k anyway.
Too many architectural differences.
--Dima
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>
prev parent reply other threads:[~2010-04-20 5:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 18:03 [PATCH 2/5] arm: msm: smd: use either package v3 or v4 not both Daniel Walker
2010-04-19 18:29 ` Dima Zavin
2010-04-19 23:22 ` [PATCH] " Daniel Walker
2010-04-20 5:18 ` [PATCH 2/5] " Pavel Machek
2010-04-20 5:52 ` Dima Zavin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=j2o404ea8001004192252sbc1150act9088a86abbaf4c85@mail.gmail.com \
--to=dima@android.com \
--cc=c_dwalke@quicinc.com \
--cc=dwalker@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).