From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out.google.com ([216.239.44.51]:22814 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752913Ab0DTFwj convert rfc822-to-8bit (ORCPT ); Tue, 20 Apr 2010 01:52:39 -0400 Received: from wpaz24.hot.corp.google.com (wpaz24.hot.corp.google.com [172.24.198.88]) by smtp-out.google.com with ESMTP id o3K5qcur030648 for ; Mon, 19 Apr 2010 22:52:38 -0700 Received: from wyb28 (wyb28.prod.google.com [10.241.225.92]) by wpaz24.hot.corp.google.com with ESMTP id o3K5qafB030025 for ; Mon, 19 Apr 2010 22:52:36 -0700 Received: by wyb28 with SMTP id 28so569239wyb.24 for ; Mon, 19 Apr 2010 22:52:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20100420051854.GE2075@ucw.cz> References: <1271700189-8376-2-git-send-email-dwalker@codeaurora.org> <20100420051854.GE2075@ucw.cz> Date: Mon, 19 Apr 2010 22:52:35 -0700 Message-ID: Subject: Re: [PATCH 2/5] arm: msm: smd: use either package v3 or v4 not both From: Dima Zavin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Pavel Machek Cc: Daniel Walker , linux-arm-msm@vger.kernel.org, Daniel Walker On Mon, Apr 19, 2010 at 10:18 PM, Pavel Machek wrote: > On Mon 2010-04-19 11:03:06, Daniel Walker wrote: >> From: Daniel Walker >> >> This modifies SMD to use either the package v3 or package v4, >> but not both. The current code tries to allocate as v4 on all >> system which can produce a scary looking error message on boot up, >> >> smem_find(16, 40): wrong size 16424 >> smd_alloc_channel() cid=02 size=08192 'SMD_RPCCALL' >> >> With this error the code then falls back on the package v3 allocation >> method. This method is inefficient because it causes a slow down >> on some systems even when the allocation method can be determined >> at compile time. It also causes a kernel size increase that effects >> all system and is not needed. > > Well... it adds about 100 bytes to kernel text and produces > unmeasurable slowdown. I would think it would actually be very easily measurable, as you can measure the amount of time spent doing a channel allocation and failing. In any case, it is a good change, we don't need to try and fail. That code hasn't been necessary for a long time. > >> --- a/arch/arm/mach-msm/Kconfig >> +++ b/arch/arm/mach-msm/Kconfig >> @@ -7,6 +7,7 @@ choice >>  config ARCH_MSM7X00A >>       bool "MSM7x00A / MSM7x01A" >>       select ARCH_MSM_ARM11 >> +     select MSM_SMD_PKG3 >>       select CPU_V6 >> >>  config ARCH_QSD8X50 >> @@ -325,6 +326,9 @@ config MSM_SERIAL_DEBUGGER_CONSOLE >>         Enables a console so that printk messages are displayed on >>         the debugger serial port as the occur. >> >> +config MSM_SMD_PKG3 >> +     bool >> + > > ...but I guess that as long as kconfig system gets it right > automatically... its probably ok. > > ....well, will that prevent us from producing 'generic' kernel in > future? You really can't generate a generic kernel for msm7k and qsd8k anyway. Too many architectural differences. --Dima >                                                                        Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html >