From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f172.google.com ([209.85.211.172]:62178 "EHLO mail-yw0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932154Ab0CaVVS convert rfc822-to-8bit (ORCPT ); Wed, 31 Mar 2010 17:21:18 -0400 Received: by ywh2 with SMTP id 2so283576ywh.33 for ; Wed, 31 Mar 2010 14:21:17 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1270044182.2025.0.camel@m0nster> References: <1269990717-2969-1-git-send-email-dwalker@codeaurora.org> <0D753D10438DA54287A00B027084269763691C346E@AUSP01VMBX24.collaborationhost.net> <1270044182.2025.0.camel@m0nster> Date: Wed, 31 Mar 2010 14:21:16 -0700 Message-ID: Subject: Re: [PATCH 1/4] arm: msm: gpio support From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Daniel Walker Cc: H Hartley Sweeten , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" 2010/3/31 Daniel Walker : > On Tue, 2010-03-30 at 18:14 -0700, Arve Hjønnevåg wrote: >> On Tue, Mar 30, 2010 at 4:58 PM, H Hartley Sweeten >> wrote: >> > On Tuesday, March 30, 2010 4:12 PM, Daniel Walker wrote: >> >> From: Daniel Walker >> ... >> >> + >> >> +static void msm_gpio_irq_ack(unsigned int irq) >> >> +{ >> >> +     unsigned long irq_flags; >> >> +     struct msm_gpio_chip *msm_chip = get_irq_chip_data(irq); >> >> +     unsigned b; >> >> + >> >> +     spin_lock_irqsave(&msm_chip->lock, irq_flags); >> >> + >> >> +     b = 1U << (irq - FIRST_GPIO_IRQ - msm_chip->chip.base); >> > >> > Urk... That's a bit confusing... >> > >> > You might want to make this a macro or an inline function with some kind >> > of comment. >> > >> >> On a related note, why did you inline msm_gpio_clear_detect_status? It >> is used from two other functions. >> > > You mean other places in the Android tree? No, you copied it three times in this file. -- Arve Hjønnevåg