[PATCH v4 0/2] arm64: dts: qcom: sc7280: Add property for sc7280

[PATCH v4 0/2] arm64: dts: qcom: sc7280: Add property for sc7280

[Ling Xu]

This patch series add memory region, nsessions and dma-coherent property
for sc7280.
Patch [v3]: https://lore.kernel.org/linux-arm-msm/20250626092952.847393-1-quic_lxu5@quicinc.com/

Changes in v4:
  - update commit message.
Changes in v3:
  - Dropped dma-coherent change.
  - Modified indentation.
Changes in v2:
  - Added compatible.

Ling Xu (2):
  arm64: dts: qcom: sc7280: Add memory region for audiopd
  arm64: dts: qcom: sc7280: Add nsessions property for adsp

 arch/arm64/boot/dts/qcom/sc7280.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

-- 
2.34.1

[PATCH v4 1/2] arm64: dts: qcom: sc7280: Add memory region for audiopd

[Ling Xu]

Add reserved memory region and VMIDs for audio PD dynamic loading and
remote heap memory requirements. This is required in use cases such as
audio compressed offload. For example, playback of compressed formats
like MP3 need audio PD support.

Co-developed-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Signed-off-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 64a2abd30100..b1def5611764 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -189,6 +189,14 @@ rmtfs_mem: rmtfs@9c900000 {
 			qcom,client-id = <1>;
 			qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>;
 		};
+
+		adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap {
+			compatible = "shared-dma-pool";
+			size = <0x0 0x800000>;
+			alignment = <0x0 0x100000>;
+			alloc-ranges = <0x0 0x80000000 0x0 0x40000000>;
+			no-map;
+		};
 	};
 
 	cpus {
@@ -3907,6 +3915,9 @@ fastrpc {
 					qcom,glink-channels = "fastrpcglink-apps-dsp";
 					label = "adsp";
 					qcom,non-secure-domain;
+					memory-region = <&adsp_rpc_remote_heap_mem>;
+					qcom,vmids = <QCOM_SCM_VMID_LPASS>,
+						     <QCOM_SCM_VMID_ADSP_HEAP>;
 					#address-cells = <1>;
 					#size-cells = <0>;
 
-- 
2.34.1

[PATCH v4 2/2] arm64: dts: qcom: sc7280: Add nsessions property for adsp

[Ling Xu]

Add nsessions property for adsp context bank to make sessions
available for ADSP offload.

Co-developed-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Signed-off-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index b1def5611764..5a1eacb6685e 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -3939,6 +3939,7 @@ compute-cb@5 {
 						compatible = "qcom,fastrpc-compute-cb";
 						reg = <5>;
 						iommus = <&apps_smmu 0x1805 0x0>;
+						qcom,nsessions = <5>;
 						dma-coherent;
 					};
 				};
-- 
2.34.1

Re: [PATCH v4 0/2] arm64: dts: qcom: sc7280: Add property for sc7280

[Ling Xu]

在 7/1/2025 4:49 PM, Ling Xu 写道:
> This patch series add memory region, nsessions and dma-coherent property
> for sc7280.
> Patch [v3]: https://lore.kernel.org/linux-arm-msm/20250626092952.847393-1-quic_lxu5@quicinc.com/
> 
> Changes in v4:
>   - update commit message.
> Changes in v3:
>   - Dropped dma-coherent change.
>   - Modified indentation.
> Changes in v2:
>   - Added compatible.
> 
> Ling Xu (2):
>   arm64: dts: qcom: sc7280: Add memory region for audiopd
>   arm64: dts: qcom: sc7280: Add nsessions property for adsp
> 
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 

Hi, this patch has been sent out for a long time, but it has not been reviewed yet.
Could you please kindly review this patch?
-- 
Thx and BRs,
Ling Xu

Re: [PATCH v4 2/2] arm64: dts: qcom: sc7280: Add nsessions property for adsp

[Dmitry Baryshkov]

On Tue, Jul 01, 2025 at 02:19:05PM +0530, Ling Xu wrote:
> Add nsessions property for adsp context bank to make sessions
> available for ADSP offload.

- Describe the problem, describe _how_ the commit solves it.

> 
> Co-developed-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
> Signed-off-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index b1def5611764..5a1eacb6685e 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -3939,6 +3939,7 @@ compute-cb@5 {
>  						compatible = "qcom,fastrpc-compute-cb";
>  						reg = <5>;
>  						iommus = <&apps_smmu 0x1805 0x0>;
> +						qcom,nsessions = <5>;
>  						dma-coherent;
>  					};
>  				};
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry

Re: [PATCH v4 1/2] arm64: dts: qcom: sc7280: Add memory region for audiopd

[Dmitry Baryshkov]

On Tue, Jul 01, 2025 at 02:19:04PM +0530, Ling Xu wrote:
> Add reserved memory region and VMIDs for audio PD dynamic loading and
> remote heap memory requirements. This is required in use cases such as
> audio compressed offload. For example, playback of compressed formats
> like MP3 need audio PD support.
> 
> Co-developed-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
> Signed-off-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 64a2abd30100..b1def5611764 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -189,6 +189,14 @@ rmtfs_mem: rmtfs@9c900000 {
>  			qcom,client-id = <1>;
>  			qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>;
>  		};
> +
> +		adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap {
> +			compatible = "shared-dma-pool";
> +			size = <0x0 0x800000>;
> +			alignment = <0x0 0x100000>;
> +			alloc-ranges = <0x0 0x80000000 0x0 0x40000000>;
> +			no-map;
> +		};
>  	};
>  
>  	cpus {
> @@ -3907,6 +3915,9 @@ fastrpc {
>  					qcom,glink-channels = "fastrpcglink-apps-dsp";
>  					label = "adsp";
>  					qcom,non-secure-domain;
> +					memory-region = <&adsp_rpc_remote_heap_mem>;
> +					qcom,vmids = <QCOM_SCM_VMID_LPASS>,
> +						     <QCOM_SCM_VMID_ADSP_HEAP>;

We should stop defining VMIDs in the DT and use label to determine them
instead.

>  					#address-cells = <1>;
>  					#size-cells = <0>;
>  
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry

Re: [PATCH v4 2/2] arm64: dts: qcom: sc7280: Add nsessions property for adsp

[Konrad Dybcio]

On 8/11/25 12:42 PM, Dmitry Baryshkov wrote:
> On Tue, Jul 01, 2025 at 02:19:05PM +0530, Ling Xu wrote:
>> Add nsessions property for adsp context bank to make sessions
>> available for ADSP offload.
> 
> - Describe the problem, describe _how_ the commit solves it.

This is pure software configuration, the only real limitation is that
the total amount of sessions per channel can't exceed 14 (because our
driver says so? I have conflicting information where this number comes
from), but no more than 5 is recommended for optimal performance

I'd rather waste a couple of bytes and pre-alloc the maximum amount on
every channel, so that if someone decides they want to use the DSPs ever
so slightly differently, they don't have to run around changing the DT..

Konrad