From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70C3419E971 for ; Mon, 14 Jul 2025 22:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752532095; cv=none; b=KFcrHUbYiVALzJ4aubIJPUAc7ayc1Mx5vXBFc8doKqfkSpMdSAPUjfFFdFor9qIh2uyk7ZuZOwDJKwaFqOyVqr8TumOQdozAeSmlH4zn3+2fMgH0xsTuGjQo+h6vEodlwQcMrb4SHb43vY8sIcPu2Oc0QVgif6pbuIi2svetAx4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752532095; c=relaxed/simple; bh=bqhSuK8Fneo7nRioVo3qzSPoFYLUkfRiuOuKAj8ljQk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LGFIDsAR3ji4d5VySsRGNfoHimwIqxFRSPlpyRTeoXuIwnTAcwhBUhCtCC+AAl7BeXzNJlz3sAKnjjYVYqNG0belVFhn0Snda1UTEvMhssOIYxYTETOLk5HQ5ptt/lPh1yaA6NhQQ1LscQcLn6m1pQt1t4wM1qY9DsCBGZ15YC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mAIJedhU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mAIJedhU" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56EGIleg008667 for ; Mon, 14 Jul 2025 22:28:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=g58Cwy9wjp0YmHwQ5wI0oyKa mpOyzB7ETzY1FZOvoHQ=; b=mAIJedhUanJ7jP4mKdvJ6tRPoyd+7plz2X6m9FbV Zvhr2F1k9wtyF7hxTZgtRf1/0wpipMaTjmq9HwzAbzetO/xoNaNJMlhQo+kZNjZS XyXIY6tEEBBflXcE48EiI9I80vHVn+tAuao51E658I4vlp0RveJN85MHvtdEU/7G 4heeLbD94Xovb+zTwgmNZF0PBkDpdjFO+JV7e4KFuiy39CFgGzlUrgXjmhc1JgF7 oW0NwgUUzekoS2SPs3W4j9bD08v44m8Cq9jp+r3++vh9ya4GXmdaK0wDZ/BryP6X mSURlvxegggCAKZdLXbilUSadw02PS7o1z9AOS/r4Xb0+Q== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47w58ygurg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 14 Jul 2025 22:28:12 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7e271738501so359147585a.1 for ; Mon, 14 Jul 2025 15:28:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752532091; x=1753136891; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g58Cwy9wjp0YmHwQ5wI0oyKampOyzB7ETzY1FZOvoHQ=; b=e/lwHtaC3S73Zunnz4saZXUMLbEw5AlHssH9Fn9ua+1BNWTna1qs+GHUN6rzuy8vTG nEynzlvyuTI7C+WBy3MzWyIVxBD7gDomox6+wIf+hABgPZh8PAE+x8M/tVCCfVFVyAK3 9Z9sNaFoHm3A3nF5yghZB5m6Zzu3NsMT/J1HyugHDRkWeITBiNouk+Rb8ORsUUzDqPFb e120xHF8BRzlN4SbRR10sk9M30vvDc9vxBWjY19Y9fiejmOEMlljK+jnhXIuBwXgxMaF YzB4hk823s55krtn1L3zcY2OWcyz5W85s8pjcZpPSVvFXf8XtNKx3Y1S0dvBB3kI5oXP q7GQ== X-Forwarded-Encrypted: i=1; AJvYcCUMB0qkz817kBOB/bqKHJ4i0KC0XtUO5VoY/o/HlZ8/n6m7TJPW6GCWGDEey/fYDF5k7OKBypECUAEocvb4@vger.kernel.org X-Gm-Message-State: AOJu0YzDfWFNhU7Aut4rOMpN2reuF6ymIlf5OPCek2b+n8PbPJbYr8Bo K/eOkCJqd4bT48X9b86sFACnHcOv45cOXbO45V2NWVfMIJQRr36mNeLqYznQLbF3VW2n4esSzN7 ofXTxPd6NPM9YM4g+pQwS7aojkvIWmfgUNCnpFzVpTueeoij8GPXBnl9icEZbFrHV+Eek X-Gm-Gg: ASbGnctASoVnL7fuzwh5uSDfygkcoFJqEJ4bcCKor/A05PWoVuRG/MwA9P2TEcfB4vs dC4WtgmVTGhDYK8EkigfWrpuCtuOTWe2IXwkY5h/j7KcoyTYWCoe0n/MQA8hXHrBKVelHbw6jND vY5Fdbt1adPj/gDJA/ahOGmxxgshdMgIcDXA0FlRycrW7TFnfjAX1/L9VcbrLEPt2BvNOyZm1Te lYsY5kgy9civRY4s2MuV+6HVRyPZut1hAvAJDpG/H92lFzz5bSS0zNIoLnNhlhelkuA7+uTRsJG Eol0gOD/p7GwHVwxovHBrv67qg/4b5g5A+h+sujSBnydBbT5aoT4j8FIj+TKWFOwx4sGhmIM6lr jsSLnOhQQREfND802AxttDCOrJ9OMweqrvkhQTtvDb3Dm4q+h7lRM X-Received: by 2002:a05:620a:318f:b0:7da:e6e:dac1 with SMTP id af79cd13be357-7dded000eb0mr1982782285a.58.1752532091265; Mon, 14 Jul 2025 15:28:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBbqen6Ycp/DBPIss3IXszYn/5lvf6AcTyj9CEOFH1Zo5pXcdZ/lkHLybnpi1M0aIYwXscAQ== X-Received: by 2002:a05:620a:318f:b0:7da:e6e:dac1 with SMTP id af79cd13be357-7dded000eb0mr1982776885a.58.1752532090674; Mon, 14 Jul 2025 15:28:10 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55943b72f68sm2093423e87.203.2025.07.14.15.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 15:28:09 -0700 (PDT) Date: Tue, 15 Jul 2025 01:28:06 +0300 From: Dmitry Baryshkov To: Jessica Zhang Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Abhinav Kumar Subject: Re: [PATCH 04/19] drm/msm/dp: replace ST_DISPLAY_OFF with power_on in msm_dp_hpd_unplug_handle() Message-ID: References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> <20250711-hpd-refactor-v1-4-33cbac823f34@oss.qualcomm.com> <6883f346-452a-44b1-b670-3bd514f57b08@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6883f346-452a-44b1-b670-3bd514f57b08@oss.qualcomm.com> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE0MDE1NiBTYWx0ZWRfX39PM8CWfzUXq c2x+TGIWuhtQuFfFlZXYht2iJ3jYOWNiNfnGk3qo7EMjV+CZut4Wm1xdqmPGopNpsVvSgXjid9t nRClvdrBkzTcu34JJCn9npzZtgeenY/uccGmSTi3pIBUtuOYvzCLa3Wt8ZZr+cUENokvVKwKJAr 4xIiAmu4OldM9lC8EdEsVDSwXlHXuH2c7Hhd95duMxd95kAjFjjRKqYgJkrzjHG6P42FyrevJ7F D+IMVnpGCMAunmP4nofHnu8pIVmajHMJz6H95WOIonvrYcxOdnpj+tLPNOHB4i4KOnlFFiIPAJ+ ZdK8zuc9e0/LMMVBmX+Tv+AuMdJfxxI0hDZNfHR+hnB1Hso25G+OYnXIPQHtFSLXx98zN2w4V/j fZOSnFLeei1tev9iWse6QIjkz2fumH0hDaSfCFEX38JEaAg3bsReqn/eu931yaSjF3DWq09S X-Proofpoint-GUID: pIbVUaR7hOgewpekeHmlEFniGq-dPXLg X-Proofpoint-ORIG-GUID: pIbVUaR7hOgewpekeHmlEFniGq-dPXLg X-Authority-Analysis: v=2.4 cv=Or9Pyz/t c=1 sm=1 tr=0 ts=6875847c cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=Wb1JkmetP80A:10 a=e5mUnYsNAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=V1oTyKxzMZC_ZlTkUykA:9 a=CjuIK1q_8ugA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=Vxmtnl_E_bksehYqCbjh:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-14_02,2025-07-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 adultscore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=694 bulkscore=0 impostorscore=0 malwarescore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507140156 On Mon, Jul 14, 2025 at 01:38:55PM -0700, Jessica Zhang wrote: > > > On 7/14/2025 5:27 AM, Dmitry Baryshkov wrote: > > On Fri, Jul 11, 2025 at 05:58:09PM -0700, Jessica Zhang wrote: > > > From: Abhinav Kumar > > > > > > msm_dp_hpd_unplug_handle() checks if the display was already disabled and > > > if so does not transition to ST_DISCONNECT_PENDING state and goes directly > > > to ST_DISCONNECTED. The same result can be achieved with the !power_on > > > check. > > > > > > Replace ST_DISPLAY_OFF with !power_on to achieve the same outcome. > > > > > > Signed-off-by: Abhinav Kumar > > > Signed-off-by: Jessica Zhang > > > --- > > > Note: Taken from https://patchwork.freedesktop.org/series/142010/ > > > --- > > > drivers/gpu/drm/msm/dp/dp_display.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Please squash all state-related patches into a single one. It would make > > it easier to review and more logical. > > Hi Dmitry, > > Ack -- I'd wanted to keep all the patches small, but I can squash patches > 4-16 into 1 patch if that makes it easier for you. I think it's easier this way: we get rid of the HPD state machine and use flags all over the place. -- With best wishes Dmitry