[PATCH v1 0/2] Add Meta (Facebook) Yosemite5 BMC (AST2600)

[PATCH v1 0/2] Add Meta (Facebook) Yosemite5 BMC (AST2600)

[Kevin Tung]

Summary:
Add device tree for the Meta (Facebook) Yosemite5 compute node,
based on the AST2600 BMC.

The Yosemite5 platform provides monitoring of voltages, power,
temperatures, and other critical parameters across the motherboard,
CXL board, E1.S expansion board, and NIC components. The BMC also
logs relevant events and performs appropriate system actions in
response to abnormal conditions.

Kevin Tung (2):
  dt-bindings: arm: aspeed: add Meta Yosemite5 board
  ARM: dts: aspeed: yosemite5: Add Meta Yosemite5 BMC

 .../bindings/arm/aspeed/aspeed.yaml           |    1 +
 .../aspeed/aspeed-bmc-facebook-yosemite5.dts  | 1063 +++++++++++++++++
 2 files changed, 1064 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts

-- 
2.47.1

Re: [PATCH v1 0/2] Add Meta (Facebook) Yosemite5 BMC (AST2600)

[Andrew Lunn]

On Wed, Sep 17, 2025 at 03:48:08PM +0800, Kevin Tung wrote:
> Summary:
> Add device tree for the Meta (Facebook) Yosemite5 compute node,
> based on the AST2600 BMC.
> 
> The Yosemite5 platform provides monitoring of voltages, power,
> temperatures, and other critical parameters across the motherboard,
> CXL board, E1.S expansion board, and NIC components. The BMC also
> logs relevant events and performs appropriate system actions in
> response to abnormal conditions.
> 
> Kevin Tung (2):
>   dt-bindings: arm: aspeed: add Meta Yosemite5 board
>   ARM: dts: aspeed: yosemite5: Add Meta Yosemite5 BMC

The threading between your patches are broken? How did you send them?
git send-email? b4 send?

	Andrew

Re: [PATCH v1 0/2] Add Meta (Facebook) Yosemite5 BMC (AST2600)

[Kevin Tung]

On Wed, Sep 17, 2025 at 11:12 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Wed, Sep 17, 2025 at 03:48:08PM +0800, Kevin Tung wrote:
> > Summary:
> > Add device tree for the Meta (Facebook) Yosemite5 compute node,
> > based on the AST2600 BMC.
> >
> > The Yosemite5 platform provides monitoring of voltages, power,
> > temperatures, and other critical parameters across the motherboard,
> > CXL board, E1.S expansion board, and NIC components. The BMC also
> > logs relevant events and performs appropriate system actions in
> > response to abnormal conditions.
> >
> > Kevin Tung (2):
> >   dt-bindings: arm: aspeed: add Meta Yosemite5 board
> >   ARM: dts: aspeed: yosemite5: Add Meta Yosemite5 BMC
>
> The threading between your patches are broken? How did you send them?
> git send-email? b4 send?

Yes, the threading is broken. I initially used git send-email, but for
some reason, only the cover letter was sent. I then sent the remaining
dt-bindings and DTS patches separately as a follow-up.
>
>         Andrew

Re: [PATCH v1 0/2] Add Meta (Facebook) Yosemite5 BMC (AST2600)

[Andrew Jeffery]

On Thu, 2025-09-18 at 10:21 +0800, Kevin Tung wrote:
> On Wed, Sep 17, 2025 at 11:12 PM Andrew Lunn <andrew@lunn.ch> wrote:
> > 
> > On Wed, Sep 17, 2025 at 03:48:08PM +0800, Kevin Tung wrote:
> > > Summary:
> > > Add device tree for the Meta (Facebook) Yosemite5 compute node,
> > > based on the AST2600 BMC.
> > > 
> > > The Yosemite5 platform provides monitoring of voltages, power,
> > > temperatures, and other critical parameters across the motherboard,
> > > CXL board, E1.S expansion board, and NIC components. The BMC also
> > > logs relevant events and performs appropriate system actions in
> > > response to abnormal conditions.
> > > 
> > > Kevin Tung (2):
> > >   dt-bindings: arm: aspeed: add Meta Yosemite5 board
> > >   ARM: dts: aspeed: yosemite5: Add Meta Yosemite5 BMC
> > 
> > The threading between your patches are broken? How did you send them?
> > git send-email? b4 send?
> 
> Yes, the threading is broken. I initially used git send-email, but for
> some reason, only the cover letter was sent. I then sent the remaining
> dt-bindings and DTS patches separately as a follow-up.

I recommend using b4, it helps blunt some of the sharp edges of git-
send-email.

https://b4.docs.kernel.org/en/latest/

Can you please send v2 of the series so that it's properly threaded,
after applying tags you've collected for the involved patches, and
checking your work with `make CHECK_DTBS=y aspeed/aspeed-bmc-facebook-
yosemite5.dtb`?

Andrew

Re: [PATCH v1 0/2] Add Meta (Facebook) Yosemite5 BMC (AST2600)

[Kevin Tung]

On Mon, Sep 22, 2025 at 10:47 AM Andrew Jeffery
<andrew@codeconstruct.com.au> wrote:
>
> On Thu, 2025-09-18 at 10:21 +0800, Kevin Tung wrote:
> > On Wed, Sep 17, 2025 at 11:12 PM Andrew Lunn <andrew@lunn.ch> wrote:
> > >
> > > On Wed, Sep 17, 2025 at 03:48:08PM +0800, Kevin Tung wrote:
> > > > Summary:
> > > > Add device tree for the Meta (Facebook) Yosemite5 compute node,
> > > > based on the AST2600 BMC.
> > > >
> > > > The Yosemite5 platform provides monitoring of voltages, power,
> > > > temperatures, and other critical parameters across the motherboard,
> > > > CXL board, E1.S expansion board, and NIC components. The BMC also
> > > > logs relevant events and performs appropriate system actions in
> > > > response to abnormal conditions.
> > > >
> > > > Kevin Tung (2):
> > > >   dt-bindings: arm: aspeed: add Meta Yosemite5 board
> > > >   ARM: dts: aspeed: yosemite5: Add Meta Yosemite5 BMC
> > >
> > > The threading between your patches are broken? How did you send them?
> > > git send-email? b4 send?
> >
> > Yes, the threading is broken. I initially used git send-email, but for
> > some reason, only the cover letter was sent. I then sent the remaining
> > dt-bindings and DTS patches separately as a follow-up.
>
> I recommend using b4, it helps blunt some of the sharp edges of git-
> send-email.
>
> https://b4.docs.kernel.org/en/latest/
>
> Can you please send v2 of the series so that it's properly threaded,
> after applying tags you've collected for the involved patches, and
> checking your work with `make CHECK_DTBS=y aspeed/aspeed-bmc-facebook-
> yosemite5.dtb`?
>
> Andrew

Sure! I have sent v2 of the series using b4, and the patches are now
properly threaded.
I also checked the work with `make CHECK_DTBS=y
aspeed/aspeed-bmc-facebook- yosemite5.dtb`,
and the warnings that appear are not related to these patches.

Kevin

Re: [PATCH v1 0/2] Add Meta (Facebook) Yosemite5 BMC (AST2600)

[Rob Herring]

On Wed, Sep 24, 2025 at 8:05 AM Kevin Tung <kevin.tung.openbmc@gmail.com> wrote:
>
> On Mon, Sep 22, 2025 at 10:47 AM Andrew Jeffery
> <andrew@codeconstruct.com.au> wrote:
> >
> > On Thu, 2025-09-18 at 10:21 +0800, Kevin Tung wrote:
> > > On Wed, Sep 17, 2025 at 11:12 PM Andrew Lunn <andrew@lunn.ch> wrote:
> > > >
> > > > On Wed, Sep 17, 2025 at 03:48:08PM +0800, Kevin Tung wrote:
> > > > > Summary:
> > > > > Add device tree for the Meta (Facebook) Yosemite5 compute node,
> > > > > based on the AST2600 BMC.
> > > > >
> > > > > The Yosemite5 platform provides monitoring of voltages, power,
> > > > > temperatures, and other critical parameters across the motherboard,
> > > > > CXL board, E1.S expansion board, and NIC components. The BMC also
> > > > > logs relevant events and performs appropriate system actions in
> > > > > response to abnormal conditions.
> > > > >
> > > > > Kevin Tung (2):
> > > > >   dt-bindings: arm: aspeed: add Meta Yosemite5 board
> > > > >   ARM: dts: aspeed: yosemite5: Add Meta Yosemite5 BMC
> > > >
> > > > The threading between your patches are broken? How did you send them?
> > > > git send-email? b4 send?
> > >
> > > Yes, the threading is broken. I initially used git send-email, but for
> > > some reason, only the cover letter was sent. I then sent the remaining
> > > dt-bindings and DTS patches separately as a follow-up.
> >
> > I recommend using b4, it helps blunt some of the sharp edges of git-
> > send-email.
> >
> > https://b4.docs.kernel.org/en/latest/
> >
> > Can you please send v2 of the series so that it's properly threaded,
> > after applying tags you've collected for the involved patches, and
> > checking your work with `make CHECK_DTBS=y aspeed/aspeed-bmc-facebook-
> > yosemite5.dtb`?
> >
> > Andrew
>
> Sure! I have sent v2 of the series using b4, and the patches are now
> properly threaded.
> I also checked the work with `make CHECK_DTBS=y
> aspeed/aspeed-bmc-facebook- yosemite5.dtb`,
> and the warnings that appear are not related to these patches.

Um, they are related because they are warnings for *your* platform.
You don't care that there are warnings for your platform?

Rob

Re: [PATCH v1 0/2] Add Meta (Facebook) Yosemite5 BMC (AST2600)

[Andrew Jeffery]

Hi Kevin,

On Wed, 2025-09-24 at 08:34 -0500, Rob Herring wrote:
> On Wed, Sep 24, 2025 at 8:05 AM Kevin Tung <kevin.tung.openbmc@gmail.com> wrote:
> > I also checked the work with `make CHECK_DTBS=y
> > aspeed/aspeed-bmc-facebook- yosemite5.dtb`,
> > and the warnings that appear are not related to these patches.
> 
> Um, they are related because they are warnings for *your* platform.
> You don't care that there are warnings for your platform?

Which is to say, by contributing a DTS that relies on the ASPEED DTSIs
you're now part of the community of people interested in maintaining
support for ASPEED SoCs in the kernel, and it will be appreciated if
you could help improve what we have.

If you could pick a warning or two from the DTSIs and contribute
changes to address them that'd be great, as this improves the situation
for everyone.

Andrew

Re: [PATCH v1 0/2] Add Meta (Facebook) Yosemite5 BMC (AST2600)

[Kevin Tung]

On Thu, Sep 25, 2025 at 8:16 AM Andrew Jeffery
<andrew@codeconstruct.com.au> wrote:
>
> Hi Kevin,
>
> On Wed, 2025-09-24 at 08:34 -0500, Rob Herring wrote:
> > On Wed, Sep 24, 2025 at 8:05 AM Kevin Tung <kevin.tung.openbmc@gmail.com> wrote:
> > > I also checked the work with `make CHECK_DTBS=y
> > > aspeed/aspeed-bmc-facebook- yosemite5.dtb`,
> > > and the warnings that appear are not related to these patches.
> >
> > Um, they are related because they are warnings for *your* platform.
> > You don't care that there are warnings for your platform?
>
> Which is to say, by contributing a DTS that relies on the ASPEED DTSIs
> you're now part of the community of people interested in maintaining
> support for ASPEED SoCs in the kernel, and it will be appreciated if
> you could help improve what we have.
>
> If you could pick a warning or two from the DTSIs and contribute
> changes to address them that'd be great, as this improves the situation
> for everyone.
>
> Andrew

Sure, I will look into contributing a patch to address some ASPEED
DTSI warnings and improve the overall situation.