linux-aspeed.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Eddie James <eajames@linux.ibm.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@codeconstruct.com.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Ninad Palsule <ninad@linux.ibm.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-fsi@lists.ozlabs.org
Subject: Re: [PATCH 1/6] ARM: dts: aspeed: Drop "no-gpio-delays"
Date: Fri, 1 Aug 2025 09:56:50 -0500	[thread overview]
Message-ID: <0dbd00c1-7b47-4e6e-a8bc-5dd0b5d7e539@linux.ibm.com> (raw)
In-Reply-To: <20250731-dt-fsi-cleanups-v1-1-e7b695a29fc3@kernel.org>


On 7/31/25 17:12, Rob Herring (Arm) wrote:
> The "no-gpios-delays" property only applies to the "fsi-master-gpio"
> binding and not the "aspeed,ast2[45]00-cf-fsi-master" binding. It
> doesn't really make sense either as the timing is controlled by the
> offloaded firmware.


Thanks for the series Rob. It's fine with me if you take the bindings 
(we're not using the FSI tree now, Grek just merges stuff as needed)

Acked-by: Eddie James <eajames@linux.ibm.com>


>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>   arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts | 1 -
>   arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts      | 1 -
>   arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts     | 1 -
>   3 files changed, 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> index 78a5656ef75d..f42254ba6aeb 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> @@ -57,7 +57,6 @@ fsi: gpio-fsi {
>   		compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
>   		#address-cells = <2>;
>   		#size-cells = <0>;
> -		no-gpio-delays;
>   
>   		memory-region = <&coldfire_memory>;
>   		aspeed,sram = <&sram>;
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> index b1d0ff85d397..e5b8d07e7622 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> @@ -80,7 +80,6 @@ fsi: gpio-fsi {
>   		compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
>   		#address-cells = <2>;
>   		#size-cells = <0>;
> -		no-gpio-delays;
>   
>   		memory-region = <&coldfire_memory>;
>   		aspeed,sram = <&sram>;
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> index 24df24ad9c80..2180fa9b6f24 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> @@ -71,7 +71,6 @@ fsi: gpio-fsi {
>   		compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
>   		#address-cells = <2>;
>   		#size-cells = <0>;
> -		no-gpio-delays;
>   
>   		memory-region = <&coldfire_memory>;
>   		aspeed,sram = <&sram>;
>


  reply	other threads:[~2025-08-01 14:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31 22:12 [PATCH 0/6] ASpeed FSI DT clean-ups Rob Herring (Arm)
2025-07-31 22:12 ` [PATCH 1/6] ARM: dts: aspeed: Drop "no-gpio-delays" Rob Herring (Arm)
2025-08-01 14:56   ` Eddie James [this message]
2025-07-31 22:12 ` [PATCH 2/6] ARM: dts: aspeed: Drop "fsi-master" compatibles Rob Herring (Arm)
2025-08-01 14:57   ` Eddie James
2025-07-31 22:12 ` [PATCH 3/6] ARM: dts: aspeed: Add missing "ibm,spi-fsi" compatibles Rob Herring (Arm)
2025-08-01 14:58   ` Eddie James
2025-07-31 22:12 ` [PATCH 4/6] MAINTAINERS: Add FSI bindings to FSI subsystem entry Rob Herring (Arm)
2025-08-01 14:59   ` Eddie James
2025-07-31 22:12 ` [PATCH 5/6] dt-bindings: fsi: Convert fsi-master-gpio to DT schema Rob Herring (Arm)
2025-08-01 15:01   ` Eddie James
2025-07-31 22:12 ` [PATCH 6/6] dt-bindings: fsi: Convert aspeed,ast2400-cf-fsi-master " Rob Herring (Arm)
2025-08-01 15:03   ` Eddie James
2025-08-04  1:38 ` [PATCH 0/6] ASpeed FSI DT clean-ups Andrew Jeffery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dbd00c1-7b47-4e6e-a8bc-5dd0b5d7e539@linux.ibm.com \
    --to=eajames@linux.ibm.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=benh@kernel.crashing.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-fsi@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ninad@linux.ibm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).