From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jeffery Date: Wed, 07 Aug 2019 10:06:00 +0930 Subject: =?UTF-8?Q?Re:_[PATCH]_pinctrl:_aspeed:_g6:_Remove_const_specifier_from_a?= =?UTF-8?Q?speed=5Fg6=5Fsig=5Fexpr=5Fset's_ctx_parameter?= In-Reply-To: <20190807003037.48457-1-natechancellor@gmail.com> References: <20190807003037.48457-1-natechancellor@gmail.com> Message-ID: <0e4bf79c-0e35-4cf4-b375-a023aa2cd034@www.fastmail.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, 7 Aug 2019, at 10:02, Nathan Chancellor wrote: > clang errors: > > drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c:2325:9: error: incompatible > pointer types initializing 'int (*)(struct aspeed_pinmux_data *, const > struct aspeed_sig_expr *, bool)' with an expression of type 'int (const > struct aspeed_pinmux_data *, const struct aspeed_sig_expr *, bool)' > [-Werror,-Wincompatible-pointer-types] > .set = aspeed_g6_sig_expr_set, > ^~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. > > Commit 674fa8daa8c9 ("pinctrl: aspeed-g5: Delay acquisition of regmaps") > changed the set function pointer declaration and the g6 one wasn't > updated (I assume because it wasn't merged yet). > > Fixes: 2eda1cdec49f ("pinctrl: aspeed: Add AST2600 pinmux support") > Link: https://github.com/ClangBuiltLinux/linux/issues/632 > Signed-off-by: Nathan Chancellor That's exactly what happened. Thanks. Reviewed-by: Andrew Jeffery