public inbox for linux-aspeed@lists.ozlabs.org
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Anirudh Srinivasan <anirudhsriniv@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: Add Asus IPMI card
Date: Thu, 15 Jan 2026 11:33:04 +1030	[thread overview]
Message-ID: <0e611132794491eecbcd3426222b6dca09a35b84.camel@codeconstruct.com.au> (raw)
In-Reply-To: <CAJ13v3QYWRfyivrbP=+hreHuMkYWGPkngW3kJyq6xNVL6YdpgQ@mail.gmail.com>

On Tue, 2026-01-13 at 16:28 -0600, Anirudh Srinivasan wrote:
> Hi Andrew
> 
> On Mon, Jan 12, 2026 at 6:57 PM Andrew Jeffery
> <andrew@codeconstruct.com.au> wrote:
> > 
> > Perhaps we could incorporate either of those?
> > 
> >  * asus,e21524-ipmi-expansion-card
> >  * asus,ipmi-expansion-card-r1-04
> > 
> > However, they're not without some risk:
> > 
> >    1. It's hard to tell whether E21524 is properly representative
> >    2. R1.04 may also problematic as an AST2700-based card will likely
> >       restart the numbering and risk a collision
> > 
> > Otherwise, I guess there's:
> > 
> >  * asus,ipmi-expansion-card-ast2600
> > 
> 
> There seem to be multiple revisions of this card. The photos have the
> revision number printed on the board and the manuals have the E21XXX
> number on them.
> R1.01 - E21362 photo [1] manual[2]
> R1.04 - E21524 photo [3] manual[4]
> 
> Mine is the latter. There seem to be some differences in the layout of
> the different headers on the board, but the same set of headers are on
> both boards. There is only one fw image on Asus's site, so I guess
> they're the same from a sw point of view.

Ah, interesting. So the R1.01 card also has an 'E' number silkscreened
on it - 'E248779', though this is different to E21362 from the manual.
E248779 seems to alias to a lot of other ASUS things. Given the
variance and aliasing it's probably a good idea to avoid them.

> 
> I've linked a screenshot [5] from the webui on the stock fw and it
> says that the firmware model is "KOMMANDO". Asus also seems to name
> the fw update file for this board KODO1140.ima (KODO is short for
> KOMMANDO?, 1140 is the version number).

> I looked at other Asus Motherboard onboard BMC fw updates and they
> seem to be named <Mobo Model><version>.ima. Example board "Pro WS
> W680M" [6], fw update name W680M1121.ima, another example board "Pro
> WS W790E" [7], fw update name W7901167.ima
> 
> "asus,kommando-ipmi-expansion-card" is a bit long, so maybe we should
> go with "asus,kodo-ipmi-expansion-card". SEO for either of the 2 terms
> is not very good, but that's not what we're looking for here are we?

So downloading the releases and poking around a bit, there's this:

   > for f in */*.ima; echo $f; dd if=$f bs=$(math 0x100) count=1 skip=$(math 0x3ff00) 2>/dev/null | strings | sed 's/^/\t/'; echo; end
   IPMI_EXPANSION_CARD-1.1.26/KODO1126.ima
   	$MODULE$
   	ast2600e
   	UFW_VERSION=1.01.26
   	FW_DATE=Jan 9 2023
   	FW_BUILDTIME=10:23:36 UTC
   	FW_DESC=AST2600EVB SPX-13 TB2
   	FW_PRODUCTID=1
   	FW_RELEASEID=RR9
   	FW_CODEBASEVERSION=5.X
   
   IPMI_EXPANSION_CARD-1.1.33/KODO1133.ima
   	$MODULE$
   	ast2600e
   	UFW_VERSION=1.01.33
   	FW_DATE=Jul 17 2023
   	FW_BUILDTIME=09:25:13 UTC
   	FW_DESC=AST2600EVB SPX-13 TB2
   	FW_PRODUCTID=1
   	FW_RELEASEID=RR9
   	FW_CODEBASEVERSION=5.X
   
   IPMI_EXPANSION_CARD-1.1.34/KODO1134.ima
   	$MODULE$
   	ast2600e
   	UFW_VERSION=1.01.34
   	FW_DATE=Feb 27 2024
   	FW_BUILDTIME=07:45:26 UTC
   	FW_DESC=AST2600EVB SPX-13 TB2
   	FW_PRODUCTID=1
   	FW_RELEASEID=RR9
   	FW_CODEBASEVERSION=5.X
   
   IPMI_EXPANSION_CARD-1.1.35/KODO1135.ima
   	$MODULE$
   	ast2600e
   	UFW_VERSION=1.01.35
   	FW_DATE=Aug 20 2024
   	FW_BUILDTIME=08:32:35 UTC
   	FW_DESC=AST2600EVB SPX-13 TB2
   	FW_PRODUCTID=1
   	FW_RELEASEID=RR9
   	FW_CODEBASEVERSION=5.X
   
   IPMI_EXPANSION_CARD-1.1.40/KODO1140.ima
   	$MODULE$
   	Oast2600e
   	UFW_VERSION=1.01.40
   	FW_DATE=Apr 15 2025
   	FW_BUILDTIME=09:52:26 UTC
   	FW_DESC=AST2600EVB KOMMANDO SPX-13 TB2
   	FW_PRODUCTID=1
   	FW_RELEASEID=RR9
   	FW_CODEBASEVERSION=5.X

KODO is pretty consistent in the firmware update file name. KOMMANDO as
the product identifier also seems reasonable, even if it only appears
in FW_DESC in the latest release. KODO -> KOMMANDO seems reasonable.

A brief bit of binwalking suggests it's an AMI MegaRAC implementation,
and so I expect 'SPX-13' in FW_DESC refers to MegaRAC SP-X[1]. The
significance of 'TB2' isn't yet unclear to me.

I'm not super concerned about the length of "asus,kommando-ipmi-
expansion-card" - I'd prefer it over incorporating the 'kodo'
contraction.

I guess it's still unclear whether 'kommando' is a (future) line of
products or refers to the specific AST2600-based design. Perhaps we
could solve a few problems with 'asus,kommando-ast2600' and including
the phrase 'IPMI expansion card' in the binding description for
something searchable.

Andrew

[1]: https://9443417.fs1.hubspotusercontent-na1.net/hubfs/9443417/Data_Sheets/Firmware_Solutions/MegaRAC_SP-X_Data_Sheet_PUB.pdf


  reply	other threads:[~2026-01-15  1:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-11 20:10 [PATCH 0/2] Add device tree for Asus IPMI Card Anirudh Srinivasan
2026-01-11 20:10 ` [PATCH 1/2] dt-bindings: arm: aspeed: Add Asus IPMI card Anirudh Srinivasan
2026-01-12  1:31   ` Andrew Jeffery
2026-01-12 11:47     ` Krzysztof Kozlowski
2026-01-12 21:21       ` Anirudh Srinivasan
2026-01-13  0:57         ` Andrew Jeffery
2026-01-13 22:28           ` Anirudh Srinivasan
2026-01-15  1:03             ` Andrew Jeffery [this message]
2026-01-15  4:38               ` Anirudh Srinivasan
2026-01-11 20:10 ` [PATCH 2/2] ARM: dts: " Anirudh Srinivasan
2026-01-11 21:09   ` Andrew Lunn
2026-01-11 21:26     ` Anirudh Srinivasan
2026-01-12  1:47   ` Andrew Jeffery
2026-01-12  2:35     ` Anirudh Srinivasan
2026-01-12 11:48   ` Krzysztof Kozlowski
2026-01-12 21:16     ` Anirudh Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e611132794491eecbcd3426222b6dca09a35b84.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=anirudhsriniv@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox