From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jeffery Date: Tue, 17 Oct 2017 22:05:58 +1030 Subject: [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall In-Reply-To: References: <20170920053020.6860-1-andrew@aj.id.au> <20170920053020.6860-5-andrew@aj.id.au> Message-ID: <1508240158.24322.16.camel@aj.id.au> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, 2017-09-20 at 15:43 +0930, Joel Stanley wrote: > > On Wed, Sep 20, 2017 at 3:00 PM, Andrew Jeffery wrote: > > Probing at device_initcall time lead to perverse cases where the > > watchdog was probed after, say, I2C devices, which then leaves a > > potentially running watchdog at the mercy of I2C device behaviour and > > bus conditions. > > > > Load the watchdog driver early to ensure that the kernel is patting it > > well before initialising peripherals. > > > > Signed-off-by: Andrew Jeffery > > I agree that we need to make sure the watchdog driver is loaded > earlier. I think this is the correct method, but I'll defer to Guenter > on this one. Just following up on Joel's comments: Is there anything else I need to address? Cheers, Andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: This is a digitally signed message part URL: