linux-aspeed.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@aj.id.au>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 3/3] ARM: config: multi_v5: Enable ASPEED drivers
Date: Tue, 24 Jul 2018 14:35:03 +0930	[thread overview]
Message-ID: <1532408703.2614071.1450754744.7B42962B@webmail.messagingengine.com> (raw)
In-Reply-To: <CACPK8Xd0ViuVAHgD4Nem5e_th0pf=4hmC=3d0XbLRGGzcDTMDg@mail.gmail.com>



On Tue, 24 Jul 2018, at 14:29, Joel Stanley wrote:
> On 24 July 2018 at 14:26, Andrew Jeffery <andrew@aj.id.au> wrote:
> >
> >
> > On Wed, 18 Jul 2018, at 23:23, Joel Stanley wrote:
> >> This enables the devices used in the AST2400 family of BMC SoCs:
> >>
> >>  - VUART
> >>  - SPI NOR
> >>  - LPC controller
> >>  - LPC snoop (port 80)
> >>  - Ethernet
> >>  - GPIO
> >>  - ADC
> >>  - I2C
> >>  - Random number generator
> >>  - IPMI KCS
> >>  - IPMI BT
> >>  - Fan/Tach
> >>
> >> Signed-off-by: Joel Stanley <joel@jms.id.au>
> >> ---
> >>  arch/arm/configs/multi_v5_defconfig | 14 +++++++++++++-
> >>  1 file changed, 13 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/configs/multi_v5_defconfig b/arch/arm/configs/
> >> multi_v5_defconfig
> >> index b647e249908e..318b76fa26d1 100644
> >> --- a/arch/arm/configs/multi_v5_defconfig
> >> +++ b/arch/arm/configs/multi_v5_defconfig
> >> @@ -90,10 +90,14 @@ CONFIG_MTD_PHYSMAP=y
> >>  CONFIG_MTD_NAND=y
> >>  CONFIG_MTD_NAND_ATMEL=y
> >>  CONFIG_MTD_NAND_ORION=y
> >> +CONFIG_MTD_SPI_NOR=y
> >> +CONFIG_SPI_ASPEED_SMC=y
> >>  CONFIG_MTD_UBI=y
> >>  CONFIG_BLK_DEV_LOOP=y
> >>  CONFIG_ATMEL_TCLIB=y
> >>  CONFIG_ATMEL_SSC=m
> >> +CONFIG_ASPEED_LPC_CTRL=m
> >> +CONFIG_ASPEED_LPC_SNOOP=m
> >
> > Any reason that you switch between module and built-in throughout? It's not clear from the commit message.
> 
> I tried to follow what the existing config did. Some things are
> modules, but some subsystems aren't.
> 
> I figured there's no harm in getting some build coverage of our
> drivers being modules.

Righto.

Acked-by: Andrew Jeffery <andrew@aj.id.au>

> 
> Cheers,
> 
> Joel

      reply	other threads:[~2018-07-24  5:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18 13:52 [PATCH 0/3] ARM: config: ASPEED and mutli v5 updates for 4.19 Joel Stanley
2018-07-18 13:53 ` [PATCH 1/3] ARM: config: aspeed: Update defconfig Joel Stanley
2018-07-24  4:49   ` Andrew Jeffery
2018-07-18 13:53 ` [PATCH 2/3] ARM: config: multi_v5: Refresh configuration Joel Stanley
2018-07-24  4:52   ` Andrew Jeffery
2018-07-18 13:53 ` [PATCH 3/3] ARM: config: multi_v5: Enable ASPEED drivers Joel Stanley
2018-07-24  4:56   ` Andrew Jeffery
2018-07-24  4:59     ` Joel Stanley
2018-07-24  5:05       ` Andrew Jeffery [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1532408703.2614071.1450754744.7B42962B@webmail.messagingengine.com \
    --to=andrew@aj.id.au \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).