From: Andrew Jeffery <andrew@aj.id.au>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option
Date: Tue, 11 Dec 2018 10:40:06 +1030 [thread overview]
Message-ID: <1544487006.3301683.1605247720.567E9685@webmail.messagingengine.com> (raw)
In-Reply-To: <20181211000506.7559-1-natechancellor@gmail.com>
On Tue, 11 Dec 2018, at 10:35, Nathan Chancellor wrote:
> Clang does not support this option:
>
> warning: unknown warning option '-Woverride-init'; did you mean
> '-Woverride-module'? [-Wunknown-warning-option]
> 1 warning generated.
>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> drivers/pinctrl/aspeed/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/aspeed/Makefile b/drivers/pinctrl/aspeed/Makefile
> index 191ed0fc1804..790b406aae19 100644
> --- a/drivers/pinctrl/aspeed/Makefile
> +++ b/drivers/pinctrl/aspeed/Makefile
> @@ -1,6 +1,6 @@
> # Aspeed pinctrl support
>
> -ccflags-y += -Woverride-init
> +ccflags-y += $(call cc-option,-Woverride-init)
> obj-$(CONFIG_PINCTRL_ASPEED) += pinctrl-aspeed.o
> obj-$(CONFIG_PINCTRL_ASPEED_G4) += pinctrl-aspeed-g4.o
> obj-$(CONFIG_PINCTRL_ASPEED_G5) += pinctrl-aspeed-g5.o
> --
> 2.20.0
>
next prev parent reply other threads:[~2018-12-11 0:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 0:05 [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option Nathan Chancellor
2018-12-11 0:10 ` Andrew Jeffery [this message]
2018-12-11 0:16 ` Joel Stanley
2018-12-11 0:25 ` Nathan Chancellor
2018-12-16 0:23 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544487006.3301683.1605247720.567E9685@webmail.messagingengine.com \
--to=andrew@aj.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox