* [PATCH 0/2] i2c: Aspeed: Add AST2600 compatible string @ 2019-09-13 16:35 Eddie James 2019-09-13 16:35 ` [PATCH 1/2] i2c: Aspeed: Add AST2600 compatible Eddie James 2019-09-13 16:35 ` [PATCH 2/2] dt-bindings: " Eddie James 0 siblings, 2 replies; 8+ messages in thread From: Eddie James @ 2019-09-13 16:35 UTC (permalink / raw) To: linux-aspeed Update the Aspeed I2C driver with the AST2600 compatible string. The default driver behavior works fine with the AST2600. A new compatible string is needed to avoid the AST2400 and AST2500 behavior. Eddie James (2): i2c: Aspeed: Add AST2600 compatible dt-bindings: i2c: Aspeed: Add AST2600 compatible Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 ++- drivers/i2c/busses/i2c-aspeed.c | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) -- 1.8.3.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] i2c: Aspeed: Add AST2600 compatible 2019-09-13 16:35 [PATCH 0/2] i2c: Aspeed: Add AST2600 compatible string Eddie James @ 2019-09-13 16:35 ` Eddie James 2019-09-13 16:47 ` Brendan Higgins 2019-10-21 12:23 ` Wolfram Sang 2019-09-13 16:35 ` [PATCH 2/2] dt-bindings: " Eddie James 1 sibling, 2 replies; 8+ messages in thread From: Eddie James @ 2019-09-13 16:35 UTC (permalink / raw) To: linux-aspeed The driver default behavior works with the AST2600. We need a new compatible though to make sure the driver doesn't enable AST2400 or AST2500 behavior. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- drivers/i2c/busses/i2c-aspeed.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c index fa66951..c2a6e5a 100644 --- a/drivers/i2c/busses/i2c-aspeed.c +++ b/drivers/i2c/busses/i2c-aspeed.c @@ -938,6 +938,10 @@ static int aspeed_i2c_reset(struct aspeed_i2c_bus *bus) .compatible = "aspeed,ast2500-i2c-bus", .data = aspeed_i2c_25xx_get_clk_reg_val, }, + { + .compatible = "aspeed,ast2600-i2c-bus", + .data = aspeed_i2c_25xx_get_clk_reg_val, + }, { }, }; MODULE_DEVICE_TABLE(of, aspeed_i2c_bus_of_table); -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] i2c: Aspeed: Add AST2600 compatible 2019-09-13 16:35 ` [PATCH 1/2] i2c: Aspeed: Add AST2600 compatible Eddie James @ 2019-09-13 16:47 ` Brendan Higgins 2019-10-21 12:23 ` Wolfram Sang 1 sibling, 0 replies; 8+ messages in thread From: Brendan Higgins @ 2019-09-13 16:47 UTC (permalink / raw) To: linux-aspeed On Fri, Sep 13, 2019 at 11:35:09AM -0500, Eddie James wrote: > The driver default behavior works with the AST2600. We need a new > compatible though to make sure the driver doesn't enable AST2400 or > AST2500 behavior. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> Reviewed-by: Brendan Higgins <brendanhiggins@google.com> Thanks! ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] i2c: Aspeed: Add AST2600 compatible 2019-09-13 16:35 ` [PATCH 1/2] i2c: Aspeed: Add AST2600 compatible Eddie James 2019-09-13 16:47 ` Brendan Higgins @ 2019-10-21 12:23 ` Wolfram Sang 1 sibling, 0 replies; 8+ messages in thread From: Wolfram Sang @ 2019-10-21 12:23 UTC (permalink / raw) To: linux-aspeed On Fri, Sep 13, 2019 at 11:35:09AM -0500, Eddie James wrote: > The driver default behavior works with the AST2600. We need a new > compatible though to make sure the driver doesn't enable AST2400 or > AST2500 behavior. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> Applied to for-next, thanks! -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20191021/2281d57d/attachment.sig> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] dt-bindings: i2c: Aspeed: Add AST2600 compatible 2019-09-13 16:35 [PATCH 0/2] i2c: Aspeed: Add AST2600 compatible string Eddie James 2019-09-13 16:35 ` [PATCH 1/2] i2c: Aspeed: Add AST2600 compatible Eddie James @ 2019-09-13 16:35 ` Eddie James 2019-09-13 16:48 ` Brendan Higgins ` (2 more replies) 1 sibling, 3 replies; 8+ messages in thread From: Eddie James @ 2019-09-13 16:35 UTC (permalink / raw) To: linux-aspeed Document the AST2600 I2C bus compatible string. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt index 8fbd863..b47f6cc 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt +++ b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt @@ -1,4 +1,4 @@ -Device tree configuration for the I2C busses on the AST24XX and AST25XX SoCs. +Device tree configuration for the I2C busses on the AST24XX, AST25XX, and AST26XX SoCs. Required Properties: - #address-cells : should be 1 @@ -6,6 +6,7 @@ Required Properties: - reg : address offset and range of bus - compatible : should be "aspeed,ast2400-i2c-bus" or "aspeed,ast2500-i2c-bus" + or "aspeed,ast2600-i2c-bus" - clocks : root clock of bus, should reference the APB clock in the second cell - resets : phandle to reset controller with the reset number in -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] dt-bindings: i2c: Aspeed: Add AST2600 compatible 2019-09-13 16:35 ` [PATCH 2/2] dt-bindings: " Eddie James @ 2019-09-13 16:48 ` Brendan Higgins 2019-09-30 18:59 ` Rob Herring 2019-10-21 12:23 ` Wolfram Sang 2 siblings, 0 replies; 8+ messages in thread From: Brendan Higgins @ 2019-09-13 16:48 UTC (permalink / raw) To: linux-aspeed On Fri, Sep 13, 2019 at 11:35:10AM -0500, Eddie James wrote: > Document the AST2600 I2C bus compatible string. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> Reviewed-by: Brendan Higgins <brendanhiggins@google.com> Thanks! ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] dt-bindings: i2c: Aspeed: Add AST2600 compatible 2019-09-13 16:35 ` [PATCH 2/2] dt-bindings: " Eddie James 2019-09-13 16:48 ` Brendan Higgins @ 2019-09-30 18:59 ` Rob Herring 2019-10-21 12:23 ` Wolfram Sang 2 siblings, 0 replies; 8+ messages in thread From: Rob Herring @ 2019-09-30 18:59 UTC (permalink / raw) To: linux-aspeed On Fri, Sep 13, 2019 at 11:35:10AM -0500, Eddie James wrote: > Document the AST2600 I2C bus compatible string. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> > --- > Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > index 8fbd863..b47f6cc 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > @@ -1,4 +1,4 @@ > -Device tree configuration for the I2C busses on the AST24XX and AST25XX SoCs. > +Device tree configuration for the I2C busses on the AST24XX, AST25XX, and AST26XX SoCs. Perhaps s/buses/busses/ while you're here. Acked-by: Rob Herring <robh@kernel.org> > > Required Properties: > - #address-cells : should be 1 > @@ -6,6 +6,7 @@ Required Properties: > - reg : address offset and range of bus > - compatible : should be "aspeed,ast2400-i2c-bus" > or "aspeed,ast2500-i2c-bus" > + or "aspeed,ast2600-i2c-bus" > - clocks : root clock of bus, should reference the APB > clock in the second cell > - resets : phandle to reset controller with the reset number in > -- > 1.8.3.1 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] dt-bindings: i2c: Aspeed: Add AST2600 compatible 2019-09-13 16:35 ` [PATCH 2/2] dt-bindings: " Eddie James 2019-09-13 16:48 ` Brendan Higgins 2019-09-30 18:59 ` Rob Herring @ 2019-10-21 12:23 ` Wolfram Sang 2 siblings, 0 replies; 8+ messages in thread From: Wolfram Sang @ 2019-10-21 12:23 UTC (permalink / raw) To: linux-aspeed On Fri, Sep 13, 2019 at 11:35:10AM -0500, Eddie James wrote: > Document the AST2600 I2C bus compatible string. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> Applied to for-next, thanks! -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20191021/f1b1e391/attachment.sig> ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-10-21 12:23 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-09-13 16:35 [PATCH 0/2] i2c: Aspeed: Add AST2600 compatible string Eddie James 2019-09-13 16:35 ` [PATCH 1/2] i2c: Aspeed: Add AST2600 compatible Eddie James 2019-09-13 16:47 ` Brendan Higgins 2019-10-21 12:23 ` Wolfram Sang 2019-09-13 16:35 ` [PATCH 2/2] dt-bindings: " Eddie James 2019-09-13 16:48 ` Brendan Higgins 2019-09-30 18:59 ` Rob Herring 2019-10-21 12:23 ` Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).