From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: joel@jms.id.au, gsomlo@gmail.com, heiko@sntech.de, arnd@arndb.de,
herve.codina@bootlin.com, andersson@kernel.org,
u.kleine-koenig@baylibre.com,
Henry Martin <bsdhenrymartin@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] soc: aspeed: Add NULL check in aspeed_lpc_enable_snoop()
Date: Thu, 03 Apr 2025 20:45:01 +1030 [thread overview]
Message-ID: <174367530124.3067819.2690843491529168690.b4-ty@codeconstruct.com.au> (raw)
In-Reply-To: <20250401074647.21300-1-bsdhenrymartin@gmail.com>
On Tue, 01 Apr 2025 15:46:47 +0800, Henry Martin wrote:
> devm_kasprintf() returns NULL when memory allocation fails. Currently,
> aspeed_lpc_enable_snoop() does not check for this case, which results in a
> NULL pointer dereference.
>
> Add NULL check after devm_kasprintf() to prevent this issue.
>
>
> [...]
Thanks, I've applied this to be picked up through the BMC tree.
--
Andrew Jeffery <andrew@codeconstruct.com.au>
prev parent reply other threads:[~2025-04-03 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 7:46 [PATCH v4] soc: aspeed: Add NULL check in aspeed_lpc_enable_snoop() Henry Martin
2025-04-03 10:15 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174367530124.3067819.2690843491529168690.b4-ty@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=bsdhenrymartin@gmail.com \
--cc=gsomlo@gmail.com \
--cc=heiko@sntech.de \
--cc=herve.codina@bootlin.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox