linux-aspeed.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 2/7] arm: dts: aspeed: Add aspeed G5 USB host pinmux
Date: Fri, 29 Jun 2018 13:51:01 +1000	[thread overview]
Message-ID: <20180629035106.27181-3-benh@kernel.crashing.org> (raw)
In-Reply-To: <20180629035106.27181-1-benh@kernel.crashing.org>

Set the default pinmux for EHCIs so boards don't have to do
it an document why it is not set for UHCI.

Remove the properties from the AST2500 EVB board which are
now redundant

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 arch/arm/boot/dts/aspeed-ast2500-evb.dts | 6 ------
 arch/arm/boot/dts/aspeed-g5.dtsi         | 8 ++++++++
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed-ast2500-evb.dts b/arch/arm/boot/dts/aspeed-ast2500-evb.dts
index ede11c597673..2bff1b253842 100644
--- a/arch/arm/boot/dts/aspeed-ast2500-evb.dts
+++ b/arch/arm/boot/dts/aspeed-ast2500-evb.dts
@@ -82,18 +82,12 @@
 
 &ehci0 {
 	status = "okay";
-	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_usb2ah_default>;
 };
 
 &ehci1 {
 	status = "okay";
-	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_usb2bh_default>;
 };
 
 &uhci {
 	status = "okay";
-
-	/* No pinctrl, this follows the above EHCI settings */
 };
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index 17f2714d18a7..dfdc239b86f6 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -148,6 +148,8 @@
 			reg = <0x1e6a1000 0x100>;
 			interrupts = <5>;
 			clocks = <&syscon ASPEED_CLK_GATE_USBPORT1CLK>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_usb2ah_default>;
 			status = "disabled";
 		};
 
@@ -156,6 +158,8 @@
 			reg = <0x1e6a3000 0x100>;
 			interrupts = <13>;
 			clocks = <&syscon ASPEED_CLK_GATE_USBPORT2CLK>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_usb2bh_default>;
 			status = "disabled";
 		};
 
@@ -166,6 +170,10 @@
 			#ports = <2>;
 			clocks = <&syscon ASPEED_CLK_GATE_USBUHCICLK>;
 			status = "disabled";
+			/*
+			 * No default pinmux, it will follow EHCI, use an explicit pinmux
+			 * override if you don't enable EHCI
+			 */
 		};
 
 		apb {
-- 
2.17.1


  parent reply	other threads:[~2018-06-29  3:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-29  3:50 [PATCH 0/7] arm: Aspeed DT & config updates for USB Benjamin Herrenschmidt
2018-06-29  3:51 ` [PATCH 1/7] arm: dts: aspeed: Add aspeed G4 USB pinmux Benjamin Herrenschmidt
2018-07-16  5:17   ` Andrew Jeffery
2018-06-29  3:51 ` Benjamin Herrenschmidt [this message]
2018-07-16  5:23   ` [PATCH 2/7] arm: dts: aspeed: Add aspeed G5 USB host pinmux Andrew Jeffery
2018-06-29  3:51 ` [PATCH 3/7] arm: dts: aspeed: Add Aspeed G4 USB Virtual Hub Benjamin Herrenschmidt
2018-07-16  5:34   ` Andrew Jeffery
2018-07-16  6:40     ` Benjamin Herrenschmidt
2018-07-16  6:43       ` Andrew Jeffery
2018-06-29  3:51 ` [PATCH 4/7] arm: dts: aspeed: Add Aspeed 54 " Benjamin Herrenschmidt
2018-07-16  5:36   ` Andrew Jeffery
2018-06-29  3:51 ` [PATCH 5/7] arm: configs: Add USB gadget to Aspeed G4 defconfig Benjamin Herrenschmidt
2018-07-16  5:37   ` Andrew Jeffery
2018-06-29  3:51 ` [PATCH 6/7] arm: configs: Add USB gadget to Aspeed G5 defconfig Benjamin Herrenschmidt
2018-07-16  5:38   ` Andrew Jeffery
2018-06-29  3:51 ` [PATCH 7/7] arm: dts: aspeed: Enable vhub on port A of AST2500 EVB Benjamin Herrenschmidt
2018-07-16  5:39   ` Andrew Jeffery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180629035106.27181-3-benh@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).