From: Rob Herring <robh@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH i2c-next v3 1/3] dt-bindings: i2c: aspeed: Add 'timeout' property as an optional property
Date: Thu, 27 Sep 2018 15:56:10 -0500 [thread overview]
Message-ID: <20180927205610.GA29022@bogus> (raw)
In-Reply-To: <20180926215842.23125-2-jae.hyun.yoo@linux.intel.com>
On Wed, Sep 26, 2018 at 02:58:40PM -0700, Jae Hyun Yoo wrote:
> This commit adds 'aspeed,timeout' property as an optional property
> which can be used for setting 'timeout' value of
> 'struct i2c_adapter'. With this patch, the timeout value can be
> set through an I2C_TIMEOUT ioctl on cdev, or through this optional
> DT property.
Isn't controlling this from userspace or relying on a default
sufficient? I can't see this needing to be highly tuned for each
platform.
However, if we do have a property, it should be common.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt
> index 8fbd8633a387..d6965b360fbc 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt
> @@ -17,6 +17,9 @@ Optional Properties:
> specified
> - multi-master : states that there is another master active on this bus.
>
> +- aspeed,timeout : I2C bus timeout in microseconds defaults to 5 seconds when
> + not specified.
> +
> Example:
>
> i2c {
> --
> 2.19.0
>
next prev parent reply other threads:[~2018-09-27 20:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 21:58 [PATCH i2c-next v3 0/3] i2c: aspeed: Add bus idle waiting logic for multi-master use cases Jae Hyun Yoo
2018-09-26 21:58 ` [PATCH i2c-next v3 1/3] dt-bindings: i2c: aspeed: Add 'timeout' property as an optional property Jae Hyun Yoo
2018-09-27 20:56 ` Rob Herring [this message]
2018-09-27 21:35 ` Jae Hyun Yoo
2018-09-26 21:58 ` [PATCH i2c-next v3 2/3] i2c: aspeed: Add 'aspeed, timeout' DT property reading code Jae Hyun Yoo
2018-09-27 3:11 ` [PATCH i2c-next v3 2/3] i2c: aspeed: Add 'aspeed,timeout' " Joel Stanley
2018-09-27 17:41 ` Jae Hyun Yoo
2018-09-26 21:58 ` [PATCH i2c-next v3 3/3] i2c: aspeed: Add bus idle waiting logic for multi-master use cases Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927205610.GA29022@bogus \
--to=robh@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).