From: Douglas Anderson <dianders@chromium.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2 4/5] serial: core: Include console.h from serial_core.h
Date: Tue, 30 Oct 2018 15:11:06 -0700 [thread overview]
Message-ID: <20181030221107.79758-5-dianders@chromium.org> (raw)
In-Reply-To: <20181030221107.79758-1-dianders@chromium.org>
In the static inline function uart_handle_break() in serial_core.h we
dereference port->cons. That gives an error unless console.h is also
included.
This error hasn't shown up till now because everyone who has defined
SUPPORT_SYSRQ has also included console.h, but it's a bit ugly to make
this requirement. Let's make the include explicit.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
include/linux/serial_core.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
index 3460b15a2607..ff9d0ee32f11 100644
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -22,6 +22,7 @@
#include <linux/bitops.h>
#include <linux/compiler.h>
+#include <linux/console.h>
#include <linux/interrupt.h>
#include <linux/circ_buf.h>
#include <linux/spinlock.h>
--
2.19.1.568.g152ad8e336-goog
next prev parent reply other threads:[~2018-10-30 22:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 22:11 [PATCH v2 0/5] serial: Finish sysrq on qcom_geni; fix sysrq vs. lockdep on 8250 Douglas Anderson
2018-10-30 22:11 ` [PATCH v2 1/5] serial: qcom_geni_serial: Finish supporting sysrq Douglas Anderson
2018-10-30 22:11 ` [PATCH v2 2/5] serial: core: Allow processing sysrq at port unlock time Douglas Anderson
2018-10-30 22:11 ` [PATCH v2 3/5] serial: qcom_geni_serial: Process " Douglas Anderson
2018-10-30 22:11 ` Douglas Anderson [this message]
2018-10-30 22:11 ` [PATCH v2 5/5] serial: 8250: " Douglas Anderson
2018-11-07 18:23 ` [PATCH v2 0/5] serial: Finish sysrq on qcom_geni; fix sysrq vs. lockdep on 8250 Andy Shevchenko
2018-11-07 19:26 ` Doug Anderson
2018-11-07 19:54 ` Andy Shevchenko
2018-11-08 9:41 ` Petr Mladek
2018-11-09 17:07 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030221107.79758-5-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).