From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Thu, 2 May 2019 08:40:21 +0200 Subject: [PATCH] misc: aspeed-lpc-ctrl: Correct return values In-Reply-To: <20190501223836.1670096-1-vijaykhemka@fb.com> References: <20190501223836.1670096-1-vijaykhemka@fb.com> Message-ID: <20190502064021.GA14911@kroah.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, May 01, 2019 at 03:38:36PM -0700, Vijay Khemka wrote: > Corrected some of return values with appropriate meanings. > > Signed-off-by: Vijay Khemka > --- > drivers/misc/aspeed-lpc-ctrl.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/drivers/misc/aspeed-lpc-ctrl.c b/drivers/misc/aspeed-lpc-ctrl.c > index 332210e06e98..97ae341109d5 100644 > --- a/drivers/misc/aspeed-lpc-ctrl.c > +++ b/drivers/misc/aspeed-lpc-ctrl.c > @@ -68,7 +68,6 @@ static long aspeed_lpc_ctrl_ioctl(struct file *file, unsigned int cmd, > unsigned long param) > { > struct aspeed_lpc_ctrl *lpc_ctrl = file_aspeed_lpc_ctrl(file); > - struct device *dev = file->private_data; > void __user *p = (void __user *)param; > struct aspeed_lpc_ctrl_mapping map; > u32 addr; This change is not reflected in your changelog text :( Please fix up, or break this up into multiple patches. greg k-h