* [PATCH linux dev-5.2] ARM: dts: aspeed: swift: Fix FSI GPIOs
@ 2019-07-19 20:21 Matt Spinler
0 siblings, 0 replies; 5+ messages in thread
From: Matt Spinler @ 2019-07-19 20:21 UTC (permalink / raw)
To: linux-aspeed
Change the FSI clock and data GPIOs to match what the hardware turned
out to use.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
---
arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
index caac895c60b4..f14f745b34ca 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
@@ -207,8 +207,8 @@
#size-cells = <0>;
no-gpio-delays;
- clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
- data-gpios = <&gpio ASPEED_GPIO(E, 0) GPIO_ACTIVE_HIGH>;
+ clock-gpios = <&gpio ASPEED_GPIO(P, 1) GPIO_ACTIVE_HIGH>;
+ data-gpios = <&gpio ASPEED_GPIO(P, 2) GPIO_ACTIVE_HIGH>;
mux-gpios = <&gpio ASPEED_GPIO(P, 4) GPIO_ACTIVE_HIGH>;
enable-gpios = <&gpio ASPEED_GPIO(P, 0) GPIO_ACTIVE_HIGH>;
trans-gpios = <&gpio ASPEED_GPIO(P, 3) GPIO_ACTIVE_HIGH>;
--
2.22.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH linux dev-5.2] ARM: dts: aspeed: swift: Fix FSI GPIOs
@ 2019-07-19 20:30 Matt Spinler
2019-07-22 20:23 ` Olof Johansson
2019-07-24 0:32 ` Andrew Jeffery
0 siblings, 2 replies; 5+ messages in thread
From: Matt Spinler @ 2019-07-19 20:30 UTC (permalink / raw)
To: linux-aspeed
From: Matt Spinler <spinler@us.ibm.com>
Change the FSI clock and data GPIOs to match what the hardware turned
out to use.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
---
arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
index caac895c60b4..f14f745b34ca 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
@@ -207,8 +207,8 @@
#size-cells = <0>;
no-gpio-delays;
- clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
- data-gpios = <&gpio ASPEED_GPIO(E, 0) GPIO_ACTIVE_HIGH>;
+ clock-gpios = <&gpio ASPEED_GPIO(P, 1) GPIO_ACTIVE_HIGH>;
+ data-gpios = <&gpio ASPEED_GPIO(P, 2) GPIO_ACTIVE_HIGH>;
mux-gpios = <&gpio ASPEED_GPIO(P, 4) GPIO_ACTIVE_HIGH>;
enable-gpios = <&gpio ASPEED_GPIO(P, 0) GPIO_ACTIVE_HIGH>;
trans-gpios = <&gpio ASPEED_GPIO(P, 3) GPIO_ACTIVE_HIGH>;
--
2.22.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH linux dev-5.2] ARM: dts: aspeed: swift: Fix FSI GPIOs
2019-07-19 20:30 Matt Spinler
@ 2019-07-22 20:23 ` Olof Johansson
2019-07-24 0:32 ` Andrew Jeffery
1 sibling, 0 replies; 5+ messages in thread
From: Olof Johansson @ 2019-07-22 20:23 UTC (permalink / raw)
To: linux-aspeed
On Fri, Jul 19, 2019 at 1:31 PM Matt Spinler <mspinler@linux.ibm.com> wrote:
>
> From: Matt Spinler <spinler@us.ibm.com>
>
> Change the FSI clock and data GPIOs to match what the hardware turned
> out to use.
>
> Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Hi,
This is not a comment on this patch specifically, just an overall
request for people to adjust how they post patches:
When running get_maintainer.pl on
arch/arm/boot/dts/aspeed-bmc-opp-swift.dts, I get the following:
[...]
linux-arm-kernel at lists.infradead.org (moderated list:ARM/ASPEED MACHINE SUPPORT)
linux-aspeed at lists.ozlabs.org (moderated list:ARM/ASPEED MACHINE SUPPORT)
[...]
Please include both of them on patches. Lots of people aren't
subscribed to the aspeed-only mailing list, so coming back later to
reply to a patch is hard when it hasn't made it into your mailboxes.
Thanks!
-Olof
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH linux dev-5.2] ARM: dts: aspeed: swift: Fix FSI GPIOs
2019-07-19 20:30 Matt Spinler
2019-07-22 20:23 ` Olof Johansson
@ 2019-07-24 0:32 ` Andrew Jeffery
2019-07-25 13:41 ` Adriana Kobylak
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Jeffery @ 2019-07-24 0:32 UTC (permalink / raw)
To: linux-aspeed
On Sat, 20 Jul 2019, at 06:01, Matt Spinler wrote:
> From: Matt Spinler <spinler@us.ibm.com>
>
> Change the FSI clock and data GPIOs to match what the hardware turned
> out to use.
>
> Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
And yeah, please make sure to include relevant lists in the future as Olof
mentioned.
Andrew
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> index caac895c60b4..f14f745b34ca 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> @@ -207,8 +207,8 @@
> #size-cells = <0>;
> no-gpio-delays;
>
> - clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
> - data-gpios = <&gpio ASPEED_GPIO(E, 0) GPIO_ACTIVE_HIGH>;
> + clock-gpios = <&gpio ASPEED_GPIO(P, 1) GPIO_ACTIVE_HIGH>;
> + data-gpios = <&gpio ASPEED_GPIO(P, 2) GPIO_ACTIVE_HIGH>;
> mux-gpios = <&gpio ASPEED_GPIO(P, 4) GPIO_ACTIVE_HIGH>;
> enable-gpios = <&gpio ASPEED_GPIO(P, 0) GPIO_ACTIVE_HIGH>;
> trans-gpios = <&gpio ASPEED_GPIO(P, 3) GPIO_ACTIVE_HIGH>;
> --
> 2.22.0
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH linux dev-5.2] ARM: dts: aspeed: swift: Fix FSI GPIOs
2019-07-24 0:32 ` Andrew Jeffery
@ 2019-07-25 13:41 ` Adriana Kobylak
0 siblings, 0 replies; 5+ messages in thread
From: Adriana Kobylak @ 2019-07-25 13:41 UTC (permalink / raw)
To: linux-aspeed
On 2019-07-23 19:32, Andrew Jeffery wrote:
> On Sat, 20 Jul 2019, at 06:01, Matt Spinler wrote:
>> From: Matt Spinler <spinler@us.ibm.com>
>>
>> Change the FSI clock and data GPIOs to match what the hardware turned
>> out to use.
>>
>> Signed-off-by: Matt Spinler <spinler@us.ibm.com>
>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Adriana Kobylak <anoo@us.ibm.com>
Schematics have been updated.
>
> And yeah, please make sure to include relevant lists in the future as
> Olof
> mentioned.
>
> Andrew
>
>> ---
>> arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
>> b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
>> index caac895c60b4..f14f745b34ca 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
>> @@ -207,8 +207,8 @@
>> #size-cells = <0>;
>> no-gpio-delays;
>>
>> - clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
>> - data-gpios = <&gpio ASPEED_GPIO(E, 0) GPIO_ACTIVE_HIGH>;
>> + clock-gpios = <&gpio ASPEED_GPIO(P, 1) GPIO_ACTIVE_HIGH>;
>> + data-gpios = <&gpio ASPEED_GPIO(P, 2) GPIO_ACTIVE_HIGH>;
>> mux-gpios = <&gpio ASPEED_GPIO(P, 4) GPIO_ACTIVE_HIGH>;
>> enable-gpios = <&gpio ASPEED_GPIO(P, 0) GPIO_ACTIVE_HIGH>;
>> trans-gpios = <&gpio ASPEED_GPIO(P, 3) GPIO_ACTIVE_HIGH>;
>> --
>> 2.22.0
>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-25 13:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-19 20:21 [PATCH linux dev-5.2] ARM: dts: aspeed: swift: Fix FSI GPIOs Matt Spinler
-- strict thread matches above, loose matches on Subject: below --
2019-07-19 20:30 Matt Spinler
2019-07-22 20:23 ` Olof Johansson
2019-07-24 0:32 ` Andrew Jeffery
2019-07-25 13:41 ` Adriana Kobylak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).