Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v3 3/4] watchdog/aspeed: add support for dual boot
Date: Tue, 27 Aug 2019 10:21:52 -0700	[thread overview]
Message-ID: <20190827172151.GA31588@roeck-us.net> (raw)
In-Reply-To: <20190827165426.17037-4-i.mikhaylov@yadro.com>

On Tue, Aug 27, 2019 at 07:54:25PM +0300, Ivan Mikhaylov wrote:
> Set WDT_CLEAR_TIMEOUT_AND_BOOT_CODE_SELECTION into WDT_CLEAR_TIMEOUT_STATUS
> to clear out boot code source and re-enable access to the primary SPI flash
> chip while booted via wdt2 from the alternate chip.
> 
> AST2400 datasheet says:
> "In the 2nd flash booting mode, all the address mapping to CS0# would be
> re-directed to CS1#. And CS0# is not accessable under this mode. To access
> CS0#, firmware should clear the 2nd boot mode register in the WDT2 status
> register WDT30.bit[1]."
> 
> Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com>

Please run "checkpatch --strict" on this patch and fix the reported problems
(I _did_ ask for proper multi-line aligment before, but there are a couple
of other issues as well).

Thanks,
Guenter

  reply	other threads:[~2019-08-27 17:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 16:54 [PATCH v3 0/4] add dual-boot support Ivan Mikhaylov
2019-08-27 16:54 ` [PATCH v3 1/4] vesnin: add wdt2 section with alt-boot option Ivan Mikhaylov
2019-08-27 16:54 ` [PATCH v3 2/4] vesnin: add secondary SPI flash chip Ivan Mikhaylov
2019-08-27 16:54 ` [PATCH v3 3/4] watchdog/aspeed: add support for dual boot Ivan Mikhaylov
2019-08-27 17:21   ` Guenter Roeck [this message]
2019-08-27 16:54 ` [PATCH v3 4/4] aspeed/watchdog: Add access_cs0 option for alt-boot Ivan Mikhaylov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190827172151.GA31588@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox