From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brendan Higgins Date: Tue, 8 Oct 2019 13:31:57 -0700 Subject: [PATCH 3/5] i2c: aspeed: fix master pending state handling In-Reply-To: <20191007231313.4700-4-jae.hyun.yoo@linux.intel.com> References: <20191007231313.4700-1-jae.hyun.yoo@linux.intel.com> <20191007231313.4700-4-jae.hyun.yoo@linux.intel.com> Message-ID: <20191008203157.GA184092@google.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Oct 07, 2019 at 04:13:11PM -0700, Jae Hyun Yoo wrote: > In case of master pending state, it should not trigger the master > command because this H/W is sharing the same data buffer for slave > and master operations, so this commit fixes the issue with making > the master command triggering happen when the state goes to active > state. nit: Makes sense, but can you explain what might happen without your change? > Signed-off-by: Jae Hyun Yoo Reviewed-by: Brendan Higgins Thanks!