From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corey Minyard Date: Tue, 3 Dec 2019 07:40:26 -0600 Subject: [PATCH 2/3] ipmi: kcs: Finish configuring ASPEED KCS device before enable In-Reply-To: <84315a29b453068373c096c03433e3a326731988.1575376664.git-series.andrew@aj.id.au> References: <84315a29b453068373c096c03433e3a326731988.1575376664.git-series.andrew@aj.id.au> Message-ID: <20191203134026.GI18165@minyard.net> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Dec 03, 2019 at 11:08:24PM +1030, Andrew Jeffery wrote: > The currently interrupts are configured after the channel was enabled. How about: The interrupts were configured after the channel was enabled, configure them before so they will work. -corey > > Signed-off-by: Andrew Jeffery > Reviewed-by: Joel Stanley > Reviewed-by: Haiyue Wang > --- > drivers/char/ipmi/kcs_bmc_aspeed.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c > index 3c955946e647..e3dd09022589 100644 > --- a/drivers/char/ipmi/kcs_bmc_aspeed.c > +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c > @@ -268,13 +268,14 @@ static int aspeed_kcs_probe(struct platform_device *pdev) > kcs_bmc->io_inputb = aspeed_kcs_inb; > kcs_bmc->io_outputb = aspeed_kcs_outb; > > + rc = aspeed_kcs_config_irq(kcs_bmc, pdev); > + if (rc) > + return rc; > + > dev_set_drvdata(dev, kcs_bmc); > > aspeed_kcs_set_address(kcs_bmc, addr); > aspeed_kcs_enable_channel(kcs_bmc, true); > - rc = aspeed_kcs_config_irq(kcs_bmc, pdev); > - if (rc) > - return rc; > > rc = misc_register(&kcs_bmc->miscdev); > if (rc) { > -- > git-series 0.9.1